From: Alyssa Rosenzweig <alyssa@collabora.com>
To: Steven Price <steven.price@arm.com>
Cc: dri-devel@lists.freedesktop.org,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panfrost: Remove type name from internal struct again
Date: Mon, 7 Nov 2022 08:22:48 -0500 [thread overview]
Message-ID: <Y2kGqIAE7WPYUTKx@maud> (raw)
In-Reply-To: <20221103114036.1581854-1-steven.price@arm.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
On Thu, Nov 03, 2022 at 11:40:36AM +0000, Steven Price wrote:
> Commit 72655fb942c1 ("drm/panfrost: replace endian-specific types with
> native ones") accidentally reverted part of the parent commit
> 7228d9d79248 ("drm/panfrost: Remove type name from internal structs")
> leading to the situation that the Panfrost UAPI header still doesn't
> compile correctly in C++.
>
> Revert the accidental revert and pass me a brown paper bag.
>
> Reported-by: Alyssa Rosenzweig <alyssa@collabora.com>
> Fixes: 72655fb942c1 ("drm/panfrost: replace endian-specific types with native ones")
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
> include/uapi/drm/panfrost_drm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_drm.h
> index 6f93c915cc88..9f231d40a146 100644
> --- a/include/uapi/drm/panfrost_drm.h
> +++ b/include/uapi/drm/panfrost_drm.h
> @@ -254,7 +254,7 @@ struct panfrost_dump_object_header {
> __u64 nbos;
> } reghdr;
>
> - struct pan_bomap_hdr {
> + struct {
> __u32 valid;
> __u64 iova;
> __u32 data[2];
> --
> 2.34.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Alyssa Rosenzweig <alyssa@collabora.com>
To: Steven Price <steven.price@arm.com>
Cc: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Rob Herring <robh@kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panfrost: Remove type name from internal struct again
Date: Mon, 7 Nov 2022 08:22:48 -0500 [thread overview]
Message-ID: <Y2kGqIAE7WPYUTKx@maud> (raw)
In-Reply-To: <20221103114036.1581854-1-steven.price@arm.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
On Thu, Nov 03, 2022 at 11:40:36AM +0000, Steven Price wrote:
> Commit 72655fb942c1 ("drm/panfrost: replace endian-specific types with
> native ones") accidentally reverted part of the parent commit
> 7228d9d79248 ("drm/panfrost: Remove type name from internal structs")
> leading to the situation that the Panfrost UAPI header still doesn't
> compile correctly in C++.
>
> Revert the accidental revert and pass me a brown paper bag.
>
> Reported-by: Alyssa Rosenzweig <alyssa@collabora.com>
> Fixes: 72655fb942c1 ("drm/panfrost: replace endian-specific types with native ones")
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
> include/uapi/drm/panfrost_drm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_drm.h
> index 6f93c915cc88..9f231d40a146 100644
> --- a/include/uapi/drm/panfrost_drm.h
> +++ b/include/uapi/drm/panfrost_drm.h
> @@ -254,7 +254,7 @@ struct panfrost_dump_object_header {
> __u64 nbos;
> } reghdr;
>
> - struct pan_bomap_hdr {
> + struct {
> __u32 valid;
> __u64 iova;
> __u32 data[2];
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-11-07 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 11:40 [PATCH] drm/panfrost: Remove type name from internal struct again Steven Price
2022-11-03 11:40 ` Steven Price
2022-11-07 13:22 ` Alyssa Rosenzweig [this message]
2022-11-07 13:22 ` Alyssa Rosenzweig
2022-11-07 15:47 ` Steven Price
2022-11-07 15:47 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2kGqIAE7WPYUTKx@maud \
--to=alyssa@collabora.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.