From: Sean Christopherson <seanjc@google.com>
To: Ben Gardon <bgardon@google.com>
Cc: kvm@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Will Deacon <will@kernel.org>,
kvmarm@lists.linux.dev, David Matlack <dmatlack@google.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 09/14] KVM: arm64: Atomically update stage 2 leaf attributes in parallel walks
Date: Wed, 9 Nov 2022 22:42:10 +0000 [thread overview]
Message-ID: <Y2wswsHgDHIIXram@google.com> (raw)
In-Reply-To: <CANgfPd9SK=9jUYh+aMXwYCf2-JtoJtSZ_BDmbjiZX=nvG-9uXA@mail.gmail.com>
On Wed, Nov 09, 2022, Ben Gardon wrote:
> On Mon, Nov 7, 2022 at 1:58 PM Oliver Upton <oliver.upton@linux.dev> wrote:
> > @@ -1054,7 +1066,7 @@ kvm_pte_t kvm_pgtable_stage2_mkold(struct kvm_pgtable *pgt, u64 addr)
> > bool kvm_pgtable_stage2_is_young(struct kvm_pgtable *pgt, u64 addr)
> > {
> > kvm_pte_t pte = 0;
> > - stage2_update_leaf_attrs(pgt, addr, 1, 0, 0, &pte, NULL);
> > + stage2_update_leaf_attrs(pgt, addr, 1, 0, 0, &pte, NULL, 0);
>
> Would be nice to have an enum for KVM_PGTABLE_WALK_EXCLUSIVE so this
> doesn't just have to pass 0.
That's also dangerous though since the param is a set of flags, not unique,
arbitrary values. E.g. this won't do the expected thing
if (flags & KVM_PGTABLE_WALK_EXCLUSIVE)
I assume compilers would complain, but never say never when it comes to compilers :-)
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Ben Gardon <bgardon@google.com>
Cc: Oliver Upton <oliver.upton@linux.dev>,
Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Reiji Watanabe <reijiw@google.com>,
Ricardo Koller <ricarkol@google.com>,
David Matlack <dmatlack@google.com>,
Quentin Perret <qperret@google.com>,
Gavin Shan <gshan@redhat.com>, Peter Xu <peterx@redhat.com>,
Will Deacon <will@kernel.org>,
kvmarm@lists.linux.dev
Subject: Re: [PATCH v5 09/14] KVM: arm64: Atomically update stage 2 leaf attributes in parallel walks
Date: Wed, 9 Nov 2022 22:42:10 +0000 [thread overview]
Message-ID: <Y2wswsHgDHIIXram@google.com> (raw)
Message-ID: <20221109224210.0uQwWuksReKykGZTknOzDpurgBgASDoKoLMxT5dYiaQ@z> (raw)
In-Reply-To: <CANgfPd9SK=9jUYh+aMXwYCf2-JtoJtSZ_BDmbjiZX=nvG-9uXA@mail.gmail.com>
On Wed, Nov 09, 2022, Ben Gardon wrote:
> On Mon, Nov 7, 2022 at 1:58 PM Oliver Upton <oliver.upton@linux.dev> wrote:
> > @@ -1054,7 +1066,7 @@ kvm_pte_t kvm_pgtable_stage2_mkold(struct kvm_pgtable *pgt, u64 addr)
> > bool kvm_pgtable_stage2_is_young(struct kvm_pgtable *pgt, u64 addr)
> > {
> > kvm_pte_t pte = 0;
> > - stage2_update_leaf_attrs(pgt, addr, 1, 0, 0, &pte, NULL);
> > + stage2_update_leaf_attrs(pgt, addr, 1, 0, 0, &pte, NULL, 0);
>
> Would be nice to have an enum for KVM_PGTABLE_WALK_EXCLUSIVE so this
> doesn't just have to pass 0.
That's also dangerous though since the param is a set of flags, not unique,
arbitrary values. E.g. this won't do the expected thing
if (flags & KVM_PGTABLE_WALK_EXCLUSIVE)
I assume compilers would complain, but never say never when it comes to compilers :-)
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Ben Gardon <bgardon@google.com>
Cc: Oliver Upton <oliver.upton@linux.dev>,
Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Reiji Watanabe <reijiw@google.com>,
Ricardo Koller <ricarkol@google.com>,
David Matlack <dmatlack@google.com>,
Quentin Perret <qperret@google.com>,
Gavin Shan <gshan@redhat.com>, Peter Xu <peterx@redhat.com>,
Will Deacon <will@kernel.org>,
kvmarm@lists.linux.dev
Subject: Re: [PATCH v5 09/14] KVM: arm64: Atomically update stage 2 leaf attributes in parallel walks
Date: Wed, 9 Nov 2022 22:42:10 +0000 [thread overview]
Message-ID: <Y2wswsHgDHIIXram@google.com> (raw)
In-Reply-To: <CANgfPd9SK=9jUYh+aMXwYCf2-JtoJtSZ_BDmbjiZX=nvG-9uXA@mail.gmail.com>
On Wed, Nov 09, 2022, Ben Gardon wrote:
> On Mon, Nov 7, 2022 at 1:58 PM Oliver Upton <oliver.upton@linux.dev> wrote:
> > @@ -1054,7 +1066,7 @@ kvm_pte_t kvm_pgtable_stage2_mkold(struct kvm_pgtable *pgt, u64 addr)
> > bool kvm_pgtable_stage2_is_young(struct kvm_pgtable *pgt, u64 addr)
> > {
> > kvm_pte_t pte = 0;
> > - stage2_update_leaf_attrs(pgt, addr, 1, 0, 0, &pte, NULL);
> > + stage2_update_leaf_attrs(pgt, addr, 1, 0, 0, &pte, NULL, 0);
>
> Would be nice to have an enum for KVM_PGTABLE_WALK_EXCLUSIVE so this
> doesn't just have to pass 0.
That's also dangerous though since the param is a set of flags, not unique,
arbitrary values. E.g. this won't do the expected thing
if (flags & KVM_PGTABLE_WALK_EXCLUSIVE)
I assume compilers would complain, but never say never when it comes to compilers :-)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-09 22:42 UTC|newest]
Thread overview: 156+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 21:56 [PATCH v5 00/14] KVM: arm64: Parallel stage-2 fault handling Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-07 21:56 ` [PATCH v5 01/14] KVM: arm64: Combine visitor arguments into a context structure Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-09 22:23 ` Ben Gardon
2022-11-09 22:23 ` Ben Gardon
2022-11-09 22:23 ` Ben Gardon
2022-11-09 22:48 ` Oliver Upton
2022-11-09 22:48 ` Oliver Upton
2022-11-09 22:48 ` Oliver Upton
2022-11-10 0:23 ` Gavin Shan
2022-11-10 0:23 ` Gavin Shan
2022-11-10 0:23 ` Gavin Shan
2022-11-10 0:42 ` Oliver Upton
2022-11-10 0:42 ` Oliver Upton
2022-11-10 0:42 ` Oliver Upton
2022-11-10 3:40 ` Gavin Shan
2022-11-10 3:40 ` Gavin Shan
2022-11-10 3:40 ` Gavin Shan
2022-11-07 21:56 ` [PATCH v5 02/14] KVM: arm64: Stash observed pte value in visitor context Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-09 22:23 ` Ben Gardon
2022-11-09 22:23 ` Ben Gardon
2022-11-09 22:23 ` Ben Gardon
2022-11-10 4:55 ` Gavin Shan
2022-11-10 4:55 ` Gavin Shan
2022-11-10 4:55 ` Gavin Shan
2022-11-07 21:56 ` [PATCH v5 03/14] KVM: arm64: Pass mm_ops through the " Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-09 22:23 ` Ben Gardon
2022-11-09 22:23 ` Ben Gardon
2022-11-09 22:23 ` Ben Gardon
2022-11-10 5:22 ` Gavin Shan
2022-11-10 5:22 ` Gavin Shan
2022-11-10 5:22 ` Gavin Shan
2022-11-10 5:30 ` Gavin Shan
2022-11-10 5:30 ` Gavin Shan
2022-11-10 5:30 ` Gavin Shan
2022-11-07 21:56 ` [PATCH v5 04/14] KVM: arm64: Don't pass kvm_pgtable through kvm_pgtable_walk_data Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-09 22:23 ` Ben Gardon
2022-11-09 22:23 ` Ben Gardon
2022-11-09 22:23 ` Ben Gardon
2022-11-10 5:30 ` Gavin Shan
2022-11-10 5:30 ` Gavin Shan
2022-11-10 5:30 ` Gavin Shan
2022-11-10 5:38 ` Oliver Upton
2022-11-10 5:38 ` Oliver Upton
2022-11-10 5:38 ` Oliver Upton
2022-11-07 21:56 ` [PATCH v5 05/14] KVM: arm64: Add a helper to tear down unlinked stage-2 subtrees Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-09 22:23 ` Ben Gardon
2022-11-09 22:23 ` Ben Gardon
2022-11-09 22:23 ` Ben Gardon
2022-11-09 22:54 ` Oliver Upton
2022-11-09 22:54 ` Oliver Upton
2022-11-09 22:54 ` Oliver Upton
2022-11-07 21:56 ` [PATCH v5 06/14] KVM: arm64: Use an opaque type for pteps Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-09 22:23 ` Ben Gardon
2022-11-09 22:23 ` Ben Gardon
2022-11-09 22:23 ` Ben Gardon
2022-11-07 21:56 ` [PATCH v5 07/14] KVM: arm64: Tear down unlinked stage-2 subtree after break-before-make Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-09 22:24 ` Ben Gardon
2022-11-09 22:24 ` Ben Gardon
2022-11-09 22:24 ` Ben Gardon
2022-11-07 21:56 ` [PATCH v5 08/14] KVM: arm64: Protect stage-2 traversal with RCU Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-09 21:53 ` Sean Christopherson
2022-11-09 21:53 ` Sean Christopherson
2022-11-09 21:53 ` Sean Christopherson
2022-11-09 23:55 ` Oliver Upton
2022-11-09 23:55 ` Oliver Upton
2022-11-09 23:55 ` Oliver Upton
2022-11-15 18:47 ` Ricardo Koller
2022-11-15 18:47 ` Ricardo Koller
2022-11-15 18:47 ` Ricardo Koller
2022-11-15 18:57 ` Oliver Upton
2022-11-15 18:57 ` Oliver Upton
2022-11-15 18:57 ` Oliver Upton
2022-11-09 22:25 ` Ben Gardon
2022-11-09 22:25 ` Ben Gardon
2022-11-09 22:25 ` Ben Gardon
2022-11-10 13:34 ` Marc Zyngier
2022-11-10 13:34 ` Marc Zyngier
2022-11-10 13:34 ` Marc Zyngier
2022-11-14 14:29 ` Marek Szyprowski
2022-11-14 14:29 ` Marek Szyprowski
2022-11-14 14:29 ` Marek Szyprowski
2022-11-14 17:42 ` Oliver Upton
2022-11-14 17:42 ` Oliver Upton
2022-11-14 17:42 ` Oliver Upton
2022-12-05 5:51 ` Mingwei Zhang
2022-12-05 5:51 ` Mingwei Zhang
2022-12-05 5:51 ` Mingwei Zhang
2022-12-05 7:47 ` Oliver Upton
2022-12-05 7:47 ` Oliver Upton
2022-12-05 7:47 ` Oliver Upton
2022-11-07 21:56 ` [PATCH v5 09/14] KVM: arm64: Atomically update stage 2 leaf attributes in parallel walks Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-09 22:26 ` Ben Gardon
2022-11-09 22:26 ` Ben Gardon
2022-11-09 22:26 ` Ben Gardon
2022-11-09 22:42 ` Sean Christopherson [this message]
2022-11-09 22:42 ` Sean Christopherson
2022-11-09 22:42 ` Sean Christopherson
2022-11-09 23:00 ` Ben Gardon
2022-11-09 23:00 ` Ben Gardon
2022-11-09 23:00 ` Ben Gardon
2022-11-10 13:40 ` Marc Zyngier
2022-11-10 13:40 ` Marc Zyngier
2022-11-10 13:40 ` Marc Zyngier
2022-11-07 21:56 ` [PATCH v5 10/14] KVM: arm64: Split init and set for table PTE Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-07 21:56 ` Oliver Upton
2022-11-09 22:26 ` Ben Gardon
2022-11-09 22:26 ` Ben Gardon
2022-11-09 22:26 ` Ben Gardon
2022-11-09 23:00 ` Oliver Upton
2022-11-09 23:00 ` Oliver Upton
2022-11-09 23:00 ` Oliver Upton
2022-11-07 21:58 ` [PATCH v5 11/14] KVM: arm64: Make block->table PTE changes parallel-aware Oliver Upton
2022-11-07 21:58 ` Oliver Upton
2022-11-07 21:58 ` Oliver Upton
2022-11-09 22:26 ` Ben Gardon
2022-11-09 22:26 ` Ben Gardon
2022-11-09 22:26 ` Ben Gardon
2022-11-09 23:03 ` Oliver Upton
2022-11-09 23:03 ` Oliver Upton
2022-11-09 23:03 ` Oliver Upton
2022-11-07 21:59 ` [PATCH v5 12/14] KVM: arm64: Make leaf->leaf " Oliver Upton
2022-11-07 21:59 ` Oliver Upton
2022-11-07 21:59 ` Oliver Upton
2022-11-09 22:26 ` Ben Gardon
2022-11-09 22:26 ` Ben Gardon
2022-11-09 22:26 ` Ben Gardon
2022-11-07 22:00 ` [PATCH v5 13/14] KVM: arm64: Make table->block " Oliver Upton
2022-11-07 22:00 ` Oliver Upton
2022-11-07 22:00 ` Oliver Upton
2022-11-07 22:00 ` [PATCH v5 14/14] KVM: arm64: Handle stage-2 faults in parallel Oliver Upton
2022-11-07 22:00 ` Oliver Upton
2022-11-07 22:00 ` Oliver Upton
2022-11-11 15:47 ` [PATCH v5 00/14] KVM: arm64: Parallel stage-2 fault handling Marc Zyngier
2022-11-11 15:47 ` Marc Zyngier
2022-11-11 15:47 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2wswsHgDHIIXram@google.com \
--to=seanjc@google.com \
--cc=bgardon@google.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.