All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "kishon@kernel.org" <kishon@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>
Subject: Re: [RESEND PATCH v3 2/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8
Date: Thu, 10 Nov 2022 12:36:32 +0530	[thread overview]
Message-ID: <Y2yi+PRyupPGCB9k@matsya> (raw)
In-Reply-To: <TYBPR01MB5341DC696FCF3B7D4E139006D83C9@TYBPR01MB5341.jpnprd01.prod.outlook.com>

On 07-11-22, 01:50, Yoshihiro Shimoda wrote:
> Hi Vinod,
> 
> > From: Vinod Koul, Sent: Saturday, November 5, 2022 11:31 PM
> > 
> > On 27-10-22, 22:40, Yoshihiro Shimoda wrote:
> > > Add Renesas Ethernet SERDES driver for R-Car S4-8 (r8a779f0).
> > > The datasheet describes initialization procedure without any information
> > > about registers' name/bits. So, this is all black magic to initialize
> > > the hardware. Especially, all channels should be initialized at once.
> > >
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > > ---
> > >  drivers/phy/renesas/Kconfig                 |   7 +
> > >  drivers/phy/renesas/Makefile                |   1 +
> > >  drivers/phy/renesas/r8a779f0-ether-serdes.c | 416 ++++++++++++++++++++
> > >  3 files changed, 424 insertions(+)
> > >  create mode 100644 drivers/phy/renesas/r8a779f0-ether-serdes.c
> > >
> > > diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig
> > > index 111bdcae775c..68f160b0e8ef 100644
> > > --- a/drivers/phy/renesas/Kconfig
> > > +++ b/drivers/phy/renesas/Kconfig
> > > @@ -32,3 +32,10 @@ config PHY_RCAR_GEN3_USB3
> > >  	select GENERIC_PHY
> > >  	help
> > >  	  Support for USB 3.0 PHY found on Renesas R-Car generation 3 SoCs.
> > > +
> > > +config PHY_R8A779F0_ETHERNET_SERDES
> > > +	tristate "Renesas R-Car S4-8 Ethernet SERDES driver"
> > > +	depends on ARCH_RENESAS || COMPILE_TEST
> > > +	select GENERIC_PHY
> > > +	help
> > > +	  Support for Ethernet SERDES found on Renesas R-Car S4-8 SoCs.
> > 
> > Sorted alphabetically please and not at the end
> 
> I intended to sort alphabetically about the prompt strings:
> 
> <snip>
> "Renesas R-Car generation 3 USB 2.0 PHY driver"
> "Renesas R-Car generation 3 USB 3.0 PHY driver"
> "Renesas R-Car S4-8 Ethernet SERDES driver"
> 
> However, IIUC, should we sort alphabetically about the config strings like below?
> 
> config PHY_R8A779F0_ETHERNET_SERDES
> config PHY_RCAR_GEN3_PCIE

We sort them based on config symbol and not the prompt string
-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "kishon@kernel.org" <kishon@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>
Subject: Re: [RESEND PATCH v3 2/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8
Date: Thu, 10 Nov 2022 12:36:32 +0530	[thread overview]
Message-ID: <Y2yi+PRyupPGCB9k@matsya> (raw)
In-Reply-To: <TYBPR01MB5341DC696FCF3B7D4E139006D83C9@TYBPR01MB5341.jpnprd01.prod.outlook.com>

On 07-11-22, 01:50, Yoshihiro Shimoda wrote:
> Hi Vinod,
> 
> > From: Vinod Koul, Sent: Saturday, November 5, 2022 11:31 PM
> > 
> > On 27-10-22, 22:40, Yoshihiro Shimoda wrote:
> > > Add Renesas Ethernet SERDES driver for R-Car S4-8 (r8a779f0).
> > > The datasheet describes initialization procedure without any information
> > > about registers' name/bits. So, this is all black magic to initialize
> > > the hardware. Especially, all channels should be initialized at once.
> > >
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > > ---
> > >  drivers/phy/renesas/Kconfig                 |   7 +
> > >  drivers/phy/renesas/Makefile                |   1 +
> > >  drivers/phy/renesas/r8a779f0-ether-serdes.c | 416 ++++++++++++++++++++
> > >  3 files changed, 424 insertions(+)
> > >  create mode 100644 drivers/phy/renesas/r8a779f0-ether-serdes.c
> > >
> > > diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig
> > > index 111bdcae775c..68f160b0e8ef 100644
> > > --- a/drivers/phy/renesas/Kconfig
> > > +++ b/drivers/phy/renesas/Kconfig
> > > @@ -32,3 +32,10 @@ config PHY_RCAR_GEN3_USB3
> > >  	select GENERIC_PHY
> > >  	help
> > >  	  Support for USB 3.0 PHY found on Renesas R-Car generation 3 SoCs.
> > > +
> > > +config PHY_R8A779F0_ETHERNET_SERDES
> > > +	tristate "Renesas R-Car S4-8 Ethernet SERDES driver"
> > > +	depends on ARCH_RENESAS || COMPILE_TEST
> > > +	select GENERIC_PHY
> > > +	help
> > > +	  Support for Ethernet SERDES found on Renesas R-Car S4-8 SoCs.
> > 
> > Sorted alphabetically please and not at the end
> 
> I intended to sort alphabetically about the prompt strings:
> 
> <snip>
> "Renesas R-Car generation 3 USB 2.0 PHY driver"
> "Renesas R-Car generation 3 USB 3.0 PHY driver"
> "Renesas R-Car S4-8 Ethernet SERDES driver"
> 
> However, IIUC, should we sort alphabetically about the config strings like below?
> 
> config PHY_R8A779F0_ETHERNET_SERDES
> config PHY_RCAR_GEN3_PCIE

We sort them based on config symbol and not the prompt string
-- 
~Vinod

  reply	other threads:[~2022-11-10  7:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27 13:40 [RESEND PATCH v3 0/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8 Yoshihiro Shimoda
2022-10-27 13:40 ` Yoshihiro Shimoda
2022-10-27 13:40 ` [RESEND PATCH v3 1/2] dt-bindings: phy: renesas: Document Renesas Ethernet SERDES Yoshihiro Shimoda
2022-10-27 13:40   ` Yoshihiro Shimoda
2022-10-28  1:23   ` Krzysztof Kozlowski
2022-10-28  1:23     ` Krzysztof Kozlowski
2022-10-27 13:40 ` [RESEND PATCH v3 2/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8 Yoshihiro Shimoda
2022-10-27 13:40   ` Yoshihiro Shimoda
2022-11-05 14:30   ` Vinod Koul
2022-11-05 14:30     ` Vinod Koul
2022-11-07  1:50     ` Yoshihiro Shimoda
2022-11-07  1:50       ` Yoshihiro Shimoda
2022-11-10  7:06       ` Vinod Koul [this message]
2022-11-10  7:06         ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2yi+PRyupPGCB9k@matsya \
    --to=vkoul@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.