From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 5/5] driver core: pass a const * into of_device_uevent()
Date: Wed, 23 Nov 2022 10:57:38 +0100 [thread overview]
Message-ID: <Y33ukqDN93tnwHX8@kroah.com> (raw)
In-Reply-To: <20221122212209.GA583854-robh@kernel.org>
On Tue, Nov 22, 2022 at 03:22:09PM -0600, Rob Herring wrote:
> On Mon, Nov 21, 2022 at 10:46:49AM +0100, Greg Kroah-Hartman wrote:
> > of_device_uevent() does not modify the struct device * passed into it,
> > so make it a const * to enforce this. Also the documentation for the
> > function was really wrong so fix that up at the same time.
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Frank Rowand <frowand.list@gmail.com>
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > drivers/of/device.c | 6 +++---
> > include/linux/of_device.h | 4 ++--
> > 2 files changed, 5 insertions(+), 5 deletions(-)
>
> Looks like I can take this one?
I need it for later patches I have coming that clean this up more.
But you can take it in your tree as well if you want to build on top of
it.
> The same could be done for several other functions in of/device.c.
That would be good!
thanks,
greg k-h
next prev parent reply other threads:[~2022-11-23 10:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 9:46 [Bridge] [PATCH 1/5] kobject: make kobject_get_ownership() take a constant kobject * Greg Kroah-Hartman
2022-11-21 9:46 ` Greg Kroah-Hartman
2022-11-21 9:46 ` [PATCH 2/5] kobject: make kobject_namespace take a const * Greg Kroah-Hartman
2022-11-21 11:49 ` Rafael J. Wysocki
2022-11-21 9:46 ` [PATCH 3/5] kobject: kset_uevent_ops: make filter() callback " Greg Kroah-Hartman
2022-11-21 9:46 ` Greg Kroah-Hartman
2022-11-21 9:51 ` [Linaro-mm-sig] " Christian König
2022-11-21 9:51 ` Christian König
2022-11-21 11:49 ` Rafael J. Wysocki
2022-11-21 11:49 ` Rafael J. Wysocki
2022-11-21 9:46 ` [PATCH 4/5] kobject: kset_uevent_ops: make name() " Greg Kroah-Hartman
2022-11-21 11:50 ` Rafael J. Wysocki
2022-11-21 9:46 ` [PATCH 5/5] driver core: pass a const * into of_device_uevent() Greg Kroah-Hartman
2022-11-22 21:22 ` Rob Herring
2022-11-23 9:57 ` Greg Kroah-Hartman [this message]
2022-11-21 10:53 ` [Bridge] [PATCH 1/5] kobject: make kobject_get_ownership() take a constant kobject * Nikolay Aleksandrov
2022-11-21 10:53 ` Nikolay Aleksandrov
2022-11-21 11:48 ` [Bridge] " Rafael J. Wysocki
2022-11-21 11:48 ` Rafael J. Wysocki
2022-11-21 20:18 ` [Bridge] " Jakub Kicinski
2022-11-21 20:18 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y33ukqDN93tnwHX8@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.