From: Jakub Kicinski <kuba@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-nfs@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
netdev@vger.kernel.org, Nikolay Aleksandrov <razor@blackwall.org>,
bridge@lists.linux-foundation.org,
Jeff Layton <jlayton@kernel.org>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Chuck Lever <chuck.lever@oracle.com>,
Anna Schumaker <anna@kernel.org>, Roopa Prabhu <roopa@nvidia.com>,
Paolo Abeni <pabeni@redhat.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>
Subject: Re: [Bridge] [PATCH 1/5] kobject: make kobject_get_ownership() take a constant kobject *
Date: Mon, 21 Nov 2022 12:18:03 -0800 [thread overview]
Message-ID: <20221121121803.31962489@kernel.org> (raw)
In-Reply-To: <20221121094649.1556002-1-gregkh@linuxfoundation.org>
On Mon, 21 Nov 2022 10:46:45 +0100 Greg Kroah-Hartman wrote:
> The call, kobject_get_ownership(), does not modify the kobject passed
> into it, so make it const. This propagates down into the kobj_type
> function callbacks so make the kobject passed into them also const,
> ensuring that nothing in the kobject is being changed here.
>
> This helps make it more obvious what calls and callbacks do, and do not,
> modify structures passed to them.
Acked-by: Jakub Kicinski <kuba@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>, Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>,
linux-nfs@vger.kernel.org, bridge@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/5] kobject: make kobject_get_ownership() take a constant kobject *
Date: Mon, 21 Nov 2022 12:18:03 -0800 [thread overview]
Message-ID: <20221121121803.31962489@kernel.org> (raw)
In-Reply-To: <20221121094649.1556002-1-gregkh@linuxfoundation.org>
On Mon, 21 Nov 2022 10:46:45 +0100 Greg Kroah-Hartman wrote:
> The call, kobject_get_ownership(), does not modify the kobject passed
> into it, so make it const. This propagates down into the kobj_type
> function callbacks so make the kobject passed into them also const,
> ensuring that nothing in the kobject is being changed here.
>
> This helps make it more obvious what calls and callbacks do, and do not,
> modify structures passed to them.
Acked-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2022-11-21 20:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 9:46 [Bridge] [PATCH 1/5] kobject: make kobject_get_ownership() take a constant kobject * Greg Kroah-Hartman
2022-11-21 9:46 ` Greg Kroah-Hartman
2022-11-21 9:46 ` [PATCH 2/5] kobject: make kobject_namespace take a const * Greg Kroah-Hartman
2022-11-21 11:49 ` Rafael J. Wysocki
2022-11-21 9:46 ` [PATCH 3/5] kobject: kset_uevent_ops: make filter() callback " Greg Kroah-Hartman
2022-11-21 9:46 ` Greg Kroah-Hartman
2022-11-21 9:51 ` [Linaro-mm-sig] " Christian König
2022-11-21 9:51 ` Christian König
2022-11-21 11:49 ` Rafael J. Wysocki
2022-11-21 11:49 ` Rafael J. Wysocki
2022-11-21 9:46 ` [PATCH 4/5] kobject: kset_uevent_ops: make name() " Greg Kroah-Hartman
2022-11-21 11:50 ` Rafael J. Wysocki
2022-11-21 9:46 ` [PATCH 5/5] driver core: pass a const * into of_device_uevent() Greg Kroah-Hartman
2022-11-22 21:22 ` Rob Herring
2022-11-23 9:57 ` Greg Kroah-Hartman
2022-11-21 10:53 ` [Bridge] [PATCH 1/5] kobject: make kobject_get_ownership() take a constant kobject * Nikolay Aleksandrov
2022-11-21 10:53 ` Nikolay Aleksandrov
2022-11-21 11:48 ` [Bridge] " Rafael J. Wysocki
2022-11-21 11:48 ` Rafael J. Wysocki
2022-11-21 20:18 ` Jakub Kicinski [this message]
2022-11-21 20:18 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121121803.31962489@kernel.org \
--to=kuba@kernel.org \
--cc=anna@kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.