From: Sean Christopherson <seanjc@google.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org, mhal@rbox.co
Subject: Re: [PATCH 2/4] KVM: x86/xen: Compatibility fixes for shared runstate area
Date: Wed, 23 Nov 2022 18:16:21 +0000 [thread overview]
Message-ID: <Y35jdRxK27o96r//@google.com> (raw)
In-Reply-To: <ff2c3f2ea7286e78bb2cfb1fdb218401e87cef1e.camel@infradead.org>
On Wed, Nov 23, 2022, David Woodhouse wrote:
> On Wed, 2022-11-23 at 17:17 +0000, Sean Christopherson wrote:
> And with or without that cache, we can *still* end up doing a partial
> update if the page goes away. The byte with the XEN_RUNSTATE_UPDATE bit
> might still be accessible, but bets are off about what state the rest
> of the structure is in — and those runtimes are supposed to add up, or
> the guest is going to get unhappy.
Ugh. What a terrible ABI.
> I'm actually OK with locking two GPCs. It wasn't my first choice, but
> it's reasonable enough IMO given that none of the alternatives jump out
> as being particularly attractive either.
I detest the two GPCs, but since KVM apparently needs to provide "all or nothing"
updates, I don't see a better option.
next prev parent reply other threads:[~2022-11-23 18:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 9:46 [PATCH 1/4] MAINTAINERS: Add KVM x86/xen maintainer list David Woodhouse
2022-11-19 9:46 ` [PATCH 2/4] KVM: x86/xen: Compatibility fixes for shared runstate area David Woodhouse
2022-11-19 11:38 ` Durrant, Paul
2022-11-19 11:46 ` David Woodhouse
2022-11-22 18:39 ` Sean Christopherson
2022-11-22 23:04 ` David Woodhouse
2022-11-23 17:17 ` Sean Christopherson
2022-11-23 17:58 ` David Woodhouse
2022-11-23 18:16 ` Sean Christopherson [this message]
2022-11-23 18:48 ` David Woodhouse
2022-11-22 23:46 ` Michal Luczaj
2022-11-23 0:03 ` David Woodhouse
2022-11-23 18:21 ` Sean Christopherson
2022-11-23 19:22 ` David Woodhouse
2022-11-23 19:32 ` Sean Christopherson
2022-11-23 20:07 ` David Woodhouse
2022-11-23 20:26 ` Sean Christopherson
2022-11-19 9:46 ` [PATCH 3/4] KVM: Update gfn_to_pfn_cache khva when it moves within the same page David Woodhouse
2022-11-19 11:40 ` Durrant, Paul
2022-11-22 16:23 ` Sean Christopherson
2022-11-22 16:49 ` Paul Durrant
2022-11-22 17:02 ` David Woodhouse
2022-11-22 19:09 ` Sean Christopherson
2022-11-22 23:13 ` David Woodhouse
2022-11-24 0:31 ` Paolo Bonzini
2022-11-24 0:45 ` David Woodhouse
2022-11-24 0:54 ` David Woodhouse
2022-11-24 1:11 ` Paolo Bonzini
2022-11-24 10:41 ` David Woodhouse
2022-11-24 11:30 ` David Woodhouse
2022-11-19 9:46 ` [PATCH 4/4] KVM: x86/xen: Add runstate tests for 32-bit mode and crossing page boundary David Woodhouse
2022-11-19 11:42 ` Durrant, Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y35jdRxK27o96r//@google.com \
--to=seanjc@google.com \
--cc=dwmw2@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.