From: Sean Christopherson <seanjc@google.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org, mhal@rbox.co
Subject: Re: [PATCH 2/4] KVM: x86/xen: Compatibility fixes for shared runstate area
Date: Wed, 23 Nov 2022 20:26:27 +0000 [thread overview]
Message-ID: <Y36B811dDGwP6ce9@google.com> (raw)
In-Reply-To: <cf0cb246dd25790a839a5cb2188290f680df5d44.camel@infradead.org>
On Wed, Nov 23, 2022, David Woodhouse wrote:
> On Wed, 2022-11-23 at 19:32 +0000, Sean Christopherson wrote:
> > Right. Might be worth adding a comment at some point to call out that disabling
> > IRQs may not be strictly required for all users, but it's done for simplicity.
> > Ah, if/when we add kvm_gpc_lock(), that would be the perfect place to document
> > the behavior.
>
> Yeah. Or perhaps the kvm_gpc_lock() should go with that 'not required
> for all users, but done for simplicity' angle too, and always disable
> IRQs?
I was thinking the latter (always disable IRQs in kvm_gpc_lock()). Sorry I didn't
make that clear. I completely agree that fewer conditionals in this code is better,
I was mostly trying to figure out if there is some edge case I was missing.
next prev parent reply other threads:[~2022-11-23 20:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 9:46 [PATCH 1/4] MAINTAINERS: Add KVM x86/xen maintainer list David Woodhouse
2022-11-19 9:46 ` [PATCH 2/4] KVM: x86/xen: Compatibility fixes for shared runstate area David Woodhouse
2022-11-19 11:38 ` Durrant, Paul
2022-11-19 11:46 ` David Woodhouse
2022-11-22 18:39 ` Sean Christopherson
2022-11-22 23:04 ` David Woodhouse
2022-11-23 17:17 ` Sean Christopherson
2022-11-23 17:58 ` David Woodhouse
2022-11-23 18:16 ` Sean Christopherson
2022-11-23 18:48 ` David Woodhouse
2022-11-22 23:46 ` Michal Luczaj
2022-11-23 0:03 ` David Woodhouse
2022-11-23 18:21 ` Sean Christopherson
2022-11-23 19:22 ` David Woodhouse
2022-11-23 19:32 ` Sean Christopherson
2022-11-23 20:07 ` David Woodhouse
2022-11-23 20:26 ` Sean Christopherson [this message]
2022-11-19 9:46 ` [PATCH 3/4] KVM: Update gfn_to_pfn_cache khva when it moves within the same page David Woodhouse
2022-11-19 11:40 ` Durrant, Paul
2022-11-22 16:23 ` Sean Christopherson
2022-11-22 16:49 ` Paul Durrant
2022-11-22 17:02 ` David Woodhouse
2022-11-22 19:09 ` Sean Christopherson
2022-11-22 23:13 ` David Woodhouse
2022-11-24 0:31 ` Paolo Bonzini
2022-11-24 0:45 ` David Woodhouse
2022-11-24 0:54 ` David Woodhouse
2022-11-24 1:11 ` Paolo Bonzini
2022-11-24 10:41 ` David Woodhouse
2022-11-24 11:30 ` David Woodhouse
2022-11-19 9:46 ` [PATCH 4/4] KVM: x86/xen: Add runstate tests for 32-bit mode and crossing page boundary David Woodhouse
2022-11-19 11:42 ` Durrant, Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y36B811dDGwP6ce9@google.com \
--to=seanjc@google.com \
--cc=dwmw2@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.