Re: [PATCH v2 02/13] dt-bindings: usb: Add NVIDIA Tegra234 XUSB host controller binding

From: Thierry Reding <thierry.reding@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Jon Hunter <jonathanh@nvidia.com>,
	Wayne Chang <waynec@nvidia.com>,
	mathias.nyman@intel.com, p.zabel@pengutronix.de,
	devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linux-tegra@vger.kernel.org, singhanc@nvidia.com,
	balbi@kernel.org, linux-phy@lists.infradead.org,
	vkoul@kernel.org, ajayg@nvidia.com,
	heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
	treding@nvidia.com, jckuo@nvidia.com,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 02/13] dt-bindings: usb: Add NVIDIA Tegra234 XUSB host controller binding
Date: Mon, 14 Nov 2022 11:15:30 +0100	[thread overview]
Message-ID: <Y3IVQtY94GenVpGL@orome> (raw)
In-Reply-To: <20221111173236.GA3561612-robh@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1962 bytes --]

On Fri, Nov 11, 2022 at 11:32:36AM -0600, Rob Herring wrote:
> On Fri, Nov 11, 2022 at 02:38:21PM +0000, Jon Hunter wrote:
> > 
> > On 11/11/2022 13:30, Rob Herring wrote:
> > > 
> > > On Fri, 11 Nov 2022 18:14:58 +0800, Wayne Chang wrote:
> > > > Add device-tree binding documentation for the XUSB host controller present
> > > > on Tegra234 SoC. This controller supports the USB 3.1 specification.
> > > > 
> > > > Signed-off-by: Wayne Chang <waynec@nvidia.com>
> > > > ---
> > > > V1 -> V2: new change for adding nvidia,tegra234-xusb.yaml
> > > >   .../bindings/usb/nvidia,tegra234-xusb.yaml    | 159 ++++++++++++++++++
> > > >   1 file changed, 159 insertions(+)
> > > >   create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml
> > > > 
> > > 
> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > > 
> > > yamllint warnings/errors:
> > > 
> > > dtschema/dtc warnings/errors:
> > > Error: Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.example.dts:36.27-28 syntax error
> > > FATAL ERROR: Unable to parse input tree
> > > make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.example.dtb] Error 1
> > > make[1]: *** Waiting for unfinished jobs....
> > > make: *** [Makefile:1492: dt_binding_check] Error 2
> > 
> > This compiles fine on top of -next. We are just missing the change that
> > populates the required definitions.
> 
> Where exactly is that mentioned in the commit msg?
> 
> No maintainer can take patches which apply against linux-next, so not a 
> good dependency to mention either.

It would probably be easiest for me to pick this up into the Tegra tree
since that's where the dt-bindings header file change is that adds these
symbols. Alternatively we could strip the symbols from the example and
use literals instead.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]