From: Catalin Marinas <catalin.marinas@arm.com>
To: Will Deacon <will@kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>,
Robin Murphy <robin.murphy@arm.com>,
Bjorn Andersson <andersson@kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [GIT PULL] arm64 updates for 6.1-rc1
Date: Mon, 14 Nov 2022 14:54:28 +0000 [thread overview]
Message-ID: <Y3JWpCV1LoScdJn1@arm.com> (raw)
In-Reply-To: <20221114140903.GF30263@willie-the-truck>
On Mon, Nov 14, 2022 at 02:09:04PM +0000, Will Deacon wrote:
> On Sat, Nov 12, 2022 at 12:48:20AM +0530, Manivannan Sadhasivam wrote:
> > I digged a little further and found that the crash was due to the secure
> > processor (XPU) violation. It happens because, CPU tried acccessing the memory
> > after sharing it with the modem for firmware metadata validation.
[...]
> > Sibi tried fixing this problem earlier by using a hack in the remoteproc driver
> > [1], but I guess that got negated due to c44094eee32f?
>
> Performing a clean rather than a clean+invalidate when the buffer is
> allocated (which is what is achieved by c44094eee32f) shouldn't affect
> this afaict.
I agree. The DMA_ATTR_NO_KERNEL_MAPPING used in the qcom_q6v5_mss fix
only ensures that there is no non-cacheable DMA mapping but we still
have the kernel linear map in place that may be accessed speculatively
by the CPU at any point. I can't tell why the clean+inval makes any
difference but I suspect it's a matter of time before you'd hit similar
conditions again (maybe not at boot).
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Will Deacon <will@kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>,
Robin Murphy <robin.murphy@arm.com>,
Bjorn Andersson <andersson@kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [GIT PULL] arm64 updates for 6.1-rc1
Date: Mon, 14 Nov 2022 14:54:28 +0000 [thread overview]
Message-ID: <Y3JWpCV1LoScdJn1@arm.com> (raw)
In-Reply-To: <20221114140903.GF30263@willie-the-truck>
On Mon, Nov 14, 2022 at 02:09:04PM +0000, Will Deacon wrote:
> On Sat, Nov 12, 2022 at 12:48:20AM +0530, Manivannan Sadhasivam wrote:
> > I digged a little further and found that the crash was due to the secure
> > processor (XPU) violation. It happens because, CPU tried acccessing the memory
> > after sharing it with the modem for firmware metadata validation.
[...]
> > Sibi tried fixing this problem earlier by using a hack in the remoteproc driver
> > [1], but I guess that got negated due to c44094eee32f?
>
> Performing a clean rather than a clean+invalidate when the buffer is
> allocated (which is what is achieved by c44094eee32f) shouldn't affect
> this afaict.
I agree. The DMA_ATTR_NO_KERNEL_MAPPING used in the qcom_q6v5_mss fix
only ensures that there is no non-cacheable DMA mapping but we still
have the kernel linear map in place that may be accessed speculatively
by the CPU at any point. I can't tell why the clean+inval makes any
difference but I suspect it's a matter of time before you'd hit similar
conditions again (maybe not at boot).
--
Catalin
next prev parent reply other threads:[~2022-11-14 14:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 14:41 [GIT PULL] arm64 updates for 6.1-rc1 Catalin Marinas
2022-10-05 14:41 ` Catalin Marinas
2022-10-06 19:00 ` pr-tracker-bot
2022-10-06 19:00 ` pr-tracker-bot
2022-10-08 14:58 ` Amit Pundir
2022-10-12 11:54 ` Catalin Marinas
2022-10-18 16:05 ` Amit Pundir
2022-10-18 16:05 ` Amit Pundir
2022-10-25 12:38 ` Amit Pundir
2022-10-25 12:38 ` Amit Pundir
2022-11-08 17:28 ` Amit Pundir
2022-11-08 17:28 ` Amit Pundir
2022-11-11 11:15 ` Catalin Marinas
2022-11-11 11:15 ` Catalin Marinas
2022-11-11 11:54 ` Robin Murphy
2022-11-11 11:54 ` Robin Murphy
2022-11-11 17:39 ` Manivannan Sadhasivam
2022-11-11 17:39 ` Manivannan Sadhasivam
2022-11-11 19:18 ` Manivannan Sadhasivam
2022-11-11 19:18 ` Manivannan Sadhasivam
2022-11-14 14:09 ` Will Deacon
2022-11-14 14:09 ` Will Deacon
2022-11-14 14:54 ` Catalin Marinas [this message]
2022-11-14 14:54 ` Catalin Marinas
2022-11-14 18:59 ` [GIT PULL] arm64 updates for 6.1-rc1 #forregzbot Thorsten Leemhuis
2022-11-14 18:59 ` Thorsten Leemhuis
2022-12-07 5:36 ` Thorsten Leemhuis
2022-12-07 5:36 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3JWpCV1LoScdJn1@arm.com \
--to=catalin.marinas@arm.com \
--cc=amit.pundir@linaro.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_sibis@quicinc.com \
--cc=robin.murphy@arm.com \
--cc=torvalds@linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.