From: Mike Snitzer <snitzer@redhat.com>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: axboe@kernel.dk, yi.zhang@huawei.com, snitzer@kernel.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
dm-devel@redhat.com, yukuai3@huawei.com, hch@lst.de,
agk@redhat.com
Subject: Re: [dm-devel] [PATCH v3 04/10] dm: cleanup close_table_device
Date: Wed, 16 Nov 2022 16:46:35 -0500 [thread overview]
Message-ID: <Y3VaO4PQo4rRIRBR@redhat.com> (raw)
In-Reply-To: <20221115141054.1051801-5-yukuai1@huaweicloud.com>
On Tue, Nov 15 2022 at 9:10P -0500,
Yu Kuai <yukuai1@huaweicloud.com> wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> Take the list unlink and free into close_table_device so that no half
> torn down table_devices exist. Also remove the check for a NULL bdev
> as that can't happen - open_table_device never adds a table_device to
> the list that does not have a valid block_device.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Mike Snitzer <snitzer@kernel.org>
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: hch@lst.de, axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org,
dm-devel@redhat.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com
Subject: Re: [PATCH v3 04/10] dm: cleanup close_table_device
Date: Wed, 16 Nov 2022 16:46:35 -0500 [thread overview]
Message-ID: <Y3VaO4PQo4rRIRBR@redhat.com> (raw)
In-Reply-To: <20221115141054.1051801-5-yukuai1@huaweicloud.com>
On Tue, Nov 15 2022 at 9:10P -0500,
Yu Kuai <yukuai1@huaweicloud.com> wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> Take the list unlink and free into close_table_device so that no half
> torn down table_devices exist. Also remove the check for a NULL bdev
> as that can't happen - open_table_device never adds a table_device to
> the list that does not have a valid block_device.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Mike Snitzer <snitzer@kernel.org>
next prev parent reply other threads:[~2022-11-16 21:46 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 14:10 [dm-devel] [PATCH v3 00/10] fix delayed holder tracking Yu Kuai
2022-11-15 14:10 ` Yu Kuai
2022-11-15 14:10 ` [dm-devel] [PATCH v3 01/10] block: clear ->slave_dir when dropping the main slave_dir reference Yu Kuai
2022-11-15 14:10 ` Yu Kuai
2022-11-16 22:10 ` [dm-devel] " Mike Snitzer
2022-11-16 22:10 ` Mike Snitzer
2022-11-15 14:10 ` [dm-devel] [PATCH v3 02/10] dm: remove free_table_devices Yu Kuai
2022-11-15 14:10 ` Yu Kuai
2022-11-16 21:50 ` [dm-devel] " Mike Snitzer
2022-11-16 21:50 ` Mike Snitzer
2022-11-15 14:10 ` [dm-devel] [PATCH v3 03/10] dm: cleanup open_table_device Yu Kuai
2022-11-15 14:10 ` Yu Kuai
2022-11-16 21:19 ` [dm-devel] " Mike Snitzer
2022-11-16 21:19 ` Mike Snitzer
2022-11-15 14:10 ` [dm-devel] [PATCH v3 04/10] dm: cleanup close_table_device Yu Kuai
2022-11-15 14:10 ` Yu Kuai
2022-11-16 21:46 ` Mike Snitzer [this message]
2022-11-16 21:46 ` Mike Snitzer
2022-11-15 14:10 ` [dm-devel] [PATCH RFC v3 05/10] dm: make sure create and remove dm device won't race with open and close table Yu Kuai
2022-11-15 14:10 ` Yu Kuai
2022-11-16 6:35 ` [dm-devel] " Christoph Hellwig
2022-11-16 6:35 ` Christoph Hellwig
2022-11-16 21:48 ` [dm-devel] " Mike Snitzer
2022-11-16 21:48 ` Mike Snitzer
2022-11-15 14:10 ` [dm-devel] [PATCH v3 06/10] dm: track per-add_disk holder relations in DM Yu Kuai
2022-11-15 14:10 ` Yu Kuai
2022-11-16 21:49 ` [dm-devel] " Mike Snitzer
2022-11-16 21:49 ` Mike Snitzer
2022-11-15 14:10 ` [dm-devel] [PATCH v3 07/10] block: remove delayed holder registration Yu Kuai
2022-11-15 14:10 ` Yu Kuai
2022-11-15 14:10 ` [dm-devel] [PATCH v3 08/10] block: fix use after free for bd_holder_dir Yu Kuai
2022-11-15 14:10 ` Yu Kuai
2022-11-16 6:35 ` [dm-devel] " Christoph Hellwig
2022-11-16 6:35 ` Christoph Hellwig
2022-11-15 14:10 ` [dm-devel] [PATCH v3 09/10] block: store the holder kobject in bd_holder_disk Yu Kuai
2022-11-15 14:10 ` Yu Kuai
2022-11-16 6:36 ` [dm-devel] " Christoph Hellwig
2022-11-16 6:36 ` Christoph Hellwig
2022-11-15 14:10 ` [dm-devel] [PATCH v3 10/10] block: don't allow a disk link holder to itself Yu Kuai
2022-11-15 14:10 ` Yu Kuai
2022-11-16 6:36 ` [dm-devel] " Christoph Hellwig
2022-11-16 6:36 ` Christoph Hellwig
2022-11-16 22:20 ` [dm-devel] [PATCH v3 00/10] fix delayed holder tracking Jens Axboe
2022-11-16 22:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3VaO4PQo4rRIRBR@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.