All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1] kselftest/arm64: Use preferred form for predicate load/stores
Date: Thu, 17 Nov 2022 12:52:46 +0000	[thread overview]
Message-ID: <Y3YuniIBdSa02hUr@sirena.org.uk> (raw)
In-Reply-To: <Y3YgdloFYx3pQUO0@FVFF77S0Q05N>

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

On Thu, Nov 17, 2022 at 11:52:22AM +0000, Mark Rutland wrote:
> On Thu, Nov 17, 2022 at 11:41:30AM +0000, Mark Brown wrote:

> > The preferred form of the str/ldr for predicate registers with an immediate
> > of zero is to omit the zero, and the clang built in assembler rejects the
> > zero immediate. Drop the immediate.

> Rejecting that outright seems like a bug in clang, given there are legitimate
> reasons to write code that way (e.g. using asm-offsets style definitions); has
> that been reported so that it can be fixed?

I believe it's been reported, yes.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1] kselftest/arm64: Use preferred form for predicate load/stores
Date: Thu, 17 Nov 2022 12:52:46 +0000	[thread overview]
Message-ID: <Y3YuniIBdSa02hUr@sirena.org.uk> (raw)
In-Reply-To: <Y3YgdloFYx3pQUO0@FVFF77S0Q05N>


[-- Attachment #1.1: Type: text/plain, Size: 567 bytes --]

On Thu, Nov 17, 2022 at 11:52:22AM +0000, Mark Rutland wrote:
> On Thu, Nov 17, 2022 at 11:41:30AM +0000, Mark Brown wrote:

> > The preferred form of the str/ldr for predicate registers with an immediate
> > of zero is to omit the zero, and the clang built in assembler rejects the
> > zero immediate. Drop the immediate.

> Rejecting that outright seems like a bug in clang, given there are legitimate
> reasons to write code that way (e.g. using asm-offsets style definitions); has
> that been reported so that it can be fixed?

I believe it's been reported, yes.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-11-17 12:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 11:41 [PATCH v1] kselftest/arm64: Use preferred form for predicate load/stores Mark Brown
2022-11-17 11:41 ` Mark Brown
2022-11-17 11:52 ` Mark Rutland
2022-11-17 11:52   ` Mark Rutland
2022-11-17 12:52   ` Mark Brown [this message]
2022-11-17 12:52     ` Mark Brown
2022-11-18 19:40 ` Will Deacon
2022-11-18 19:40   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3YuniIBdSa02hUr@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=shuah@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.