[PATCH 0/2] change to use ACPI_FREE() to free the ACPI memory

[PATCH 0/2] change to use ACPI_FREE() to free the ACPI memory

[Wang ShaoBo]

acpi_evaluate_dsm_typed()/acpi_evaluate_dsm() should be coupled with
ACPI_FREE() to free the ACPI memory, because we need to track the
allocation of acpi_object when ACPI_DBG_TRACK_ALLOCATIONS enabled,
so use ACPI_FREE() instead of kfree().

Wang ShaoBo (2):
  ACPI: pfr_telemetry: use ACPI_FREE() to free acpi_object
  ACPI: pfr_update: use ACPI_FREE() to free acpi_object

 drivers/acpi/pfr_telemetry.c | 6 +++---
 drivers/acpi/pfr_update.c    | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

-- 
2.25.1

[PATCH 1/2] ACPI: pfr_telemetry: use ACPI_FREE() to free acpi_object

[Wang ShaoBo]

acpi_evaluate_dsm_typed()/acpi_evaluate_dsm() should be coupled
with ACPI_FREE() to free the ACPI memory, because we need to
track the allocation of acpi_object when ACPI_DBG_TRACK_ALLOCATIONS
enabled, so use ACPI_FREE() instead of kfree().

Fixes: b0013e037a8b ("ACPI: Introduce Platform Firmware Runtime Telemetry driver")
Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
---
 drivers/acpi/pfr_telemetry.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/pfr_telemetry.c b/drivers/acpi/pfr_telemetry.c
index 9abf350bd7a5..27fb6cdad75f 100644
--- a/drivers/acpi/pfr_telemetry.c
+++ b/drivers/acpi/pfr_telemetry.c
@@ -144,7 +144,7 @@ static int get_pfrt_log_data_info(struct pfrt_log_data_info *data_info,
 	ret = 0;
 
 free_acpi_buffer:
-	kfree(out_obj);
+	ACPI_FREE(out_obj);
 
 	return ret;
 }
@@ -180,7 +180,7 @@ static int set_pfrt_log_level(int level, struct pfrt_log_device *pfrt_log_dev)
 		ret = -EBUSY;
 	}
 
-	kfree(out_obj);
+	ACPI_FREE(out_obj);
 
 	return ret;
 }
@@ -218,7 +218,7 @@ static int get_pfrt_log_level(struct pfrt_log_device *pfrt_log_dev)
 	ret = obj->integer.value;
 
 free_acpi_buffer:
-	kfree(out_obj);
+	ACPI_FREE(out_obj);
 
 	return ret;
 }
-- 
2.25.1

Re: [PATCH 1/2] ACPI: pfr_telemetry: use ACPI_FREE() to free acpi_object

[Chen Yu]

On 2022-11-18 at 14:32:18 +0800, Wang ShaoBo wrote:
> acpi_evaluate_dsm_typed()/acpi_evaluate_dsm() should be coupled
> with ACPI_FREE() to free the ACPI memory, because we need to
> track the allocation of acpi_object when ACPI_DBG_TRACK_ALLOCATIONS
> enabled, so use ACPI_FREE() instead of kfree().
> 
> Fixes: b0013e037a8b ("ACPI: Introduce Platform Firmware Runtime Telemetry driver")
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
Reviewed-by: Chen Yu <yu.c.chen@intel.com>

thanks,
Chenyu

[PATCH 2/2] ACPI: pfr_update: use ACPI_FREE() to free acpi_object

[Wang ShaoBo]

acpi_evaluate_dsm_typed()/acpi_evaluate_dsm() should be coupled with
ACPI_FREE() to free the ACPI memory, because we need to track the
allocation of acpi_object when ACPI_DBG_TRACK_ALLOCATIONS enabled,
so use ACPI_FREE() instead of kfree().

Fixes: 0db89fa243e5 ("ACPI: Introduce Platform Firmware Runtime Update device driver")
Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
---
 drivers/acpi/pfr_update.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/pfr_update.c b/drivers/acpi/pfr_update.c
index 6bb0b778b5da..9d2bdc13253a 100644
--- a/drivers/acpi/pfr_update.c
+++ b/drivers/acpi/pfr_update.c
@@ -178,7 +178,7 @@ static int query_capability(struct pfru_update_cap_info *cap_hdr,
 	ret = 0;
 
 free_acpi_buffer:
-	kfree(out_obj);
+	ACPI_FREE(out_obj);
 
 	return ret;
 }
@@ -224,7 +224,7 @@ static int query_buffer(struct pfru_com_buf_info *info,
 	ret = 0;
 
 free_acpi_buffer:
-	kfree(out_obj);
+	ACPI_FREE(out_obj);
 
 	return ret;
 }
@@ -385,7 +385,7 @@ static int start_update(int action, struct pfru_device *pfru_dev)
 	ret = 0;
 
 free_acpi_buffer:
-	kfree(out_obj);
+	ACPI_FREE(out_obj);
 
 	return ret;
 }
-- 
2.25.1

Re: [PATCH 2/2] ACPI: pfr_update: use ACPI_FREE() to free acpi_object

[Chen Yu]

On 2022-11-18 at 14:32:19 +0800, Wang ShaoBo wrote:
> acpi_evaluate_dsm_typed()/acpi_evaluate_dsm() should be coupled with
> ACPI_FREE() to free the ACPI memory, because we need to track the
> allocation of acpi_object when ACPI_DBG_TRACK_ALLOCATIONS enabled,
> so use ACPI_FREE() instead of kfree().
> 
> Fixes: 0db89fa243e5 ("ACPI: Introduce Platform Firmware Runtime Update device driver")
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
Reviewed-by: Chen Yu <yu.c.chen@intel.com>

thanks,
Chenyu

Re: [PATCH 0/2] change to use ACPI_FREE() to free the ACPI memory

[Rafael J. Wysocki]

On Fri, Nov 18, 2022 at 7:33 AM Wang ShaoBo <bobo.shaobowang@huawei.com> wrote:
>
> acpi_evaluate_dsm_typed()/acpi_evaluate_dsm() should be coupled with
> ACPI_FREE() to free the ACPI memory, because we need to track the
> allocation of acpi_object when ACPI_DBG_TRACK_ALLOCATIONS enabled,
> so use ACPI_FREE() instead of kfree().
>
> Wang ShaoBo (2):
>   ACPI: pfr_telemetry: use ACPI_FREE() to free acpi_object
>   ACPI: pfr_update: use ACPI_FREE() to free acpi_object
>
>  drivers/acpi/pfr_telemetry.c | 6 +++---
>  drivers/acpi/pfr_update.c    | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> --

Both applied as 6.2 material, thanks!