From: Dan Carpenter <error27@gmail.com>
To: biju.das.jz@bp.renesas.com
Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org
Subject: [bug report] drm: rcar-du: Add RZ/G2L DSI driver
Date: Fri, 18 Nov 2022 18:01:04 +0300 [thread overview]
Message-ID: <Y3eeMGDxaLcRxu69@kili> (raw)
Hello Biju Das,
The patch 7a043f978ed1: "drm: rcar-du: Add RZ/G2L DSI driver" from
Sep 20, 2022, leads to the following Smatch static checker warning:
drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c:372 rzg2l_mipi_dsi_set_display_timing()
warn: uninitialized special assign 'vich1ppsetr |= (1 << 15)'
drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c
347 static void rzg2l_mipi_dsi_set_display_timing(struct rzg2l_mipi_dsi *dsi,
348 const struct drm_display_mode *mode)
349 {
350 u32 vich1ppsetr;
351 u32 vich1vssetr;
352 u32 vich1vpsetr;
353 u32 vich1hssetr;
354 u32 vich1hpsetr;
355 int dsi_format;
356 u32 delay[2];
357 u8 index;
358
359 /* Configuration for Pixel Packet */
360 dsi_format = mipi_dsi_pixel_format_to_bpp(dsi->format);
361 switch (dsi_format) {
362 case 24:
363 vich1ppsetr = VICH1PPSETR_DT_RGB24;
364 break;
365 case 18:
366 vich1ppsetr = VICH1PPSETR_DT_RGB18;
367 break;
What if mipi_dsi_pixel_format_to_bpp() returns 16?
368 }
369
370 if ((dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) &&
371 !(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST))
--> 372 vich1ppsetr |= VICH1PPSETR_TXESYNC_PULSE;
^^^^^^^^^^^
Uninitialized.
373
374 rzg2l_mipi_dsi_link_write(dsi, VICH1PPSETR, vich1ppsetr);
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: biju.das.jz@bp.renesas.com
Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [bug report] drm: rcar-du: Add RZ/G2L DSI driver
Date: Fri, 18 Nov 2022 18:01:04 +0300 [thread overview]
Message-ID: <Y3eeMGDxaLcRxu69@kili> (raw)
Hello Biju Das,
The patch 7a043f978ed1: "drm: rcar-du: Add RZ/G2L DSI driver" from
Sep 20, 2022, leads to the following Smatch static checker warning:
drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c:372 rzg2l_mipi_dsi_set_display_timing()
warn: uninitialized special assign 'vich1ppsetr |= (1 << 15)'
drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c
347 static void rzg2l_mipi_dsi_set_display_timing(struct rzg2l_mipi_dsi *dsi,
348 const struct drm_display_mode *mode)
349 {
350 u32 vich1ppsetr;
351 u32 vich1vssetr;
352 u32 vich1vpsetr;
353 u32 vich1hssetr;
354 u32 vich1hpsetr;
355 int dsi_format;
356 u32 delay[2];
357 u8 index;
358
359 /* Configuration for Pixel Packet */
360 dsi_format = mipi_dsi_pixel_format_to_bpp(dsi->format);
361 switch (dsi_format) {
362 case 24:
363 vich1ppsetr = VICH1PPSETR_DT_RGB24;
364 break;
365 case 18:
366 vich1ppsetr = VICH1PPSETR_DT_RGB18;
367 break;
What if mipi_dsi_pixel_format_to_bpp() returns 16?
368 }
369
370 if ((dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) &&
371 !(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST))
--> 372 vich1ppsetr |= VICH1PPSETR_TXESYNC_PULSE;
^^^^^^^^^^^
Uninitialized.
373
374 rzg2l_mipi_dsi_link_write(dsi, VICH1PPSETR, vich1ppsetr);
regards,
dan carpenter
next reply other threads:[~2022-11-18 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 15:01 Dan Carpenter [this message]
2022-11-18 15:01 ` [bug report] drm: rcar-du: Add RZ/G2L DSI driver Dan Carpenter
2022-11-18 15:20 ` Biju Das
2022-11-18 15:20 ` Biju Das
-- strict thread matches above, loose matches on Subject: below --
2023-06-15 6:14 Dan Carpenter
2023-06-15 6:22 ` Biju Das
2023-06-15 12:37 ` Laurent Pinchart
2023-06-15 14:10 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3eeMGDxaLcRxu69@kili \
--to=error27@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.