From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Pavel Machek <pavel@ucw.cz>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Pali Rohar <pali@kernel.org>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v2] media: i2c: ad5820: Fix error path
Date: Mon, 5 Dec 2022 09:58:45 +0000 [thread overview]
Message-ID: <Y43A1WbaLSa042EJ@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20220921-ad5820-v2-0-3e5cabb04786@chromium.org>
Hi Ricardo,
On Fri, Dec 02, 2022 at 05:35:59PM +0100, Ricardo Ribalda wrote:
> Error path seems to be swaped. Fix the order and provide some meaningful
> names.
>
> Fixes: bee3d5115611 ("[media] ad5820: Add driver for auto-focus coil")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
I'm afraid v1 has already been merged. But I understand patch content
wasn't really different so that should be fine.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2022-12-05 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 16:35 [PATCH v2] media: i2c: ad5820: Fix error path Ricardo Ribalda
2022-12-05 9:58 ` Sakari Ailus [this message]
2022-12-05 9:59 ` Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y43A1WbaLSa042EJ@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pali@kernel.org \
--cc=pavel@ucw.cz \
--cc=ribalda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.