From: Ido Schimmel <idosch@nvidia.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
edumazet@google.com, mlxsw@nvidia.com, roopa@nvidia.com,
kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next 1/8] bridge: mcast: Centralize netlink attribute parsing
Date: Tue, 6 Dec 2022 11:53:03 +0200 [thread overview]
Message-ID: <Y48Q/xoACOyFaozp@shredder> (raw)
In-Reply-To: <06490c08-bf5e-1714-f56c-1a6068fb2ec9@blackwall.org>
On Mon, Dec 05, 2022 at 01:34:08PM +0200, Nikolay Aleksandrov wrote:
> I just noticed the skb argument is unused. Does it get used in a future change?
Nope :)
> Also a minor nit - I think nlh can be a const, nlmsg_parse_deprecated already uses a const nlh.
Removed the 'skb' argument and marked 'nlh' as 'const'.
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@nvidia.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, roopa@nvidia.com, mlxsw@nvidia.com
Subject: Re: [PATCH net-next 1/8] bridge: mcast: Centralize netlink attribute parsing
Date: Tue, 6 Dec 2022 11:53:03 +0200 [thread overview]
Message-ID: <Y48Q/xoACOyFaozp@shredder> (raw)
In-Reply-To: <06490c08-bf5e-1714-f56c-1a6068fb2ec9@blackwall.org>
On Mon, Dec 05, 2022 at 01:34:08PM +0200, Nikolay Aleksandrov wrote:
> I just noticed the skb argument is unused. Does it get used in a future change?
Nope :)
> Also a minor nit - I think nlh can be a const, nlmsg_parse_deprecated already uses a const nlh.
Removed the 'skb' argument and marked 'nlh' as 'const'.
Thanks!
next prev parent reply other threads:[~2022-12-06 9:53 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 7:42 [Bridge] [PATCH net-next 0/8] bridge: mcast: Preparations for EVPN extensions Ido Schimmel
2022-12-05 7:42 ` Ido Schimmel
2022-12-05 7:42 ` [Bridge] [PATCH net-next 1/8] bridge: mcast: Centralize netlink attribute parsing Ido Schimmel
2022-12-05 7:42 ` Ido Schimmel
2022-12-05 11:34 ` [Bridge] " Nikolay Aleksandrov
2022-12-05 11:34 ` Nikolay Aleksandrov
2022-12-06 9:53 ` Ido Schimmel [this message]
2022-12-06 9:53 ` Ido Schimmel
2022-12-05 7:42 ` [Bridge] [PATCH net-next 2/8] bridge: mcast: Remove redundant checks Ido Schimmel
2022-12-05 7:42 ` Ido Schimmel
2022-12-05 11:34 ` [Bridge] " Nikolay Aleksandrov
2022-12-05 11:34 ` Nikolay Aleksandrov
2022-12-05 7:42 ` [Bridge] [PATCH net-next 3/8] bridge: mcast: Use MDB configuration structure where possible Ido Schimmel
2022-12-05 7:42 ` Ido Schimmel
2022-12-05 11:35 ` [Bridge] " Nikolay Aleksandrov
2022-12-05 11:35 ` Nikolay Aleksandrov
2022-12-05 7:42 ` [Bridge] [PATCH net-next 4/8] bridge: mcast: Propagate MDB configuration structure further Ido Schimmel
2022-12-05 7:42 ` Ido Schimmel
2022-12-05 11:40 ` [Bridge] " Nikolay Aleksandrov
2022-12-05 11:40 ` Nikolay Aleksandrov
2022-12-05 7:42 ` [Bridge] [PATCH net-next 5/8] bridge: mcast: Use MDB group key from configuration structure Ido Schimmel
2022-12-05 7:42 ` Ido Schimmel
2022-12-05 11:41 ` [Bridge] " Nikolay Aleksandrov
2022-12-05 11:41 ` Nikolay Aleksandrov
2022-12-05 7:42 ` [Bridge] [PATCH net-next 6/8] bridge: mcast: Remove br_mdb_parse() Ido Schimmel
2022-12-05 7:42 ` Ido Schimmel
2022-12-05 11:42 ` [Bridge] " Nikolay Aleksandrov
2022-12-05 11:42 ` Nikolay Aleksandrov
2022-12-05 7:42 ` [Bridge] [PATCH net-next 7/8] bridge: mcast: Move checks out of critical section Ido Schimmel
2022-12-05 7:42 ` Ido Schimmel
2022-12-05 11:43 ` [Bridge] " Nikolay Aleksandrov
2022-12-05 11:43 ` Nikolay Aleksandrov
2022-12-05 7:42 ` [Bridge] [PATCH net-next 8/8] bridge: mcast: Remove redundant function arguments Ido Schimmel
2022-12-05 7:42 ` Ido Schimmel
2022-12-05 11:43 ` [Bridge] " Nikolay Aleksandrov
2022-12-05 11:43 ` Nikolay Aleksandrov
2022-12-05 11:55 ` [Bridge] [PATCH net-next 0/8] bridge: mcast: Preparations for EVPN extensions Nikolay Aleksandrov
2022-12-05 11:55 ` Nikolay Aleksandrov
2022-12-06 9:58 ` [Bridge] " Ido Schimmel
2022-12-06 9:58 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y48Q/xoACOyFaozp@shredder \
--to=idosch@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.