From: Stefan Hajnoczi <stefanha@redhat.com>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-scsi@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
linux-nvme@lists.infradead.org,
virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [dm-devel] [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support
Date: Tue, 6 Dec 2022 11:31:44 -0500 [thread overview]
Message-ID: <Y49ucLGtCOtnbM0K@fedora> (raw)
In-Reply-To: <20221205162035.2261037-1-alvaro.karsz@solid-run.com>
[-- Attachment #1.1: Type: text/plain, Size: 862 bytes --]
On Mon, Dec 05, 2022 at 06:20:34PM +0200, Alvaro Karsz wrote:
I don't like that the ioctl lifetime struct is passed through
little-endian from the device to userspace. The point of this new ioctl
is not to be a passthrough interface. The kernel should define a proper
UABI struct for the ioctl and handle endianness conversion. But I think
Michael is happy with this approach, so nevermind.
> @@ -219,4 +247,8 @@ struct virtio_scsi_inhdr {
> #define VIRTIO_BLK_S_OK 0
> #define VIRTIO_BLK_S_IOERR 1
> #define VIRTIO_BLK_S_UNSUPP 2
> +
> +/* Virtblk ioctl commands */
> +#define VBLK_GET_LIFETIME _IOR('r', 0, struct virtio_blk_lifetime)
Does something include <linux/ioctl.h> for _IOR()? Failure to include
the necessary header file could break userspace applications that
include <linux/virtio_blk.h>.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 98 bytes --]
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, dm-devel@redhat.com,
linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support
Date: Tue, 6 Dec 2022 11:31:44 -0500 [thread overview]
Message-ID: <Y49ucLGtCOtnbM0K@fedora> (raw)
In-Reply-To: <20221205162035.2261037-1-alvaro.karsz@solid-run.com>
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
On Mon, Dec 05, 2022 at 06:20:34PM +0200, Alvaro Karsz wrote:
I don't like that the ioctl lifetime struct is passed through
little-endian from the device to userspace. The point of this new ioctl
is not to be a passthrough interface. The kernel should define a proper
UABI struct for the ioctl and handle endianness conversion. But I think
Michael is happy with this approach, so nevermind.
> @@ -219,4 +247,8 @@ struct virtio_scsi_inhdr {
> #define VIRTIO_BLK_S_OK 0
> #define VIRTIO_BLK_S_IOERR 1
> #define VIRTIO_BLK_S_UNSUPP 2
> +
> +/* Virtblk ioctl commands */
> +#define VBLK_GET_LIFETIME _IOR('r', 0, struct virtio_blk_lifetime)
Does something include <linux/ioctl.h> for _IOR()? Failure to include
the necessary header file could break userspace applications that
include <linux/virtio_blk.h>.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-scsi@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
linux-nvme@lists.infradead.org,
virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support
Date: Tue, 6 Dec 2022 11:31:44 -0500 [thread overview]
Message-ID: <Y49ucLGtCOtnbM0K@fedora> (raw)
In-Reply-To: <20221205162035.2261037-1-alvaro.karsz@solid-run.com>
[-- Attachment #1.1: Type: text/plain, Size: 862 bytes --]
On Mon, Dec 05, 2022 at 06:20:34PM +0200, Alvaro Karsz wrote:
I don't like that the ioctl lifetime struct is passed through
little-endian from the device to userspace. The point of this new ioctl
is not to be a passthrough interface. The kernel should define a proper
UABI struct for the ioctl and handle endianness conversion. But I think
Michael is happy with this approach, so nevermind.
> @@ -219,4 +247,8 @@ struct virtio_scsi_inhdr {
> #define VIRTIO_BLK_S_OK 0
> #define VIRTIO_BLK_S_IOERR 1
> #define VIRTIO_BLK_S_UNSUPP 2
> +
> +/* Virtblk ioctl commands */
> +#define VBLK_GET_LIFETIME _IOR('r', 0, struct virtio_blk_lifetime)
Does something include <linux/ioctl.h> for _IOR()? Failure to include
the necessary header file could break userspace applications that
include <linux/virtio_blk.h>.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-12-07 13:37 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 16:20 [dm-devel] [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support Alvaro Karsz
2022-12-05 16:20 ` Alvaro Karsz
2022-12-05 16:20 ` Alvaro Karsz
2022-12-05 18:24 ` [dm-devel] " Jens Axboe
2022-12-05 18:24 ` Jens Axboe
2022-12-05 18:24 ` Jens Axboe
2022-12-05 18:36 ` [dm-devel] " Alvaro Karsz
2022-12-05 18:36 ` Alvaro Karsz
2022-12-05 18:36 ` Alvaro Karsz
2022-12-05 18:53 ` [dm-devel] " Jens Axboe
2022-12-05 18:53 ` Jens Axboe
2022-12-05 18:53 ` Jens Axboe
2022-12-05 20:29 ` [dm-devel] " Michael S. Tsirkin
2022-12-05 20:29 ` Michael S. Tsirkin
2022-12-05 20:29 ` Michael S. Tsirkin
2022-12-05 20:35 ` [dm-devel] " Enrico Granata
2022-12-05 20:35 ` Enrico Granata
2022-12-05 23:09 ` [dm-devel] " Chaitanya Kulkarni
2022-12-05 23:09 ` Chaitanya Kulkarni
2022-12-05 20:36 ` [dm-devel] " Jens Axboe
2022-12-05 20:36 ` Jens Axboe
2022-12-05 20:36 ` Jens Axboe
2022-12-05 22:28 ` [dm-devel] " Chaitanya Kulkarni
2022-12-05 22:28 ` Chaitanya Kulkarni
2022-12-05 18:25 ` [dm-devel] " Jens Axboe
2022-12-05 18:25 ` Jens Axboe
2022-12-05 18:25 ` Jens Axboe
2022-12-06 16:31 ` Stefan Hajnoczi [this message]
2022-12-06 16:31 ` Stefan Hajnoczi
2022-12-06 16:31 ` Stefan Hajnoczi
2022-12-06 16:40 ` [dm-devel] " Michael S. Tsirkin
2022-12-06 16:40 ` Michael S. Tsirkin
2022-12-06 16:40 ` Michael S. Tsirkin
2022-12-06 18:25 ` [dm-devel] " Alvaro Karsz
2022-12-06 18:25 ` Alvaro Karsz
2022-12-06 18:25 ` Alvaro Karsz
2022-12-06 18:43 ` [dm-devel] " Bart Van Assche
2022-12-06 18:43 ` Bart Van Assche
2022-12-06 18:43 ` Bart Van Assche
2022-12-06 19:56 ` [dm-devel] " Alvaro Karsz
2022-12-06 19:56 ` Alvaro Karsz
2022-12-06 19:56 ` Alvaro Karsz
2022-12-07 3:32 ` [dm-devel] " Chaitanya Kulkarni
2022-12-07 3:32 ` Chaitanya Kulkarni
2022-12-07 7:35 ` [dm-devel] " Christoph Hellwig
2022-12-07 7:35 ` Christoph Hellwig
2022-12-07 7:35 ` Christoph Hellwig
2022-12-07 10:21 ` [dm-devel] " Michael S. Tsirkin
2022-12-07 10:21 ` Michael S. Tsirkin
2022-12-07 10:21 ` Michael S. Tsirkin
2022-12-07 16:31 ` [dm-devel] " Christoph Hellwig
2022-12-07 16:31 ` Christoph Hellwig
2022-12-07 16:31 ` Christoph Hellwig
2022-12-07 20:28 ` [dm-devel] " Michael S. Tsirkin
2022-12-07 20:28 ` Michael S. Tsirkin
2022-12-07 20:28 ` Michael S. Tsirkin
2022-12-11 9:49 ` [dm-devel] " Alvaro Karsz
2022-12-11 9:49 ` Alvaro Karsz
2022-12-11 9:49 ` Alvaro Karsz
2022-12-13 4:59 ` [dm-devel] " Chaitanya Kulkarni
2022-12-13 4:59 ` Chaitanya Kulkarni
2022-12-13 4:58 ` [dm-devel] " Chaitanya Kulkarni
2022-12-13 4:58 ` Chaitanya Kulkarni
2022-12-13 6:23 ` [dm-devel] " Michael S. Tsirkin
2022-12-13 6:23 ` Michael S. Tsirkin
2022-12-13 6:23 ` Michael S. Tsirkin
2022-12-19 7:59 ` [dm-devel] " Michael S. Tsirkin
2022-12-19 7:59 ` Michael S. Tsirkin
2022-12-19 7:59 ` Michael S. Tsirkin
2022-12-19 8:39 ` [dm-devel] " Alvaro Karsz
2022-12-19 8:39 ` Alvaro Karsz
2022-12-19 8:39 ` Alvaro Karsz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y49ucLGtCOtnbM0K@fedora \
--to=stefanha@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.