* [PATCH] platform: andes/ae350: Avoid repeated inclusion of header files
@ 2022-11-16 7:27 zhangleizheng
2022-11-16 8:47 ` Bin Meng
2022-11-28 8:20 ` Yu-Chien Peter Lin
0 siblings, 2 replies; 4+ messages in thread
From: zhangleizheng @ 2022-11-16 7:27 UTC (permalink / raw)
To: opensbi
From: zhangleizheng <zhangleizheng@eswincomputing.com>
Avoid cache.h reuse when compiling.
Signed-off-by: zhangleizheng <zhangleizheng@eswincomputing.com>
---
platform/andes/ae350/cache.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/platform/andes/ae350/cache.h b/platform/andes/ae350/cache.h
index e1c1826..8e00a1d 100644
--- a/platform/andes/ae350/cache.h
+++ b/platform/andes/ae350/cache.h
@@ -7,6 +7,9 @@
* Nylon Chen <nylon7@andestech.com>
*/
+#ifndef _AE350_CACHE_H_
+#define _AE350_CACHE_H_
+
uintptr_t mcall_set_mcache_ctl(unsigned long input);
uintptr_t mcall_set_mmisc_ctl(unsigned long input);
uintptr_t mcall_icache_op(unsigned int enable);
@@ -15,3 +18,5 @@ uintptr_t mcall_l1_cache_i_prefetch_op(unsigned long enable);
uintptr_t mcall_l1_cache_d_prefetch_op(unsigned long enable);
uintptr_t mcall_non_blocking_load_store(unsigned long enable);
uintptr_t mcall_write_around(unsigned long enable);
+
+#endif /* _AE350_CACHE_H_ */
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] platform: andes/ae350: Avoid repeated inclusion of header files
2022-11-16 7:27 [PATCH] platform: andes/ae350: Avoid repeated inclusion of header files zhangleizheng
@ 2022-11-16 8:47 ` Bin Meng
2022-11-28 8:20 ` Yu-Chien Peter Lin
1 sibling, 0 replies; 4+ messages in thread
From: Bin Meng @ 2022-11-16 8:47 UTC (permalink / raw)
To: opensbi
On Wed, Nov 16, 2022 at 3:29 PM <zhangleizheng@eswincomputing.com> wrote:
>
> From: zhangleizheng <zhangleizheng@eswincomputing.com>
>
> Avoid cache.h reuse when compiling.
>
> Signed-off-by: zhangleizheng <zhangleizheng@eswincomputing.com>
nits: use "First Name" "Last Name" as the git.user.name
> ---
> platform/andes/ae350/cache.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/platform/andes/ae350/cache.h b/platform/andes/ae350/cache.h
> index e1c1826..8e00a1d 100644
> --- a/platform/andes/ae350/cache.h
> +++ b/platform/andes/ae350/cache.h
> @@ -7,6 +7,9 @@
> * Nylon Chen <nylon7@andestech.com>
> */
>
> +#ifndef _AE350_CACHE_H_
> +#define _AE350_CACHE_H_
> +
> uintptr_t mcall_set_mcache_ctl(unsigned long input);
> uintptr_t mcall_set_mmisc_ctl(unsigned long input);
> uintptr_t mcall_icache_op(unsigned int enable);
> @@ -15,3 +18,5 @@ uintptr_t mcall_l1_cache_i_prefetch_op(unsigned long enable);
> uintptr_t mcall_l1_cache_d_prefetch_op(unsigned long enable);
> uintptr_t mcall_non_blocking_load_store(unsigned long enable);
> uintptr_t mcall_write_around(unsigned long enable);
> +
> +#endif /* _AE350_CACHE_H_ */
> --
Otherwise,
Reviewed-by: Bin Meng <bmeng@tinylab.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] platform: andes/ae350: Avoid repeated inclusion of header files
2022-11-16 7:27 [PATCH] platform: andes/ae350: Avoid repeated inclusion of header files zhangleizheng
2022-11-16 8:47 ` Bin Meng
@ 2022-11-28 8:20 ` Yu-Chien Peter Lin
2022-11-28 16:37 ` Yu-Chien Peter Lin
1 sibling, 1 reply; 4+ messages in thread
From: Yu-Chien Peter Lin @ 2022-11-28 8:20 UTC (permalink / raw)
To: opensbi
On Wed, Nov 16, 2022 at 03:27:16PM +0800, zhangleizheng at eswincomputing.com wrote:
> From: zhangleizheng <zhangleizheng@eswincomputing.com>
>
> Avoid cache.h reuse when compiling.
>
> Signed-off-by: zhangleizheng <zhangleizheng@eswincomputing.com>
Looks good to me,
Thanks.
Reviewed-by: Yu Chien Peter Lin <peterlin@andestech.com>
> ---
> platform/andes/ae350/cache.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/platform/andes/ae350/cache.h b/platform/andes/ae350/cache.h
> index e1c1826..8e00a1d 100644
> --- a/platform/andes/ae350/cache.h
> +++ b/platform/andes/ae350/cache.h
> @@ -7,6 +7,9 @@
> * Nylon Chen <nylon7@andestech.com>
> */
>
> +#ifndef _AE350_CACHE_H_
> +#define _AE350_CACHE_H_
> +
> uintptr_t mcall_set_mcache_ctl(unsigned long input);
> uintptr_t mcall_set_mmisc_ctl(unsigned long input);
> uintptr_t mcall_icache_op(unsigned int enable);
> @@ -15,3 +18,5 @@ uintptr_t mcall_l1_cache_i_prefetch_op(unsigned long enable);
> uintptr_t mcall_l1_cache_d_prefetch_op(unsigned long enable);
> uintptr_t mcall_non_blocking_load_store(unsigned long enable);
> uintptr_t mcall_write_around(unsigned long enable);
> +
> +#endif /* _AE350_CACHE_H_ */
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] platform: andes/ae350: Avoid repeated inclusion of header files
2022-11-28 8:20 ` Yu-Chien Peter Lin
@ 2022-11-28 16:37 ` Yu-Chien Peter Lin
0 siblings, 0 replies; 4+ messages in thread
From: Yu-Chien Peter Lin @ 2022-11-28 16:37 UTC (permalink / raw)
To: opensbi
On Mon, Nov 28, 2022 at 08:20:24AM +0000, Yu-Chien Peter Lin wrote:
> On Wed, Nov 16, 2022 at 03:27:16PM +0800, zhangleizheng at eswincomputing.com wrote:
> > From: zhangleizheng <zhangleizheng@eswincomputing.com>
> >
> > Avoid cache.h reuse when compiling.
> >
> > Signed-off-by: zhangleizheng <zhangleizheng@eswincomputing.com>
>
> Looks good to me,
> Thanks.
>
> Reviewed-by: Yu Chien Peter Lin <peterlin@andestech.com>
Hi all,
I just removed andes/ae350 folder so let's skip this patch.
Thanks for your fix.
Best regards,
Peter Lin
>
> > ---
> > platform/andes/ae350/cache.h | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/platform/andes/ae350/cache.h b/platform/andes/ae350/cache.h
> > index e1c1826..8e00a1d 100644
> > --- a/platform/andes/ae350/cache.h
> > +++ b/platform/andes/ae350/cache.h
> > @@ -7,6 +7,9 @@
> > * Nylon Chen <nylon7@andestech.com>
> > */
> >
> > +#ifndef _AE350_CACHE_H_
> > +#define _AE350_CACHE_H_
> > +
> > uintptr_t mcall_set_mcache_ctl(unsigned long input);
> > uintptr_t mcall_set_mmisc_ctl(unsigned long input);
> > uintptr_t mcall_icache_op(unsigned int enable);
> > @@ -15,3 +18,5 @@ uintptr_t mcall_l1_cache_i_prefetch_op(unsigned long enable);
> > uintptr_t mcall_l1_cache_d_prefetch_op(unsigned long enable);
> > uintptr_t mcall_non_blocking_load_store(unsigned long enable);
> > uintptr_t mcall_write_around(unsigned long enable);
> > +
> > +#endif /* _AE350_CACHE_H_ */
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-28 16:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-16 7:27 [PATCH] platform: andes/ae350: Avoid repeated inclusion of header files zhangleizheng
2022-11-16 8:47 ` Bin Meng
2022-11-28 8:20 ` Yu-Chien Peter Lin
2022-11-28 16:37 ` Yu-Chien Peter Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.