From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Li Nan <linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
yi.zhang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH -next v2 1/9] blk-iocost: cleanup ioc_qos_write() and ioc_cost_model_write()
Date: Wed, 30 Nov 2022 07:55:46 -0800 [thread overview]
Message-ID: <Y4d9AjL6BMbVSoUG@infradead.org> (raw)
In-Reply-To: <Y4d801NjwwT0voKA-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
On Wed, Nov 30, 2022 at 07:54:59AM -0800, Christoph Hellwig wrote:
> > + ret = nbytes;
>
> ret is an int which bytes is a size_t. So we at least need a ssize_t
> instead for ret, and even that assumes nbytes never overflows a ssize_t.
A better way might be to initialize ret to 0 at declaration time and
then do
if (ret)
return ret;
return nbytes;
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Li Nan <linan122@huawei.com>
Cc: tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com
Subject: Re: [PATCH -next v2 1/9] blk-iocost: cleanup ioc_qos_write() and ioc_cost_model_write()
Date: Wed, 30 Nov 2022 07:55:46 -0800 [thread overview]
Message-ID: <Y4d9AjL6BMbVSoUG@infradead.org> (raw)
In-Reply-To: <Y4d801NjwwT0voKA@infradead.org>
On Wed, Nov 30, 2022 at 07:54:59AM -0800, Christoph Hellwig wrote:
> > + ret = nbytes;
>
> ret is an int which bytes is a size_t. So we at least need a ssize_t
> instead for ret, and even that assumes nbytes never overflows a ssize_t.
A better way might be to initialize ret to 0 at declaration time and
then do
if (ret)
return ret;
return nbytes;
next prev parent reply other threads:[~2022-11-30 15:55 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 13:21 [PATCH -next v2 0/9] iocost bugfix Li Nan
2022-11-30 13:21 ` Li Nan
2022-11-30 13:21 ` [PATCH -next v2 1/9] blk-iocost: cleanup ioc_qos_write() and ioc_cost_model_write() Li Nan
2022-11-30 13:21 ` Li Nan
2022-11-30 15:54 ` Christoph Hellwig
[not found] ` <Y4d801NjwwT0voKA-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2022-11-30 15:55 ` Christoph Hellwig [this message]
2022-11-30 15:55 ` Christoph Hellwig
[not found] ` <20221130132156.2836184-2-linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-11-30 20:31 ` Tejun Heo
2022-11-30 20:31 ` Tejun Heo
2022-11-30 13:21 ` [PATCH -next v2 2/9] blk-iocost: improve hanlder of match_u64() Li Nan
2022-11-30 13:21 ` Li Nan
2022-11-30 20:32 ` Tejun Heo
[not found] ` <Y4e90zFnhhq764lP-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-12-01 2:15 ` Yu Kuai
2022-12-01 2:15 ` Yu Kuai
[not found] ` <7e4f1cea-2691-9b81-35f6-0dd236149f56-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2022-12-01 10:08 ` Tejun Heo
2022-12-01 10:08 ` Tejun Heo
2022-12-01 13:47 ` Yu Kuai
[not found] ` <20221130132156.2836184-1-linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-11-30 13:21 ` [PATCH -next v2 3/9] blk-iocost: don't allow to configure bio based device Li Nan
2022-11-30 13:21 ` Li Nan
[not found] ` <20221130132156.2836184-4-linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-11-30 20:15 ` Tejun Heo
2022-11-30 20:15 ` Tejun Heo
2022-11-30 13:21 ` [PATCH -next v2 5/9] blk-iocost: fix divide by 0 error in calc_lcoefs() Li Nan
2022-11-30 13:21 ` Li Nan
[not found] ` <20221130132156.2836184-6-linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-11-30 20:20 ` Tejun Heo
2022-11-30 20:20 ` Tejun Heo
2022-11-30 13:21 ` [PATCH -next v2 8/9] block: fix null-pointer dereference in ioc_pd_init Li Nan
2022-11-30 13:21 ` Li Nan
2022-11-30 20:50 ` Tejun Heo
2022-12-01 2:12 ` Yu Kuai
2022-12-01 2:12 ` Yu Kuai
[not found] ` <9ca2b7ab-7fd3-a9a3-12a6-021a78886b54-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2022-12-01 10:11 ` Tejun Heo
2022-12-01 10:11 ` Tejun Heo
[not found] ` <Y4h94m8QMPtS4xJV-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-12-01 10:23 ` Yu Kuai
2022-12-01 10:23 ` Yu Kuai
2022-12-01 10:31 ` Tejun Heo
2022-12-05 9:32 ` Yu Kuai
[not found] ` <96487803-12cc-a694-0099-784106596fd1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2022-12-12 23:10 ` Tejun Heo
2022-12-12 23:10 ` Tejun Heo
2022-11-30 13:21 ` [PATCH -next v2 9/9] blk-iocost: fix walk_list corruption Li Nan
2022-11-30 13:21 ` Li Nan
2022-11-30 20:59 ` Tejun Heo
2022-12-01 1:19 ` Yu Kuai
2022-12-01 1:19 ` Yu Kuai
[not found] ` <c028dd77-cabf-edd6-c893-8ee24762ac8c-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2022-12-01 10:00 ` Tejun Heo
2022-12-01 10:00 ` Tejun Heo
[not found] ` <Y4h7RxdT83g+zFN0-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-12-01 10:14 ` Yu Kuai
2022-12-01 10:14 ` Yu Kuai
[not found] ` <de04965e-1341-3053-0f4b-395b8390d00c-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2022-12-01 10:29 ` Tejun Heo
2022-12-01 10:29 ` Tejun Heo
2022-12-01 13:43 ` Yu Kuai
2022-12-05 9:35 ` Yu Kuai
2022-12-05 9:35 ` Yu Kuai
2022-11-30 17:26 ` [PATCH -next v2 0/9] iocost bugfix Jens Axboe
2022-11-30 17:26 ` Jens Axboe
2022-11-30 13:21 ` [PATCH -next v2 4/9] blk-iocost: read params inside lock in sysfs apis Li Nan
2022-11-30 13:21 ` Li Nan
[not found] ` <20221130132156.2836184-5-linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-11-30 20:16 ` Tejun Heo
2022-11-30 20:16 ` Tejun Heo
2022-11-30 13:21 ` [PATCH -next v2 6/9] blk-iocost: change div64_u64 to DIV64_U64_ROUND_UP in ioc_refresh_params() Li Nan
2022-11-30 13:21 ` Li Nan
[not found] ` <20221130132156.2836184-7-linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-11-30 20:22 ` Tejun Heo
2022-11-30 20:22 ` Tejun Heo
2022-11-30 13:21 ` [PATCH -next v2 7/9] blk-iocost: fix UAF in ioc_pd_free Li Nan
2022-11-30 13:21 ` Li Nan
[not found] ` <20221130132156.2836184-8-linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-11-30 20:42 ` Tejun Heo
2022-11-30 20:42 ` Tejun Heo
[not found] ` <Y4fAJpKcVL7Q9hgY-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-12-06 7:53 ` Yu Kuai
2022-12-06 7:53 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4d9AjL6BMbVSoUG@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org \
--cc=linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=yi.zhang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.