From: Matthias Kaehlcke <mka@chromium.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org,
andersson@kernel.org, tiwai@suse.com, lgirdwood@gmail.com,
robh+dt@kernel.org, agross@kernel.org,
srinivas.kandagatla@linaro.org, broonie@kernel.org,
bgoswami@quicinc.com, quic_plai@quicinc.com, swboyd@chromium.org,
judyhsiao@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: qcom: lpass-sc7180: Add maybe_unused tag for system PM ops
Date: Wed, 30 Nov 2022 17:07:46 +0000 [thread overview]
Message-ID: <Y4eN4utrDnEnKu/8@google.com> (raw)
In-Reply-To: <1669726428-3140-1-git-send-email-quic_srivasam@quicinc.com>
On Tue, Nov 29, 2022 at 06:23:48PM +0530, Srinivasa Rao Mandadapu wrote:
> Add __maybe_unused tag for system PM ops suspend and resume.
> This is required to fix allmodconfig compilation issue.
> Fixes: c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops")
This is incorrect, it should be '2d68148f8f85 ("ASoC: qcom: lpass-sc7180: Add
system suspend/resume PM ops")'. I see you fixed that in v2, but this patch
has already been applied ...
Srinivasa, it seems a similar patch is needed for commit c3bf7699747c ("ASoC:
qcom: lpass-sc7280: Add system suspend/resume PM ops"). For that you could use
SYSTEM_SLEEP_PM_OPS() instead of the maybe_unused tags as suggested by Nathan.
Mark, I appreciate you being responsive and picking patches quickly, it might
help though to leave 'external' reviewers at least some time to provide their
feedback :)
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org, lgirdwood@gmail.com,
broonie@kernel.org, robh+dt@kernel.org, quic_plai@quicinc.com,
bgoswami@quicinc.com, perex@perex.cz, tiwai@suse.com,
srinivas.kandagatla@linaro.org, quic_rohkumar@quicinc.com,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, swboyd@chromium.org,
judyhsiao@chromium.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ASoC: qcom: lpass-sc7180: Add maybe_unused tag for system PM ops
Date: Wed, 30 Nov 2022 17:07:46 +0000 [thread overview]
Message-ID: <Y4eN4utrDnEnKu/8@google.com> (raw)
In-Reply-To: <1669726428-3140-1-git-send-email-quic_srivasam@quicinc.com>
On Tue, Nov 29, 2022 at 06:23:48PM +0530, Srinivasa Rao Mandadapu wrote:
> Add __maybe_unused tag for system PM ops suspend and resume.
> This is required to fix allmodconfig compilation issue.
> Fixes: c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops")
This is incorrect, it should be '2d68148f8f85 ("ASoC: qcom: lpass-sc7180: Add
system suspend/resume PM ops")'. I see you fixed that in v2, but this patch
has already been applied ...
Srinivasa, it seems a similar patch is needed for commit c3bf7699747c ("ASoC:
qcom: lpass-sc7280: Add system suspend/resume PM ops"). For that you could use
SYSTEM_SLEEP_PM_OPS() instead of the maybe_unused tags as suggested by Nathan.
Mark, I appreciate you being responsive and picking patches quickly, it might
help though to leave 'external' reviewers at least some time to provide their
feedback :)
next prev parent reply other threads:[~2022-11-30 17:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 12:53 [PATCH] ASoC: qcom: lpass-sc7180: Add maybe_unused tag for system PM ops Srinivasa Rao Mandadapu
2022-11-29 14:43 ` Mark Brown
2022-11-29 14:43 ` Mark Brown
2022-11-29 15:40 ` Mark Brown
2022-11-29 15:45 ` Nathan Chancellor
2022-11-29 15:45 ` Nathan Chancellor
2022-11-29 15:58 ` Srinivasa Rao Mandadapu
2022-11-29 15:58 ` Srinivasa Rao Mandadapu
2022-11-29 16:05 ` Nathan Chancellor
2022-11-29 16:05 ` Nathan Chancellor
2022-11-29 20:08 ` Matthias Kaehlcke
2022-11-29 20:08 ` Matthias Kaehlcke
2022-12-01 7:02 ` Srinivasa Rao Mandadapu
2022-12-01 7:02 ` Srinivasa Rao Mandadapu
2022-11-30 17:07 ` Matthias Kaehlcke [this message]
2022-11-30 17:07 ` Matthias Kaehlcke
2022-11-30 17:16 ` Mark Brown
2022-11-30 17:16 ` Mark Brown
2022-11-30 17:37 ` Matthias Kaehlcke
2022-11-30 17:37 ` Matthias Kaehlcke
2022-11-30 19:12 ` Mark Brown
2022-11-30 19:12 ` Mark Brown
2022-12-01 3:31 ` Srinivasa Rao Mandadapu
2022-12-01 3:31 ` Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4eN4utrDnEnKu/8@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.