All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
	Johannes Berg <johannes.berg@intel.com>,
	Richard Weinberger <richard@nod.at>,
	Miloslav Trmac <mitr@volny.cz>,
	linux-input@vger.kernel.org, linux-um@lists.infradead.org
Subject: Re: [PATCH] input/misc: wistron_btns: disable on UML
Date: Wed, 30 Nov 2022 15:16:07 -0800	[thread overview]
Message-ID: <Y4fkNy9URvaW+AtN@google.com> (raw)
In-Reply-To: <20221130161604.1879-1-rdunlap@infradead.org>

On Wed, Nov 30, 2022 at 08:16:04AM -0800, Randy Dunlap wrote:
> The wistron_btns driver calls rtc_cmos_read(), which isn't
> available with UML builds, so disable this driver on UML.
> 
> Prevents this build error:
> 
> ld: drivers/input/misc/wistron_btns.o: in function `poll_bios':
> wistron_btns.c:(.text+0x4be): undefined reference to `rtc_cmos_read'
> 
> Fixes: 0bbadafdc49d ("um: allow disabling NO_IOMEM") # v5.14+
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Johannes Berg <johannes.berg@intel.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Miloslav Trmac <mitr@volny.cz>
> Cc: linux-input@vger.kernel.org
> Cc: linux-um@lists.infradead.org

Applied, thank you.

-- 
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
	Johannes Berg <johannes.berg@intel.com>,
	Richard Weinberger <richard@nod.at>,
	Miloslav Trmac <mitr@volny.cz>,
	linux-input@vger.kernel.org, linux-um@lists.infradead.org
Subject: Re: [PATCH] input/misc: wistron_btns: disable on UML
Date: Wed, 30 Nov 2022 15:16:07 -0800	[thread overview]
Message-ID: <Y4fkNy9URvaW+AtN@google.com> (raw)
In-Reply-To: <20221130161604.1879-1-rdunlap@infradead.org>

On Wed, Nov 30, 2022 at 08:16:04AM -0800, Randy Dunlap wrote:
> The wistron_btns driver calls rtc_cmos_read(), which isn't
> available with UML builds, so disable this driver on UML.
> 
> Prevents this build error:
> 
> ld: drivers/input/misc/wistron_btns.o: in function `poll_bios':
> wistron_btns.c:(.text+0x4be): undefined reference to `rtc_cmos_read'
> 
> Fixes: 0bbadafdc49d ("um: allow disabling NO_IOMEM") # v5.14+
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Johannes Berg <johannes.berg@intel.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Miloslav Trmac <mitr@volny.cz>
> Cc: linux-input@vger.kernel.org
> Cc: linux-um@lists.infradead.org

Applied, thank you.

-- 
Dmitry

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um

  reply	other threads:[~2022-11-30 23:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30 16:16 [PATCH] input/misc: wistron_btns: disable on UML Randy Dunlap
2022-11-30 16:16 ` Randy Dunlap
2022-11-30 23:16 ` Dmitry Torokhov [this message]
2022-11-30 23:16   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4fkNy9URvaW+AtN@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=johannes.berg@intel.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=mitr@volny.cz \
    --cc=rdunlap@infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.