All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Clark Wang <xiaoning.wang@nxp.com>,
	linux@rempel-privat.de, kernel@pengutronix.de,
	shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
	linux-imx@nxp.com, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: imx: add irqf_no_suspend flag
Date: Fri, 2 Dec 2022 00:11:17 +0100	[thread overview]
Message-ID: <Y4k0lVMueLEic75K@shikoro> (raw)
In-Reply-To: <20221116090249.GB12278@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

On Wed, Nov 16, 2022 at 10:02:49AM +0100, Oleksij Rempel wrote:
> On Wed, Nov 16, 2022 at 03:44:31PM +0800, Clark Wang wrote:
> > The i2c irq is masked when user starts an i2c transfer process
> > during noirq suspend stage. As a result, i2c transfer fails.
> > To solve the problem, IRQF_NO_SUSPEND is added to i2c bus.
> > 
> > Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
> 
> Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>

Is this really happening? The driver already implements
master_xfer_atomic, so I'd suspect it gets called instead?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Clark Wang <xiaoning.wang@nxp.com>,
	linux@rempel-privat.de, kernel@pengutronix.de,
	shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
	linux-imx@nxp.com, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: imx: add irqf_no_suspend flag
Date: Fri, 2 Dec 2022 00:11:17 +0100	[thread overview]
Message-ID: <Y4k0lVMueLEic75K@shikoro> (raw)
In-Reply-To: <20221116090249.GB12278@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 566 bytes --]

On Wed, Nov 16, 2022 at 10:02:49AM +0100, Oleksij Rempel wrote:
> On Wed, Nov 16, 2022 at 03:44:31PM +0800, Clark Wang wrote:
> > The i2c irq is masked when user starts an i2c transfer process
> > during noirq suspend stage. As a result, i2c transfer fails.
> > To solve the problem, IRQF_NO_SUSPEND is added to i2c bus.
> > 
> > Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
> 
> Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>

Is this really happening? The driver already implements
master_xfer_atomic, so I'd suspect it gets called instead?


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-12-01 23:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16  7:44 [PATCH] i2c: imx: add irqf_no_suspend flag Clark Wang
2022-11-16  7:44 ` Clark Wang
2022-11-16  9:02 ` Oleksij Rempel
2022-11-16  9:02   ` Oleksij Rempel
2022-12-01 23:11   ` Wolfram Sang [this message]
2022-12-01 23:11     ` Wolfram Sang
2022-12-09  2:37     ` Clark Wang
2022-12-09  2:37       ` Clark Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4k0lVMueLEic75K@shikoro \
    --to=wsa@kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rempel-privat.de \
    --cc=o.rempel@pengutronix.de \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.