From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
linux-kernel@vger.kernel.org, kbd@lists.altlinux.org
Subject: Re: [kbd] [patch 1/3] VT: Add height parameter to con_font_get/set consw operations
Date: Wed, 7 Dec 2022 09:21:18 +0100 [thread overview]
Message-ID: <Y5BM/q4K2a9V6SvR@kroah.com> (raw)
In-Reply-To: <fa5d6cbc-8f83-9e41-0513-adcb32422d2f@kernel.org>
On Wed, Dec 07, 2022 at 08:39:18AM +0100, Jiri Slaby wrote:
> On 06. 12. 22, 21:39, Samuel Thibault wrote:
> > Jiri Slaby, le mar. 06 déc. 2022 07:40:30 +0100, a ecrit:
> > > On 05. 12. 22, 1:07, Samuel Thibault wrote:
> > > > --- linux-6.0.orig/drivers/usb/misc/sisusbvga/sisusb_con.c
> > > > +++ linux-6.0/drivers/usb/misc/sisusbvga/sisusb_con.c
> > > ...
> > > > @@ -1268,7 +1271,7 @@ sisusbcon_font_get(struct vc_data *c, st
> > > > }
> > > > /* Copy 256 chars only, like vgacon */
> > > > - memcpy(font->data, sisusb->font_backup, 256 * 32);
> > > > + memcpy(font->data, sisusb->font_backup, 256 * height);
> > >
> > > Have you tested this?
> >
> > Ah, no, I had assumed that this was for a specific arch. But actually I
> > wasn't getting it because it depends on BROKEN.
>
> Hmm, for two years... I will remove the con support completely next week if
> noone beats me to it.
If you do it this week we can get it into 6.2 :)
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
kbd@lists.altlinux.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/3] VT: Add height parameter to con_font_get/set consw operations
Date: Wed, 7 Dec 2022 09:21:18 +0100 [thread overview]
Message-ID: <Y5BM/q4K2a9V6SvR@kroah.com> (raw)
In-Reply-To: <fa5d6cbc-8f83-9e41-0513-adcb32422d2f@kernel.org>
On Wed, Dec 07, 2022 at 08:39:18AM +0100, Jiri Slaby wrote:
> On 06. 12. 22, 21:39, Samuel Thibault wrote:
> > Jiri Slaby, le mar. 06 déc. 2022 07:40:30 +0100, a ecrit:
> > > On 05. 12. 22, 1:07, Samuel Thibault wrote:
> > > > --- linux-6.0.orig/drivers/usb/misc/sisusbvga/sisusb_con.c
> > > > +++ linux-6.0/drivers/usb/misc/sisusbvga/sisusb_con.c
> > > ...
> > > > @@ -1268,7 +1271,7 @@ sisusbcon_font_get(struct vc_data *c, st
> > > > }
> > > > /* Copy 256 chars only, like vgacon */
> > > > - memcpy(font->data, sisusb->font_backup, 256 * 32);
> > > > + memcpy(font->data, sisusb->font_backup, 256 * height);
> > >
> > > Have you tested this?
> >
> > Ah, no, I had assumed that this was for a specific arch. But actually I
> > wasn't getting it because it depends on BROKEN.
>
> Hmm, for two years... I will remove the con support completely next week if
> noone beats me to it.
If you do it this week we can get it into 6.2 :)
next prev parent reply other threads:[~2022-12-07 8:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 0:07 [kbd] [patch 0/3] VT: Support >32x32 fonts for hidpi displays Samuel Thibault
2022-12-05 0:07 ` Samuel Thibault
2022-12-05 0:07 ` [kbd] [patch 1/3] VT: Add height parameter to con_font_get/set consw operations Samuel Thibault
2022-12-05 0:07 ` Samuel Thibault
2022-12-06 6:40 ` [kbd] " Jiri Slaby
2022-12-06 6:40 ` Jiri Slaby
2022-12-06 20:39 ` [kbd] " Samuel Thibault
2022-12-06 20:39 ` Samuel Thibault
2022-12-07 7:39 ` [kbd] " Jiri Slaby
2022-12-07 7:39 ` Jiri Slaby
2022-12-07 8:21 ` Greg Kroah-Hartman [this message]
2022-12-07 8:21 ` Greg Kroah-Hartman
2022-12-05 0:07 ` [kbd] [patch 2/3] VT: Add KD_FONT_OP_SET/GET_TALL operations Samuel Thibault
2022-12-05 0:07 ` Samuel Thibault
2022-12-05 0:07 ` [kbd] [patch 3/3] VT: Bump font size limitation to 64x128 pixels Samuel Thibault
2022-12-05 0:07 ` Samuel Thibault
2022-12-06 6:48 ` [kbd] " Jiri Slaby
2022-12-06 6:48 ` Jiri Slaby
2022-12-06 20:47 ` [kbd] " Samuel Thibault
2022-12-06 20:47 ` Samuel Thibault
2022-12-05 0:09 ` [kbd] [patch 1/1] font: Leverage KD_FONT_OP_GET/SET_TALL font operations Samuel Thibault
2022-12-05 0:09 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5BM/q4K2a9V6SvR@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kbd@lists.altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.