Re: [PATCH 3/3] iommufd: Change the order of MSI setup

[Jason Gunthorpe <jgg@nvidia.com>]

On Thu, Dec 08, 2022 at 03:18:49PM +0100, Eric Auger wrote:
> > -	dev_warn(
> > -		idev->dev,
> > -		"MSI interrupt window cannot be isolated by the IOMMU, this platform is insecure. Use the \"allow_unsafe_interrupts\" module parameter to override\n");
> > +		dev_warn(
> > +			idev->dev,
> > +			"MSI interrupt window cannot be isolated by the IOMMU, this platform is insecure. Use the \"allow_unsafe_interrupts\" module parameter to override\n");

> I really prefer the legacy VFIO warning message: "No interrupt remapping
> support.  Use ...". IRQ remapping is the feature that is actually
> checked. MSI interrupt window sounds confusing: is it the MSI doorbell
> or the range of addresses that correspond to MSI addresses.

Well, that is true for x86 processors, but it is not what it is
called on ARM. I wanted something more neutral, but am not fussed
about it.

And I suppose "by the IOMMU" is not really acurate either.

How about

"MSI interrupts are not secure, they cannot be isolated by the
platform. Check that platform features like interrupt remapping are
enabled. Use the \"allow_unsafe_interrupts\" module parameter to override\n"

?

Thanks,
Jason