From: Jason Gunthorpe <jgg@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
Binbin Wu <binbin.wu@linux.intel.com>,
Eric Auger <eric.auger@redhat.com>,
"Yang, Lixiao" <lixiao.yang@intel.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
Nicolin Chen <nicolinc@nvidia.com>,
"Liu, Yi L" <yi.l.liu@intel.com>
Subject: Re: [PATCH 3/3] iommufd: Change the order of MSI setup
Date: Thu, 8 Dec 2022 08:22:14 -0400 [thread overview]
Message-ID: <Y5HW9tEHWKe2pSJN@nvidia.com> (raw)
In-Reply-To: <BL1PR11MB5271B670EDF3977798E931178C1D9@BL1PR11MB5271.namprd11.prod.outlook.com>
On Thu, Dec 08, 2022 at 06:06:33AM +0000, Tian, Kevin wrote:
> > From: Jason Gunthorpe <jgg@nvidia.com>
> > Sent: Thursday, December 8, 2022 4:45 AM
> >
> > Eric points out this is wrong for the rare case of someone using
> > allow_unsafe_interrupts on ARM. We always have to setup the MSI window
> > in
> > the domain if the iommu driver asks for it.
> >
> > Move the iommu_get_msi_cookie() setup to the top of the function and
> > always do it, regardless of the security mode. Add checks to
> > iommufd_device_setup_msi() to ensure the driver is not doing something
> > incomprehensible. No current driver will set both a HW and SW MSI window.
>
> "and have more than one SW MSI window".
>
> Should we also change vfio with same sanity check?
Probably not, it is to detect driver bugs, if buggy drivers exist they
will get fixed once they are tested with iommufd
Jason
next prev parent reply other threads:[~2022-12-08 12:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 20:44 [PATCH 0/3] iommufd review updates Jason Gunthorpe
2022-12-07 20:44 ` [PATCH 1/3] iommufd: Fix comment typos Jason Gunthorpe
2022-12-08 4:26 ` Tian, Kevin
2022-12-08 14:08 ` Eric Auger
2022-12-07 20:44 ` [PATCH 2/3] iommufd: Improve a few unclear bits of code Jason Gunthorpe
2022-12-08 4:32 ` Tian, Kevin
2022-12-08 14:08 ` Eric Auger
2022-12-07 20:44 ` [PATCH 3/3] iommufd: Change the order of MSI setup Jason Gunthorpe
2022-12-08 6:06 ` Tian, Kevin
2022-12-08 12:22 ` Jason Gunthorpe [this message]
2022-12-08 14:18 ` Eric Auger
2022-12-08 14:35 ` Jason Gunthorpe
2022-12-08 15:02 ` Eric Auger
2022-12-09 19:27 ` [PATCH 0/3] iommufd review updates Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5HW9tEHWKe2pSJN@nvidia.com \
--to=jgg@nvidia.com \
--cc=binbin.wu@linux.intel.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=kevin.tian@intel.com \
--cc=lixiao.yang@intel.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.