All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chester Lin <clin@suse.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Fabio Estevam" <festevam@gmail.com>,
	"Dong Aisheng" <aisheng.dong@nxp.com>,
	"Shawn Guo" <shawnguo@kernel.org>, "Jacky Bai" <ping.bai@nxp.com>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	s32@nxp.com, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Larisa Grigore" <larisa.grigore@nxp.com>,
	"Ghennadi Procopciuc" <Ghennadi.Procopciuc@nxp.com>,
	"Andrei Stefanescu" <andrei.stefanescu@nxp.com>,
	"Radu Pirea" <radu-nicolae.pirea@nxp.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Matthias Brugger" <mbrugger@suse.com>,
	"Matthew Nunez" <matthew.nunez@nxp.com>,
	"Phu Luu An" <phu.luuan@nxp.com>,
	"Stefan-Gabriel Mirea" <stefan-gabriel.mirea@nxp.com>
Subject: Re: [PATCH v2 2/2] pinctrl: add NXP S32 SoC family support
Date: Fri, 9 Dec 2022 12:38:51 +0800	[thread overview]
Message-ID: <Y5K726npjKAO4sIq@linux-8mug> (raw)
In-Reply-To: <CACRpkdaKYFbXRcV1WgDEiYPEwzNAZq-AqAHpWd1rJyW-h369dw@mail.gmail.com>

Hi Linus and Fabio,

Thanks for your time to review this patch!

On Thu, Dec 08, 2022 at 10:37:36PM +0100, Linus Walleij wrote:
> On Thu, Dec 8, 2022 at 12:04 AM Fabio Estevam <festevam@gmail.com> wrote:
> 
> > In other imx8m pinctrl drivers we pass:
> (...)
> > > +module_platform_driver(s32g_pinctrl_driver);
> >
> > And we also register it in arch_initcall() level.
> 
> Do you really need that though? This driver certainly does not.
> 
> I was under the impression that recent changes to the probe-order
> logic has made most explicit arch_ etc initcall orderings surplus.
> 

Could bool/tristate options in the Kconfig be the key point?

Based on current design I prefer to build the s32g2 pinctrl driver as built-in
rather than a loadable module. IIUC, when the driver is not built as module
then the initcall ordering should still matter.

Feel free to correct me if anything wrong.

Regards,
Chester


> Yours,
> Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: Chester Lin <clin@suse.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Fabio Estevam" <festevam@gmail.com>,
	"Dong Aisheng" <aisheng.dong@nxp.com>,
	"Shawn Guo" <shawnguo@kernel.org>, "Jacky Bai" <ping.bai@nxp.com>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	s32@nxp.com, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Larisa Grigore" <larisa.grigore@nxp.com>,
	"Ghennadi Procopciuc" <Ghennadi.Procopciuc@nxp.com>,
	"Andrei Stefanescu" <andrei.stefanescu@nxp.com>,
	"Radu Pirea" <radu-nicolae.pirea@nxp.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Matthias Brugger" <mbrugger@suse.com>,
	"Matthew Nunez" <matthew.nunez@nxp.com>,
	"Phu Luu An" <phu.luuan@nxp.com>,
	"Stefan-Gabriel Mirea" <stefan-gabriel.mirea@nxp.com>
Subject: Re: [PATCH v2 2/2] pinctrl: add NXP S32 SoC family support
Date: Fri, 9 Dec 2022 12:38:51 +0800	[thread overview]
Message-ID: <Y5K726npjKAO4sIq@linux-8mug> (raw)
In-Reply-To: <CACRpkdaKYFbXRcV1WgDEiYPEwzNAZq-AqAHpWd1rJyW-h369dw@mail.gmail.com>

Hi Linus and Fabio,

Thanks for your time to review this patch!

On Thu, Dec 08, 2022 at 10:37:36PM +0100, Linus Walleij wrote:
> On Thu, Dec 8, 2022 at 12:04 AM Fabio Estevam <festevam@gmail.com> wrote:
> 
> > In other imx8m pinctrl drivers we pass:
> (...)
> > > +module_platform_driver(s32g_pinctrl_driver);
> >
> > And we also register it in arch_initcall() level.
> 
> Do you really need that though? This driver certainly does not.
> 
> I was under the impression that recent changes to the probe-order
> logic has made most explicit arch_ etc initcall orderings surplus.
> 

Could bool/tristate options in the Kconfig be the key point?

Based on current design I prefer to build the s32g2 pinctrl driver as built-in
rather than a loadable module. IIUC, when the driver is not built as module
then the initcall ordering should still matter.

Feel free to correct me if anything wrong.

Regards,
Chester


> Yours,
> Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-12-09  4:39 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28  5:48 [PATCH v2 0/2] Add pinctrl support for S32 SoC family Chester Lin
2022-11-28  5:48 ` Chester Lin
2022-11-28  5:48 ` [PATCH v2 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs Chester Lin
2022-11-28  5:48   ` Chester Lin
2022-11-29 14:00   ` Andreas Färber
2022-11-29 14:00     ` Andreas Färber
2022-11-29 14:52     ` Chester Lin
2022-11-29 14:52       ` Chester Lin
2022-11-30 14:58   ` Krzysztof Kozlowski
2022-11-30 14:58     ` Krzysztof Kozlowski
2022-12-05  6:16     ` Chester Lin
2022-12-05  6:16       ` Chester Lin
2022-12-05  9:02       ` Krzysztof Kozlowski
2022-12-05  9:02         ` Krzysztof Kozlowski
2022-12-05 11:05         ` Chester Lin
2022-12-05 11:05           ` Chester Lin
2022-12-05 13:26           ` Krzysztof Kozlowski
2022-12-05 13:26             ` Krzysztof Kozlowski
2022-11-28  5:48 ` [PATCH v2 2/2] pinctrl: add NXP S32 SoC family support Chester Lin
2022-11-28  5:48   ` Chester Lin
2022-11-29 13:40   ` Andreas Färber
2022-11-29 13:40     ` Andreas Färber
2022-12-05  7:06     ` Chester Lin
2022-12-05  7:06       ` Chester Lin
2022-12-07 22:52   ` Linus Walleij
2022-12-07 22:52     ` Linus Walleij
2022-12-07 23:04   ` Fabio Estevam
2022-12-07 23:04     ` Fabio Estevam
2022-12-08 21:37     ` Linus Walleij
2022-12-08 21:37       ` Linus Walleij
2022-12-09  4:38       ` Chester Lin [this message]
2022-12-09  4:38         ` Chester Lin
2022-12-09 11:27         ` Linus Walleij
2022-12-09 11:27           ` Linus Walleij
2022-12-14 23:08           ` Saravana Kannan
2022-12-14 23:08             ` Saravana Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5K726npjKAO4sIq@linux-8mug \
    --to=clin@suse.com \
    --cc=Ghennadi.Procopciuc@nxp.com \
    --cc=afaerber@suse.de \
    --cc=aisheng.dong@nxp.com \
    --cc=andrei.stefanescu@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=larisa.grigore@nxp.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.nunez@nxp.com \
    --cc=mbrugger@suse.com \
    --cc=phu.luuan@nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=radu-nicolae.pirea@nxp.com \
    --cc=s32@nxp.com \
    --cc=shawnguo@kernel.org \
    --cc=stefan-gabriel.mirea@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.