All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	Steen.Hegelund@microchip.com, daniel.machon@microchip.com,
	lars.povlsen@microchip.com, UNGLinuxDriver@microchip.com,
	kernel test robot <lkp@intel.com>,
	Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask
Date: Fri, 9 Dec 2022 15:19:53 -0800	[thread overview]
Message-ID: <Y5PCmYVzx3nuZ9qa@x130> (raw)
In-Reply-To: <20221209120701.218937-1-horatiu.vultur@microchip.com>

On 09 Dec 13:07, Horatiu Vultur wrote:
>Fix the following smatch warning:
>
>smatch warnings:
>drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c:103 vcap_debugfs_show_rule_keyfield() error: uninitialized symbol 'value'.
>drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c:106 vcap_debugfs_show_rule_keyfield() error: uninitialized symbol 'mask'.
>
>In case the vcap field was VCAP_FIELD_U128 and the key was different
>than IP6_S/DIP then the value and mask were not initialized, therefore
>initialize them.
>
>Fixes: 610c32b2ce66 ("net: microchip: vcap: Add vcap_get_rule")
>Reported-by: kernel test robot <lkp@intel.com>
>Reported-by: Dan Carpenter <error27@gmail.com>
>Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>

Reviewed-by: Saeed Mahameed <saeed@kernel.org>



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Saeed Mahameed <saeed@kernel.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	Steen.Hegelund@microchip.com, daniel.machon@microchip.com,
	lars.povlsen@microchip.com, UNGLinuxDriver@microchip.com,
	kernel test robot <lkp@intel.com>,
	Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask
Date: Fri, 9 Dec 2022 15:19:53 -0800	[thread overview]
Message-ID: <Y5PCmYVzx3nuZ9qa@x130> (raw)
In-Reply-To: <20221209120701.218937-1-horatiu.vultur@microchip.com>

On 09 Dec 13:07, Horatiu Vultur wrote:
>Fix the following smatch warning:
>
>smatch warnings:
>drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c:103 vcap_debugfs_show_rule_keyfield() error: uninitialized symbol 'value'.
>drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c:106 vcap_debugfs_show_rule_keyfield() error: uninitialized symbol 'mask'.
>
>In case the vcap field was VCAP_FIELD_U128 and the key was different
>than IP6_S/DIP then the value and mask were not initialized, therefore
>initialize them.
>
>Fixes: 610c32b2ce66 ("net: microchip: vcap: Add vcap_get_rule")
>Reported-by: kernel test robot <lkp@intel.com>
>Reported-by: Dan Carpenter <error27@gmail.com>
>Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>

Reviewed-by: Saeed Mahameed <saeed@kernel.org>



  reply	other threads:[~2022-12-09 23:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09 12:07 [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask Horatiu Vultur
2022-12-09 12:07 ` Horatiu Vultur
2022-12-09 23:19 ` Saeed Mahameed [this message]
2022-12-09 23:19   ` Saeed Mahameed
2022-12-12 21:02 ` Jakub Kicinski
2022-12-12 21:02   ` Jakub Kicinski
2022-12-13  7:35   ` Horatiu Vultur
2022-12-13  7:35     ` Horatiu Vultur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5PCmYVzx3nuZ9qa@x130 \
    --to=saeed@kernel.org \
    --cc=Steen.Hegelund@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=daniel.machon@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=error27@gmail.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=kuba@kernel.org \
    --cc=lars.povlsen@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.