All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	maddy@linux.vnet.ibm.com,
	Nageswara Sastry <rnsastry@linux.ibm.com>,
	linux-perf-users@vger.kernel.org,
	James Clark <james.clark@arm.com>,
	Kajol Jain <kjain@linux.ibm.com>,
	Namhyung Kim <namhyung@kernel.org>,
	disgoel@linux.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] perf test: Update event group check for support of uncore event
Date: Mon, 12 Dec 2022 12:39:28 -0300	[thread overview]
Message-ID: <Y5dLME8rr1YIfyQe@kernel.org> (raw)
In-Reply-To: <3C59F3E6-B7DE-485B-9483-703EBDE9AC41@linux.vnet.ibm.com>

Em Fri, Dec 09, 2022 at 12:57:34PM +0530, Athira Rajeev escreveu:
> 
> 
> > On 08-Dec-2022, at 9:48 AM, Ravi Bangoria <ravi.bangoria@amd.com> wrote:
> > 
> > On 07-Dec-22 10:28 PM, Athira Rajeev wrote:
> >> Event group test checks group creation for combinations of
> >> hw, sw and uncore PMU events. Some of the uncore pmus may
> >> require additional permission to access the counters.
> >> For example, in case of hv_24x7, partition need to have
> >> permissions to access hv_24x7 pmu counters. If not, event_open
> >> will fail. Hence add a sanity check to see if event_open
> >> succeeds before proceeding with the test.
> >> 
> >> Fixes: b20d9215a35f ("perf test: Add event group test for events in multiple PMUs")
> >> Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
> > 
> > Acked-by: Ravi Bangoria <ravi.bangoria@amd.com>
> 
> Thanks Ravi for checking the patch

Thanks, applied.

- Arnaldo


WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Ian Rogers <irogers@google.com>,
	maddy@linux.vnet.ibm.com,
	Nageswara Sastry <rnsastry@linux.ibm.com>,
	Kajol Jain <kjain@linux.ibm.com>,
	Ravi Bangoria <ravi.bangoria@amd.com>,
	linux-perf-users@vger.kernel.org,
	James Clark <james.clark@arm.com>, Jiri Olsa <jolsa@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	disgoel@linux.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] perf test: Update event group check for support of uncore event
Date: Mon, 12 Dec 2022 12:39:28 -0300	[thread overview]
Message-ID: <Y5dLME8rr1YIfyQe@kernel.org> (raw)
In-Reply-To: <3C59F3E6-B7DE-485B-9483-703EBDE9AC41@linux.vnet.ibm.com>

Em Fri, Dec 09, 2022 at 12:57:34PM +0530, Athira Rajeev escreveu:
> 
> 
> > On 08-Dec-2022, at 9:48 AM, Ravi Bangoria <ravi.bangoria@amd.com> wrote:
> > 
> > On 07-Dec-22 10:28 PM, Athira Rajeev wrote:
> >> Event group test checks group creation for combinations of
> >> hw, sw and uncore PMU events. Some of the uncore pmus may
> >> require additional permission to access the counters.
> >> For example, in case of hv_24x7, partition need to have
> >> permissions to access hv_24x7 pmu counters. If not, event_open
> >> will fail. Hence add a sanity check to see if event_open
> >> succeeds before proceeding with the test.
> >> 
> >> Fixes: b20d9215a35f ("perf test: Add event group test for events in multiple PMUs")
> >> Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
> > 
> > Acked-by: Ravi Bangoria <ravi.bangoria@amd.com>
> 
> Thanks Ravi for checking the patch

Thanks, applied.

- Arnaldo


  reply	other threads:[~2022-12-12 15:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-07 16:58 [PATCH] perf test: Update event group check for support of uncore event Athira Rajeev
2022-12-07 16:58 ` Athira Rajeev
2022-12-08  4:18 ` Ravi Bangoria
2022-12-08  4:18   ` Ravi Bangoria
2022-12-09  7:27   ` Athira Rajeev
2022-12-09  7:27     ` Athira Rajeev
2022-12-12 15:39     ` Arnaldo Carvalho de Melo [this message]
2022-12-12 15:39       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5dLME8rr1YIfyQe@kernel.org \
    --to=acme@kernel.org \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=disgoel@linux.ibm.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@kernel.org \
    --cc=kjain@linux.ibm.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.vnet.ibm.com \
    --cc=namhyung@kernel.org \
    --cc=ravi.bangoria@amd.com \
    --cc=rnsastry@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.