From: Greg KH <gregkh@linuxfoundation.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
Date: Wed, 14 Dec 2022 09:25:51 +0100 [thread overview]
Message-ID: <Y5mIj6yLpObaLfSr@kroah.com> (raw)
In-Reply-To: <20221214025414.44866-1-jiasheng@iscas.ac.cn>
On Wed, Dec 14, 2022 at 10:54:14AM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of dma_alloc_coherent in order to
> avoid NULL pointer dereference.
>
> This flaw was found using an experimental static analysis tool we are
> developing, APP-Miner, which has not been disclosed.
>
> The allyesconfig build using GCC 9.3.0 shows no new warning. As we
> don't have a UDC device to test with, no runtime testing was able to
> be performed.
>
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
>
> v1 -> v2:
>
> 1. Add "goto err;" when allocation fails.
You already sent a previous v2 that differs from this one, this should
be v3, right?
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: neal_liu@aspeedtech.com, joel@jms.id.au, andrew@aj.id.au,
sumit.semwal@linaro.org, christian.koenig@amd.com,
linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
Date: Wed, 14 Dec 2022 09:25:51 +0100 [thread overview]
Message-ID: <Y5mIj6yLpObaLfSr@kroah.com> (raw)
In-Reply-To: <20221214025414.44866-1-jiasheng@iscas.ac.cn>
On Wed, Dec 14, 2022 at 10:54:14AM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of dma_alloc_coherent in order to
> avoid NULL pointer dereference.
>
> This flaw was found using an experimental static analysis tool we are
> developing, APP-Miner, which has not been disclosed.
>
> The allyesconfig build using GCC 9.3.0 shows no new warning. As we
> don't have a UDC device to test with, no runtime testing was able to
> be performed.
>
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
>
> v1 -> v2:
>
> 1. Add "goto err;" when allocation fails.
You already sent a previous v2 that differs from this one, this should
be v3, right?
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: neal_liu@aspeedtech.com, joel@jms.id.au, andrew@aj.id.au,
sumit.semwal@linaro.org, christian.koenig@amd.com,
linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
Date: Wed, 14 Dec 2022 09:25:51 +0100 [thread overview]
Message-ID: <Y5mIj6yLpObaLfSr@kroah.com> (raw)
In-Reply-To: <20221214025414.44866-1-jiasheng@iscas.ac.cn>
On Wed, Dec 14, 2022 at 10:54:14AM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of dma_alloc_coherent in order to
> avoid NULL pointer dereference.
>
> This flaw was found using an experimental static analysis tool we are
> developing, APP-Miner, which has not been disclosed.
>
> The allyesconfig build using GCC 9.3.0 shows no new warning. As we
> don't have a UDC device to test with, no runtime testing was able to
> be performed.
>
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
>
> v1 -> v2:
>
> 1. Add "goto err;" when allocation fails.
You already sent a previous v2 that differs from this one, this should
be v3, right?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: linux-aspeed@lists.ozlabs.org, andrew@aj.id.au,
neal_liu@aspeedtech.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
sumit.semwal@linaro.org, linaro-mm-sig@lists.linaro.org,
joel@jms.id.au, christian.koenig@amd.com,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
Date: Wed, 14 Dec 2022 09:25:51 +0100 [thread overview]
Message-ID: <Y5mIj6yLpObaLfSr@kroah.com> (raw)
In-Reply-To: <20221214025414.44866-1-jiasheng@iscas.ac.cn>
On Wed, Dec 14, 2022 at 10:54:14AM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of dma_alloc_coherent in order to
> avoid NULL pointer dereference.
>
> This flaw was found using an experimental static analysis tool we are
> developing, APP-Miner, which has not been disclosed.
>
> The allyesconfig build using GCC 9.3.0 shows no new warning. As we
> don't have a UDC device to test with, no runtime testing was able to
> be performed.
>
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
>
> v1 -> v2:
>
> 1. Add "goto err;" when allocation fails.
You already sent a previous v2 that differs from this one, this should
be v3, right?
next prev parent reply other threads:[~2022-12-14 8:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 2:54 [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent Jiasheng Jiang
2022-12-14 2:54 ` Jiasheng Jiang
2022-12-14 2:54 ` Jiasheng Jiang
2022-12-14 2:54 ` Jiasheng Jiang
2022-12-14 8:25 ` Greg KH [this message]
2022-12-14 8:25 ` Greg KH
2022-12-14 8:25 ` Greg KH
2022-12-14 8:25 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2022-12-13 12:21 Jiasheng Jiang
2022-12-13 12:21 ` Jiasheng Jiang
2022-12-13 12:21 ` Jiasheng Jiang
2022-12-13 12:21 ` Jiasheng Jiang
2022-12-13 14:32 ` Greg KH
2022-12-13 14:32 ` Greg KH
2022-12-13 14:32 ` Greg KH
2022-12-13 14:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5mIj6yLpObaLfSr@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.