* [PATCH] KVM: selftests: Fix a typo in the vcpu_msrs_set assert
@ 2022-12-09 20:13 Aaron Lewis
2022-12-09 20:38 ` Jim Mattson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Aaron Lewis @ 2022-12-09 20:13 UTC (permalink / raw)
To: kvm; +Cc: pbonzini, jmattson, seanjc, Aaron Lewis
The assert incorrectly identifies the ioctl being called. Switch it
from KVM_GET_MSRS to KVM_SET_MSRS.
Fixes: 6ebfef83f03f ("KVM: selftest: Add proper helpers for x86-specific save/restore ioctls")
Signed-off-by: Aaron Lewis <aaronlewis@google.com>
---
tools/testing/selftests/kvm/include/x86_64/processor.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/kvm/include/x86_64/processor.h b/tools/testing/selftests/kvm/include/x86_64/processor.h
index b1a31de7108a..92c5c9eba1bb 100644
--- a/tools/testing/selftests/kvm/include/x86_64/processor.h
+++ b/tools/testing/selftests/kvm/include/x86_64/processor.h
@@ -716,7 +716,7 @@ static inline void vcpu_msrs_set(struct kvm_vcpu *vcpu, struct kvm_msrs *msrs)
int r = __vcpu_ioctl(vcpu, KVM_SET_MSRS, msrs);
TEST_ASSERT(r == msrs->nmsrs,
- "KVM_GET_MSRS failed, r: %i (failed on MSR %x)",
+ "KVM_SET_MSRS failed, r: %i (failed on MSR %x)",
r, r < 0 || r >= msrs->nmsrs ? -1 : msrs->entries[r].index);
}
static inline void vcpu_debugregs_get(struct kvm_vcpu *vcpu,
--
2.39.0.rc1.256.g54fd8350bd-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] KVM: selftests: Fix a typo in the vcpu_msrs_set assert
2022-12-09 20:13 [PATCH] KVM: selftests: Fix a typo in the vcpu_msrs_set assert Aaron Lewis
@ 2022-12-09 20:38 ` Jim Mattson
2022-12-15 17:13 ` Sean Christopherson
2023-01-19 21:01 ` Sean Christopherson
2 siblings, 0 replies; 4+ messages in thread
From: Jim Mattson @ 2022-12-09 20:38 UTC (permalink / raw)
To: Aaron Lewis; +Cc: kvm, pbonzini, seanjc
On Fri, Dec 9, 2022 at 12:13 PM Aaron Lewis <aaronlewis@google.com> wrote:
>
> The assert incorrectly identifies the ioctl being called. Switch it
> from KVM_GET_MSRS to KVM_SET_MSRS.
>
> Fixes: 6ebfef83f03f ("KVM: selftest: Add proper helpers for x86-specific save/restore ioctls")
> Signed-off-by: Aaron Lewis <aaronlewis@google.com>
Reviewed-by: Jim Mattson <jmattson@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] KVM: selftests: Fix a typo in the vcpu_msrs_set assert
2022-12-09 20:13 [PATCH] KVM: selftests: Fix a typo in the vcpu_msrs_set assert Aaron Lewis
2022-12-09 20:38 ` Jim Mattson
@ 2022-12-15 17:13 ` Sean Christopherson
2023-01-19 21:01 ` Sean Christopherson
2 siblings, 0 replies; 4+ messages in thread
From: Sean Christopherson @ 2022-12-15 17:13 UTC (permalink / raw)
To: Aaron Lewis; +Cc: kvm, pbonzini, jmattson
On Fri, Dec 09, 2022, Aaron Lewis wrote:
> The assert incorrectly identifies the ioctl being called. Switch it
> from KVM_GET_MSRS to KVM_SET_MSRS.
>
> Fixes: 6ebfef83f03f ("KVM: selftest: Add proper helpers for x86-specific save/restore ioctls")
> Signed-off-by: Aaron Lewis <aaronlewis@google.com>
> ---
Reviewed-by: Sean Christopherson <seanjc@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] KVM: selftests: Fix a typo in the vcpu_msrs_set assert
2022-12-09 20:13 [PATCH] KVM: selftests: Fix a typo in the vcpu_msrs_set assert Aaron Lewis
2022-12-09 20:38 ` Jim Mattson
2022-12-15 17:13 ` Sean Christopherson
@ 2023-01-19 21:01 ` Sean Christopherson
2 siblings, 0 replies; 4+ messages in thread
From: Sean Christopherson @ 2023-01-19 21:01 UTC (permalink / raw)
To: Sean Christopherson, kvm, Aaron Lewis; +Cc: pbonzini, jmattson
On Fri, 09 Dec 2022 20:13:27 +0000, Aaron Lewis wrote:
> The assert incorrectly identifies the ioctl being called. Switch it
> from KVM_GET_MSRS to KVM_SET_MSRS.
>
>
Applied to kvm-x86 selftests, thanks!
[1/1] KVM: selftests: Fix a typo in the vcpu_msrs_set assert
https://github.com/kvm-x86/linux/commit/589713ee5f12
--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-19 21:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-09 20:13 [PATCH] KVM: selftests: Fix a typo in the vcpu_msrs_set assert Aaron Lewis
2022-12-09 20:38 ` Jim Mattson
2022-12-15 17:13 ` Sean Christopherson
2023-01-19 21:01 ` Sean Christopherson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.