From: Petr Vorel <pvorel@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 3/7] cgroup_regression_test.sh: Remove obselte test_6
Date: Fri, 16 Dec 2022 10:02:06 +0100 [thread overview]
Message-ID: <Y5w0DtP9yETeJl2T@pevik> (raw)
In-Reply-To: <1671166923-2173-3-git-send-email-xuyang2018.jy@fujitsu.com>
> test_6 is a test case when kernel version is less than 3.0.
> Since the oldest supported kernel version is 3.0, so the case
> is useless. Remove it.
Acked-by: Petr Vorel <pvorel@suse.cz>
> Also rename test9 to test6. modify TST_CNT.
I wonder if rename is a good thing to do, because it complicates git history.
I'd keep old names.
Also in the past we didn't rename, e.g. in 1c44244849 ("getuid, getgid, setuid,
setgid: fixed 16-bit versions")
testcases/kernel/syscalls/getuid/getuid02.c was renamed to
testcases/kernel/syscalls/geteuid/geteuid02.c to match the new test coverage,
but testcases/kernel/syscalls/getuid/getuid03.c stayed the same (not renamed to
testcases/kernel/syscalls/getuid/getuid02.c, which was then free).
Or maybe better example: testcases/kernel/syscalls/kill/kill01.c got deleted
in eafdc5dd83 ("syscalls/kill01: Remove it"), but test names did not shift.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-12-16 9:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 5:01 [LTP] [PATCH v3 1/7] lib/tst_kvercmp: Remove old distnames Yang Xu
2022-12-16 5:01 ` [LTP] [PATCH v3 2/7] shell: Remove old kernel version check Yang Xu
2022-12-16 8:55 ` Petr Vorel
2022-12-16 5:01 ` [LTP] [PATCH v3 3/7] cgroup_regression_test.sh: Remove obselte test_6 Yang Xu
2022-12-16 9:02 ` Petr Vorel [this message]
2022-12-16 9:11 ` xuyang2018.jy
2022-12-16 10:36 ` Petr Vorel
2022-12-16 5:02 ` [LTP] [PATCH v3 4/7] doc/shell-test-api.txt Yang Xu
2022-12-16 9:49 ` Petr Vorel
2022-12-16 5:02 ` [LTP] [PATCH v3 5/7] Remove old kernel version check in C case when using tst_kvercmp Yang Xu
2022-12-16 10:03 ` Petr Vorel
2022-12-16 5:02 ` [LTP] [PATCH v3 6/7] Remove old kernel version check when using min_kver Yang Xu
2022-12-16 10:11 ` Petr Vorel
2022-12-16 5:02 ` [LTP] [PATCH v3 7/7] doc/c-test-api.txt Yang Xu
2022-12-16 10:12 ` Petr Vorel
2022-12-19 3:01 ` xuyang2018.jy
2022-12-19 7:38 ` Petr Vorel
2023-01-03 17:53 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5w0DtP9yETeJl2T@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.