Re: [LTP] [PATCH v3 3/7] cgroup_regression_test.sh: Remove obselte test_6

[Petr Vorel <pvorel@suse.cz>]

Hi Xu,

> >> test_6 is a test case when kernel version is less than 3.0.
> >> Since the oldest supported kernel version is 3.0, so the case
> >> is useless. Remove it.

It would be worth to note here:
CONFIG_CGROUP_NS is not supported in kernel >= 3.0

Because tests have comments with kernel versions which are a bit misleading
(all comments have 2.6.x).

Also note typo on the subject: obselte => obsolete.

> >> Also rename test9 to test6. modify TST_CNT.
> > I wonder if rename is a good thing to do, because it complicates git history.
> > I'd keep old names.
> > Also in the past we didn't rename, e.g. in 1c44244849 ("getuid, getgid, setuid,
> > setgid: fixed 16-bit versions")
> > testcases/kernel/syscalls/getuid/getuid02.c was renamed to
> > testcases/kernel/syscalls/geteuid/geteuid02.c to match the new test coverage,
> > but testcases/kernel/syscalls/getuid/getuid03.c stayed the same (not renamed to
> > testcases/kernel/syscalls/getuid/getuid02.c, which was then free).

> > Or maybe better example: testcases/kernel/syscalls/kill/kill01.c got deleted
> > in eafdc5dd83 ("syscalls/kill01: Remove it"), but test names did not shift.

> I can understand,  but I used the same renamed way because we did this 
> case for test_5 in 2019[1].

> [1]https://github.com/linux-test-project/ltp/commit/9b8f841ced26cd0d19dc9a007d0efd941929abde

OK, due TST_CNT it must be shifted, I'm sorry.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp