From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Adrien Thierry <athierry@redhat.com>,
Brian Masney <bmasney@redhat.com>,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v2 4/5] PM: Allow calling dev_pm_domain_set() with raw spinlock
Date: Thu, 12 Jan 2023 12:13:20 +0100 [thread overview]
Message-ID: <Y7/rUHCjPyNA0YNt@linutronix.de> (raw)
In-Reply-To: <20221219151503.385816-5-krzysztof.kozlowski@linaro.org>
On 2022-12-19 16:15:02 [+0100], Krzysztof Kozlowski wrote:
> device_pm_check_callbacks() uses dev->power spinlock, which on
> PREEMPT_RT sleeps. However some PM domains on PREEMPT_RT might be using
> raw spinlocks as genpd_lock(), thus dev_pm_domain_set() must not call
> device_pm_check_callbacks(). In fact device_pm_check_callbacks() is not
> strictly related to dev_pm_domain_set() and calls for these two can be
> made separately.
>
> Add new helper dev_pm_domain_set_no_cb() which will only set PM domain
> but will not check the callbacks, leaving the checl to the caller.
s/checl/check/
But this I comprehend.
> Cc: Adrien Thierry <athierry@redhat.com>
> Cc: Brian Masney <bmasney@redhat.com>
> Cc: linux-rt-users@vger.kernel.org
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Adrien Thierry <athierry@redhat.com>,
Brian Masney <bmasney@redhat.com>,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v2 4/5] PM: Allow calling dev_pm_domain_set() with raw spinlock
Date: Thu, 12 Jan 2023 12:13:20 +0100 [thread overview]
Message-ID: <Y7/rUHCjPyNA0YNt@linutronix.de> (raw)
In-Reply-To: <20221219151503.385816-5-krzysztof.kozlowski@linaro.org>
On 2022-12-19 16:15:02 [+0100], Krzysztof Kozlowski wrote:
> device_pm_check_callbacks() uses dev->power spinlock, which on
> PREEMPT_RT sleeps. However some PM domains on PREEMPT_RT might be using
> raw spinlocks as genpd_lock(), thus dev_pm_domain_set() must not call
> device_pm_check_callbacks(). In fact device_pm_check_callbacks() is not
> strictly related to dev_pm_domain_set() and calls for these two can be
> made separately.
>
> Add new helper dev_pm_domain_set_no_cb() which will only set PM domain
> but will not check the callbacks, leaving the checl to the caller.
s/checl/check/
But this I comprehend.
> Cc: Adrien Thierry <athierry@redhat.com>
> Cc: Brian Masney <bmasney@redhat.com>
> Cc: linux-rt-users@vger.kernel.org
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sebastian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-12 11:23 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 15:14 [PATCH v2 0/5] PM: Fixes for Realtime systems Krzysztof Kozlowski
2022-12-19 15:14 ` Krzysztof Kozlowski
2022-12-19 15:14 ` [PATCH v2 1/5] PM: domains: Add GENPD_FLAG_RT_SAFE for PREEMPT_RT Krzysztof Kozlowski
2022-12-19 15:14 ` Krzysztof Kozlowski
2023-01-04 15:45 ` Ulf Hansson
2023-01-04 15:45 ` Ulf Hansson
2023-01-06 14:52 ` Krzysztof Kozlowski
2023-01-06 14:52 ` Krzysztof Kozlowski
2023-01-12 10:36 ` Sebastian Andrzej Siewior
2023-01-12 10:36 ` Sebastian Andrzej Siewior
2023-01-12 11:27 ` Krzysztof Kozlowski
2023-01-12 11:27 ` Krzysztof Kozlowski
2023-01-12 10:32 ` Sebastian Andrzej Siewior
2023-01-12 10:32 ` Sebastian Andrzej Siewior
2023-01-12 11:31 ` Krzysztof Kozlowski
2023-01-12 11:31 ` Krzysztof Kozlowski
2022-12-19 15:15 ` [PATCH v2 2/5] cpuidle: psci: Mark as PREEMPT_RT safe Krzysztof Kozlowski
2022-12-19 15:15 ` Krzysztof Kozlowski
2023-01-12 11:00 ` Sebastian Andrzej Siewior
2023-01-12 11:00 ` Sebastian Andrzej Siewior
2023-01-12 11:32 ` Krzysztof Kozlowski
2023-01-12 11:32 ` Krzysztof Kozlowski
2023-01-17 15:27 ` Ulf Hansson
2023-01-17 15:27 ` Ulf Hansson
2023-01-19 15:40 ` Krzysztof Kozlowski
2023-01-19 15:40 ` Krzysztof Kozlowski
2023-01-19 17:06 ` Krzysztof Kozlowski
2023-01-19 17:06 ` Krzysztof Kozlowski
2022-12-19 15:15 ` [PATCH v2 3/5] cpuidle: psci: Do not suspend topology CPUs on PREEMPT_RT Krzysztof Kozlowski
2022-12-19 15:15 ` Krzysztof Kozlowski
2023-01-12 11:09 ` Sebastian Andrzej Siewior
2023-01-12 11:09 ` Sebastian Andrzej Siewior
2023-01-12 11:34 ` Krzysztof Kozlowski
2023-01-12 11:34 ` Krzysztof Kozlowski
2023-01-30 9:51 ` Sebastian Andrzej Siewior
2023-01-30 9:51 ` Sebastian Andrzej Siewior
2022-12-19 15:15 ` [PATCH v2 4/5] PM: Allow calling dev_pm_domain_set() with raw spinlock Krzysztof Kozlowski
2022-12-19 15:15 ` Krzysztof Kozlowski
2023-01-12 11:13 ` Sebastian Andrzej Siewior [this message]
2023-01-12 11:13 ` Sebastian Andrzej Siewior
2022-12-19 15:15 ` [PATCH v2 5/5] PM: domains: Do not call device_pm_check_callbacks() when holding genpd_lock() Krzysztof Kozlowski
2022-12-19 15:15 ` Krzysztof Kozlowski
2023-01-12 11:31 ` Sebastian Andrzej Siewior
2023-01-12 11:31 ` Sebastian Andrzej Siewior
2023-01-12 11:37 ` Krzysztof Kozlowski
2023-01-12 11:37 ` Krzysztof Kozlowski
2023-01-17 15:11 ` Ulf Hansson
2023-01-17 15:11 ` Ulf Hansson
2023-01-19 15:58 ` Krzysztof Kozlowski
2023-01-19 15:58 ` Krzysztof Kozlowski
2022-12-20 21:36 ` [PATCH v2 0/5] PM: Fixes for Realtime systems Adrien Thierry
2022-12-20 21:36 ` Adrien Thierry
2023-01-04 15:15 ` Ulf Hansson
2023-01-04 15:15 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7/rUHCjPyNA0YNt@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=athierry@redhat.com \
--cc=bmasney@redhat.com \
--cc=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.