From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Cc: stable@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: retry to update the inode page given EIO
Date: Tue, 10 Jan 2023 17:20:59 -0800 [thread overview]
Message-ID: <Y74O+5SklijYqMU1@google.com> (raw)
In-Reply-To: <20230105233908.1030651-1-jaegeuk@kernel.org>
In f2fs_update_inode_page, f2fs_get_node_page handles EIO along with
f2fs_handle_page_eio that stops checkpoint, if the disk couldn't be recovered.
As a result, we don't need to stop checkpoint right away given single EIO.
Cc: stable@vger.kernel.org
Signed-off-by: Randall Huang <huangrandall@google.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
Change log from v1:
- fix a bug
fs/f2fs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
index ff6cf66ed46b..2ed7a621fdf1 100644
--- a/fs/f2fs/inode.c
+++ b/fs/f2fs/inode.c
@@ -719,7 +719,7 @@ void f2fs_update_inode_page(struct inode *inode)
if (IS_ERR(node_page)) {
int err = PTR_ERR(node_page);
- if (err == -ENOMEM) {
+ if (err == -ENOMEM || (err == -EIO && !f2fs_cp_error(sbi))) {
cond_resched();
goto retry;
} else if (err != -ENOENT) {
--
2.39.0.314.g84b9a713c41-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Cc: stable@vger.kernel.org, Randall Huang <huangrandall@google.com>
Subject: Re: [PATCH v2] f2fs: retry to update the inode page given EIO
Date: Tue, 10 Jan 2023 17:20:59 -0800 [thread overview]
Message-ID: <Y74O+5SklijYqMU1@google.com> (raw)
In-Reply-To: <20230105233908.1030651-1-jaegeuk@kernel.org>
In f2fs_update_inode_page, f2fs_get_node_page handles EIO along with
f2fs_handle_page_eio that stops checkpoint, if the disk couldn't be recovered.
As a result, we don't need to stop checkpoint right away given single EIO.
Cc: stable@vger.kernel.org
Signed-off-by: Randall Huang <huangrandall@google.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
Change log from v1:
- fix a bug
fs/f2fs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
index ff6cf66ed46b..2ed7a621fdf1 100644
--- a/fs/f2fs/inode.c
+++ b/fs/f2fs/inode.c
@@ -719,7 +719,7 @@ void f2fs_update_inode_page(struct inode *inode)
if (IS_ERR(node_page)) {
int err = PTR_ERR(node_page);
- if (err == -ENOMEM) {
+ if (err == -ENOMEM || (err == -EIO && !f2fs_cp_error(sbi))) {
cond_resched();
goto retry;
} else if (err != -ENOENT) {
--
2.39.0.314.g84b9a713c41-goog
next prev parent reply other threads:[~2023-01-11 1:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 23:39 [f2fs-dev] [PATCH] f2fs: retry to update the inode page given EIO Jaegeuk Kim
2023-01-05 23:39 ` Jaegeuk Kim
2023-01-11 1:20 ` Jaegeuk Kim [this message]
2023-01-11 1:20 ` [PATCH v2] " Jaegeuk Kim
2023-01-11 12:57 ` [f2fs-dev] " Chao Yu
2023-01-11 12:57 ` Chao Yu
2023-01-11 18:50 ` Jaegeuk Kim
2023-01-11 18:50 ` Jaegeuk Kim
2023-01-12 10:14 ` Chao Yu
2023-01-12 10:14 ` Chao Yu
2023-01-13 0:01 ` Jaegeuk Kim
2023-01-13 0:01 ` Jaegeuk Kim
2023-01-28 3:11 ` Chao Yu
2023-01-28 3:11 ` Chao Yu
2023-01-30 23:30 ` Jaegeuk Kim
2023-01-30 23:30 ` Jaegeuk Kim
2023-01-11 18:54 ` [f2fs-dev] [PATCH v3] " Jaegeuk Kim
2023-01-11 18:54 ` Jaegeuk Kim
2023-01-30 23:30 ` Jaegeuk Kim
2023-01-30 23:30 ` Jaegeuk Kim
2023-01-31 3:40 ` Chao Yu
2023-01-31 3:40 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y74O+5SklijYqMU1@google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.