All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Brian Norris" <briannorris@chromium.org>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Sean Paul" <seanpaul@chromium.org>,
	"Michel Dänzer" <michel.daenzer@mailbox.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Sandy Huang" <hjc@rock-chips.com>,
	linux-rockchip@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/atomic: Allow vblank-enabled + self-refresh "disable"
Date: Wed, 11 Jan 2023 17:03:30 +0200	[thread overview]
Message-ID: <Y77PwoqlfUS5JK7q@intel.com> (raw)
In-Reply-To: <Y7iFAJqGNXA7wHoK@phenom.ffwll.local>

On Fri, Jan 06, 2023 at 09:30:56PM +0100, Daniel Vetter wrote:
> On Fri, Jan 06, 2023 at 11:33:06AM -0800, Brian Norris wrote:
> > On Fri, Jan 06, 2023 at 07:17:53PM +0100, Daniel Vetter wrote:
> > > - fake vblanks with hrtimer, because on most hw when you turn off the crtc
> > >   the vblanks are also turned off, and so your compositor would still
> > >   hang. The vblank machinery already has all the code to make this happen
> > >   (and if it's not all, then i915 psr code should have it).
> > 
> > Is a timer better than an interrupt? I'm pretty sure the vblank
> > interrupts still can fire on Rockchip CRTC (VOP) (see also the other
> > branch of this thread), so this isn't really necessary. (IGT vblank
> > tests pass without hanging.) Unless you simply prefer a fake timer for
> > some reason.
> > 
> > Also, I still haven't found that fake timer machinery, but maybe I just
> > don't know what I'm looking for.
> 
> I ... didn't find it either. I'm honestly not sure whether this works for
> intel, or whether we do something silly like disable self-refresh when a
> vblank interrupt is pending :-/

Intel hardware doesn't enter PSR while the vblank interrupt is enabled.

-- 
Ville Syrjälä
Intel

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Brian Norris" <briannorris@chromium.org>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Sean Paul" <seanpaul@chromium.org>,
	"Michel Dänzer" <michel.daenzer@mailbox.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Sandy Huang" <hjc@rock-chips.com>,
	linux-rockchip@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/atomic: Allow vblank-enabled + self-refresh "disable"
Date: Wed, 11 Jan 2023 17:03:30 +0200	[thread overview]
Message-ID: <Y77PwoqlfUS5JK7q@intel.com> (raw)
In-Reply-To: <Y7iFAJqGNXA7wHoK@phenom.ffwll.local>

On Fri, Jan 06, 2023 at 09:30:56PM +0100, Daniel Vetter wrote:
> On Fri, Jan 06, 2023 at 11:33:06AM -0800, Brian Norris wrote:
> > On Fri, Jan 06, 2023 at 07:17:53PM +0100, Daniel Vetter wrote:
> > > - fake vblanks with hrtimer, because on most hw when you turn off the crtc
> > >   the vblanks are also turned off, and so your compositor would still
> > >   hang. The vblank machinery already has all the code to make this happen
> > >   (and if it's not all, then i915 psr code should have it).
> > 
> > Is a timer better than an interrupt? I'm pretty sure the vblank
> > interrupts still can fire on Rockchip CRTC (VOP) (see also the other
> > branch of this thread), so this isn't really necessary. (IGT vblank
> > tests pass without hanging.) Unless you simply prefer a fake timer for
> > some reason.
> > 
> > Also, I still haven't found that fake timer machinery, but maybe I just
> > don't know what I'm looking for.
> 
> I ... didn't find it either. I'm honestly not sure whether this works for
> intel, or whether we do something silly like disable self-refresh when a
> vblank interrupt is pending :-/

Intel hardware doesn't enter PSR while the vblank interrupt is enabled.

-- 
Ville Syrjälä
Intel

  parent reply	other threads:[~2023-01-11 15:05 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06  1:40 [PATCH 1/2] drm/atomic: Allow vblank-enabled + self-refresh "disable" Brian Norris
2023-01-06  1:40 ` Brian Norris
2023-01-06  1:40 ` Brian Norris
2023-01-06  1:40 ` [PATCH 2/2] drm/rockchip: vop: Leave vblank enabled in self-refresh Brian Norris
2023-01-06  1:40   ` Brian Norris
2023-01-06  1:40   ` Brian Norris
2023-01-06 11:42   ` Michel Dänzer
2023-01-06 11:42     ` Michel Dänzer
2023-01-07  1:21     ` Brian Norris
2023-01-07  1:21       ` Brian Norris
2023-01-07  1:21       ` Brian Norris
2023-01-06  7:04 ` [PATCH 1/2] drm/atomic: Allow vblank-enabled + self-refresh "disable" Greg KH
2023-01-06  7:04   ` Greg KH
2023-01-06  7:04   ` Greg KH
2023-01-06 17:49   ` Daniel Vetter
2023-01-06 17:49     ` Daniel Vetter
2023-01-06 17:49     ` Daniel Vetter
2023-01-06 17:53 ` Daniel Vetter
2023-01-06 17:53   ` Daniel Vetter
2023-01-06 17:53   ` Daniel Vetter
2023-01-06 18:08   ` Brian Norris
2023-01-06 18:08     ` Brian Norris
2023-01-06 18:20     ` Daniel Vetter
2023-01-06 18:20       ` Daniel Vetter
2023-01-06 18:20       ` Daniel Vetter
2023-01-06 19:25       ` Brian Norris
2023-01-06 19:25         ` Brian Norris
2023-01-06 18:17   ` Daniel Vetter
2023-01-06 18:17     ` Daniel Vetter
2023-01-06 19:33     ` Brian Norris
2023-01-06 19:33       ` Brian Norris
2023-01-06 20:30       ` Daniel Vetter
2023-01-06 20:30         ` Daniel Vetter
2023-01-06 20:30         ` Daniel Vetter
2023-01-06 21:30         ` Brian Norris
2023-01-06 21:30           ` Brian Norris
2023-01-06 22:44           ` Daniel Vetter
2023-01-06 22:44             ` Daniel Vetter
2023-01-06 22:44             ` Daniel Vetter
2023-01-11 15:03         ` Ville Syrjälä [this message]
2023-01-11 15:03           ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y77PwoqlfUS5JK7q@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=briannorris@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=michel.daenzer@mailbox.org \
    --cc=seanpaul@chromium.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.