From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Christoph Hellwig <hch@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Ard Biesheuvel <ardb@kernel.org>, Will Deacon <will@kernel.org>,
Marc Zyngier <maz@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
LinuxKernelMailingList@gondor.apana.org.au,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] crypto: sun8i-ss - Remove GFP_DMA and add DMA alignment padding
Date: Tue, 3 Jan 2023 07:51:24 +0100 [thread overview]
Message-ID: <Y7PQbNrgs2EvkXMB@Red> (raw)
In-Reply-To: <Y61WrVAjjtAMAvSh@gondor.apana.org.au>
Le Thu, Dec 29, 2022 at 04:58:21PM +0800, Herbert Xu a écrit :
> GFP_DMA does not guarantee that the returned memory is aligned
> for DMA. In fact for sun8i-ss it is superfluous and can be removed.
>
> However, kmalloc may start returning DMA-unaligned memory in future
> so fix this by adding the alignment by hand.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Hello
Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Tested-on: sun8i-a83t-bananapi-m3
Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
This means that lot of other crypto driver (sun8i-ce, amlogic, etc...) I maintain need the same fix, right ?
Regards
WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Christoph Hellwig <hch@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Ard Biesheuvel <ardb@kernel.org>, Will Deacon <will@kernel.org>,
Marc Zyngier <maz@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
LinuxKernelMailingList@gondor.apana.org.au,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] crypto: sun8i-ss - Remove GFP_DMA and add DMA alignment padding
Date: Tue, 3 Jan 2023 07:51:24 +0100 [thread overview]
Message-ID: <Y7PQbNrgs2EvkXMB@Red> (raw)
In-Reply-To: <Y61WrVAjjtAMAvSh@gondor.apana.org.au>
Le Thu, Dec 29, 2022 at 04:58:21PM +0800, Herbert Xu a écrit :
> GFP_DMA does not guarantee that the returned memory is aligned
> for DMA. In fact for sun8i-ss it is superfluous and can be removed.
>
> However, kmalloc may start returning DMA-unaligned memory in future
> so fix this by adding the alignment by hand.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Hello
Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Tested-on: sun8i-a83t-bananapi-m3
Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
This means that lot of other crypto driver (sun8i-ce, amlogic, etc...) I maintain need the same fix, right ?
Regards
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-03 6:51 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 9:19 [PATCH 0/10] crypto: Driver conversions for DMA alignment Herbert Xu
2022-12-02 9:19 ` Herbert Xu
2022-12-02 9:20 ` [PATCH 1/10] crypto: cavium - Set DMA alignment explicitly Herbert Xu
2022-12-02 9:20 ` Herbert Xu
2022-12-02 9:20 ` [PATCH 2/10] crypto: ccp " Herbert Xu
2022-12-02 9:20 ` Herbert Xu
2022-12-02 9:20 ` [PATCH 3/10] crypto: ccree " Herbert Xu
2022-12-02 9:20 ` Herbert Xu
2022-12-02 9:20 ` [PATCH 4/10] crypto: chelsio " Herbert Xu
2022-12-02 9:20 ` Herbert Xu
2022-12-02 9:20 ` [PATCH 5/10] crypto: hisilicon/hpre " Herbert Xu
2022-12-02 9:20 ` Herbert Xu
2022-12-02 9:20 ` [PATCH 6/10] crypto: safexcel " Herbert Xu
2022-12-02 9:20 ` Herbert Xu
2022-12-02 9:20 ` [PATCH 7/10] crypto: keembay " Herbert Xu
2022-12-02 9:20 ` Herbert Xu
2022-12-02 9:21 ` [PATCH 8/10] crypto: octeontx " Herbert Xu
2022-12-02 9:21 ` Herbert Xu
2022-12-02 9:21 ` [PATCH 9/10] crypto: octeontx2 " Herbert Xu
2022-12-02 9:21 ` Herbert Xu
2022-12-02 9:21 ` [PATCH 10/10] crypto: qce " Herbert Xu
2022-12-02 9:21 ` Herbert Xu
2022-12-02 9:49 ` [PATCH 0/10] crypto: Driver conversions for DMA alignment liulongfang
2022-12-02 9:49 ` liulongfang
2022-12-02 9:53 ` Herbert Xu
2022-12-02 9:53 ` Herbert Xu
2022-12-04 9:32 ` Christoph Hellwig
2022-12-04 9:32 ` Christoph Hellwig
2022-12-06 4:13 ` Herbert Xu
2022-12-06 4:13 ` Herbert Xu
2022-12-06 6:27 ` Christoph Hellwig
2022-12-06 6:27 ` Christoph Hellwig
2022-12-06 8:34 ` Herbert Xu
2022-12-06 8:34 ` Herbert Xu
2022-12-29 8:58 ` [PATCH] crypto: sun8i-ss - Remove GFP_DMA and add DMA alignment padding Herbert Xu
2022-12-29 8:58 ` Herbert Xu
2022-12-30 5:21 ` [PATCH] crypto: caam " Herbert Xu
2022-12-30 5:21 ` Herbert Xu
2022-12-30 7:31 ` [PATCH] crypto: talitos " Herbert Xu
2022-12-30 7:31 ` Herbert Xu
2023-01-08 17:37 ` Christoph Hellwig
2023-01-08 17:37 ` Christoph Hellwig
2023-01-09 7:18 ` Christophe Leroy
2023-01-09 7:18 ` Christophe Leroy
2023-01-09 7:37 ` Herbert Xu
2023-01-09 7:37 ` Herbert Xu
2023-01-08 17:36 ` [PATCH] crypto: caam " Christoph Hellwig
2023-01-08 17:36 ` Christoph Hellwig
[not found] ` <DU0PR04MB95635D72885111458C50DB6F8EA89@DU0PR04MB9563.eurprd04.prod.outlook.com>
2023-02-24 10:18 ` [PATCH] crypto: caam - Fix edesc/iv ordering mixup Herbert Xu
2023-02-27 5:20 ` Meenakshi Aggarwal
2023-02-27 8:25 ` [v2 PATCH] " Herbert Xu
2023-02-28 7:05 ` Meenakshi Aggarwal
2023-01-03 6:51 ` Corentin Labbe [this message]
2023-01-03 6:51 ` [PATCH] crypto: sun8i-ss - Remove GFP_DMA and add DMA alignment padding Corentin Labbe
2023-01-03 7:26 ` Herbert Xu
2023-01-03 7:26 ` Herbert Xu
2023-01-08 17:36 ` Christoph Hellwig
2023-01-08 17:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7PQbNrgs2EvkXMB@Red \
--to=clabbe.montjoie@gmail.com \
--cc=LinuxKernelMailingList@gondor.apana.org.au \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maz@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.