From: Lee Jones <lee@kernel.org>
To: Aren Moynihan <aren@peacevolution.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org, Ondrej Jirman <megi@xff.cz>,
Samuel Holland <samuel@sholland.org>
Subject: Re: [PATCH v2] mfd: axp20x: fix order of pek rise and fall events
Date: Tue, 3 Jan 2023 12:20:52 +0000 [thread overview]
Message-ID: <Y7QdpAgutLYM4BrX@google.com> (raw)
In-Reply-To: <20221208220225.635414-1-aren@peacevolution.org>
On Thu, 08 Dec 2022, Aren Moynihan wrote:
> The power button can get "stuck" if the rising edge and falling edge irq
> are read in the same pass. This can often be triggered when resuming
> from suspend if the power button is released before the kernel handles
> the interrupt.
>
> Swapping the order of the rise and fall events makes sure that the press
> event is handled first, which prevents this situation.
>
> Signed-off-by: Aren Moynihan <aren@peacevolution.org>
> ---
> changes in v2:
> - add comments describing the reason these are out of bit order
>
> previous version:
> https://lore.kernel.org/lkml/20221123230741.2430813-1-aren@peacevolution.org/T/
>
> include/linux/mfd/axp20x.h | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-01-03 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 22:02 [PATCH v2] mfd: axp20x: fix order of pek rise and fall events Aren Moynihan
2022-12-09 7:49 ` Chen-Yu Tsai
2022-12-28 3:56 ` Samuel Holland
2023-01-03 12:20 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7QdpAgutLYM4BrX@google.com \
--to=lee@kernel.org \
--cc=aren@peacevolution.org \
--cc=linux-kernel@vger.kernel.org \
--cc=megi@xff.cz \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.