* [Intel-gfx] [PATCH v4 0/1] drm/i915/dmc: Make firmware loading backwards-compatible
@ 2022-12-30 18:24 Gustavo Sousa
2022-12-30 18:24 ` [Intel-gfx] [PATCH v4 1/1] drm/i915/dmc: Do not require specific versions Gustavo Sousa
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Gustavo Sousa @ 2022-12-30 18:24 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Lucas De Marchi, Rodrigo Vivi
This patch series changes DMC loading to be partially backwards-compatible by
removing version checking. Future patches in linux-firmware should start using
unversioned filenames and we will gradually adapt i915 to use them.
For platforms already supported, the change to unversioned paths will require a
fallback mechanism (alternatively load from versioned paths) to avoid
regression. Let's do that when the time comes.
This version differs from v3 in that we are postponing reorganization of macros
and implementation of the fallback mechanism to when we need it.
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
Gustavo Sousa (1):
drm/i915/dmc: Do not require specific versions
drivers/gpu/drm/i915/display/intel_dmc.c | 35 ------------------------
drivers/gpu/drm/i915/display/intel_dmc.h | 1 -
2 files changed, 36 deletions(-)
--
2.39.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH v4 1/1] drm/i915/dmc: Do not require specific versions
2022-12-30 18:24 [Intel-gfx] [PATCH v4 0/1] drm/i915/dmc: Make firmware loading backwards-compatible Gustavo Sousa
@ 2022-12-30 18:24 ` Gustavo Sousa
2023-01-03 16:34 ` Rodrigo Vivi
2022-12-30 18:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dmc: Make firmware loading backwards-compatible (rev4) Patchwork
` (3 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Gustavo Sousa @ 2022-12-30 18:24 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Lucas De Marchi, Rodrigo Vivi
Currently, i915 interacts with the Hardware and not with any DMC
ABI/API, so the API is fixed within the platform, hence no need to get
this so-tied version requirement.
v2:
- Use link to firmware guide from kernel documentation for
"References:" instead of mailing list thread. (Rodrigo)
- Provide a more elaborate justification in the commit message.
(Rodrigo)
References: https://www.kernel.org/doc/html/v6.1/driver-api/firmware/firmware-usage-guidelines.html
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/display/intel_dmc.c | 35 ------------------------
drivers/gpu/drm/i915/display/intel_dmc.h | 1 -
2 files changed, 36 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index 905b5dcdca14..4124b3d37110 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -53,51 +53,40 @@
#define DISPLAY_VER12_DMC_MAX_FW_SIZE ICL_DMC_MAX_FW_SIZE
#define DG2_DMC_PATH DMC_PATH(dg2, 2, 08)
-#define DG2_DMC_VERSION_REQUIRED DMC_VERSION(2, 8)
MODULE_FIRMWARE(DG2_DMC_PATH);
#define ADLP_DMC_PATH DMC_PATH(adlp, 2, 16)
-#define ADLP_DMC_VERSION_REQUIRED DMC_VERSION(2, 16)
MODULE_FIRMWARE(ADLP_DMC_PATH);
#define ADLS_DMC_PATH DMC_PATH(adls, 2, 01)
-#define ADLS_DMC_VERSION_REQUIRED DMC_VERSION(2, 1)
MODULE_FIRMWARE(ADLS_DMC_PATH);
#define DG1_DMC_PATH DMC_PATH(dg1, 2, 02)
-#define DG1_DMC_VERSION_REQUIRED DMC_VERSION(2, 2)
MODULE_FIRMWARE(DG1_DMC_PATH);
#define RKL_DMC_PATH DMC_PATH(rkl, 2, 03)
-#define RKL_DMC_VERSION_REQUIRED DMC_VERSION(2, 3)
MODULE_FIRMWARE(RKL_DMC_PATH);
#define TGL_DMC_PATH DMC_PATH(tgl, 2, 12)
-#define TGL_DMC_VERSION_REQUIRED DMC_VERSION(2, 12)
MODULE_FIRMWARE(TGL_DMC_PATH);
#define ICL_DMC_PATH DMC_PATH(icl, 1, 09)
-#define ICL_DMC_VERSION_REQUIRED DMC_VERSION(1, 9)
#define ICL_DMC_MAX_FW_SIZE 0x6000
MODULE_FIRMWARE(ICL_DMC_PATH);
#define GLK_DMC_PATH DMC_PATH(glk, 1, 04)
-#define GLK_DMC_VERSION_REQUIRED DMC_VERSION(1, 4)
#define GLK_DMC_MAX_FW_SIZE 0x4000
MODULE_FIRMWARE(GLK_DMC_PATH);
#define KBL_DMC_PATH DMC_PATH(kbl, 1, 04)
-#define KBL_DMC_VERSION_REQUIRED DMC_VERSION(1, 4)
#define KBL_DMC_MAX_FW_SIZE BXT_DMC_MAX_FW_SIZE
MODULE_FIRMWARE(KBL_DMC_PATH);
#define SKL_DMC_PATH DMC_PATH(skl, 1, 27)
-#define SKL_DMC_VERSION_REQUIRED DMC_VERSION(1, 27)
#define SKL_DMC_MAX_FW_SIZE BXT_DMC_MAX_FW_SIZE
MODULE_FIRMWARE(SKL_DMC_PATH);
#define BXT_DMC_PATH DMC_PATH(bxt, 1, 07)
-#define BXT_DMC_VERSION_REQUIRED DMC_VERSION(1, 7)
#define BXT_DMC_MAX_FW_SIZE 0x3000
MODULE_FIRMWARE(BXT_DMC_PATH);
@@ -765,17 +754,6 @@ static u32 parse_dmc_fw_css(struct intel_dmc *dmc,
return 0;
}
- if (dmc->required_version &&
- css_header->version != dmc->required_version) {
- drm_info(&i915->drm, "Refusing to load DMC firmware v%u.%u,"
- " please use v%u.%u\n",
- DMC_VERSION_MAJOR(css_header->version),
- DMC_VERSION_MINOR(css_header->version),
- DMC_VERSION_MAJOR(dmc->required_version),
- DMC_VERSION_MINOR(dmc->required_version));
- return 0;
- }
-
dmc->version = css_header->version;
return sizeof(struct intel_css_header);
@@ -903,49 +881,38 @@ void intel_dmc_ucode_init(struct drm_i915_private *dev_priv)
if (IS_DG2(dev_priv)) {
dmc->fw_path = DG2_DMC_PATH;
- dmc->required_version = DG2_DMC_VERSION_REQUIRED;
dmc->max_fw_size = DISPLAY_VER13_DMC_MAX_FW_SIZE;
} else if (IS_ALDERLAKE_P(dev_priv)) {
dmc->fw_path = ADLP_DMC_PATH;
- dmc->required_version = ADLP_DMC_VERSION_REQUIRED;
dmc->max_fw_size = DISPLAY_VER13_DMC_MAX_FW_SIZE;
} else if (IS_ALDERLAKE_S(dev_priv)) {
dmc->fw_path = ADLS_DMC_PATH;
- dmc->required_version = ADLS_DMC_VERSION_REQUIRED;
dmc->max_fw_size = DISPLAY_VER12_DMC_MAX_FW_SIZE;
} else if (IS_DG1(dev_priv)) {
dmc->fw_path = DG1_DMC_PATH;
- dmc->required_version = DG1_DMC_VERSION_REQUIRED;
dmc->max_fw_size = DISPLAY_VER12_DMC_MAX_FW_SIZE;
} else if (IS_ROCKETLAKE(dev_priv)) {
dmc->fw_path = RKL_DMC_PATH;
- dmc->required_version = RKL_DMC_VERSION_REQUIRED;
dmc->max_fw_size = DISPLAY_VER12_DMC_MAX_FW_SIZE;
} else if (IS_TIGERLAKE(dev_priv)) {
dmc->fw_path = TGL_DMC_PATH;
- dmc->required_version = TGL_DMC_VERSION_REQUIRED;
dmc->max_fw_size = DISPLAY_VER12_DMC_MAX_FW_SIZE;
} else if (DISPLAY_VER(dev_priv) == 11) {
dmc->fw_path = ICL_DMC_PATH;
- dmc->required_version = ICL_DMC_VERSION_REQUIRED;
dmc->max_fw_size = ICL_DMC_MAX_FW_SIZE;
} else if (IS_GEMINILAKE(dev_priv)) {
dmc->fw_path = GLK_DMC_PATH;
- dmc->required_version = GLK_DMC_VERSION_REQUIRED;
dmc->max_fw_size = GLK_DMC_MAX_FW_SIZE;
} else if (IS_KABYLAKE(dev_priv) ||
IS_COFFEELAKE(dev_priv) ||
IS_COMETLAKE(dev_priv)) {
dmc->fw_path = KBL_DMC_PATH;
- dmc->required_version = KBL_DMC_VERSION_REQUIRED;
dmc->max_fw_size = KBL_DMC_MAX_FW_SIZE;
} else if (IS_SKYLAKE(dev_priv)) {
dmc->fw_path = SKL_DMC_PATH;
- dmc->required_version = SKL_DMC_VERSION_REQUIRED;
dmc->max_fw_size = SKL_DMC_MAX_FW_SIZE;
} else if (IS_BROXTON(dev_priv)) {
dmc->fw_path = BXT_DMC_PATH;
- dmc->required_version = BXT_DMC_VERSION_REQUIRED;
dmc->max_fw_size = BXT_DMC_MAX_FW_SIZE;
}
@@ -958,8 +925,6 @@ void intel_dmc_ucode_init(struct drm_i915_private *dev_priv)
}
dmc->fw_path = dev_priv->params.dmc_firmware_path;
- /* Bypass version check for firmware override. */
- dmc->required_version = 0;
}
if (!dmc->fw_path) {
diff --git a/drivers/gpu/drm/i915/display/intel_dmc.h b/drivers/gpu/drm/i915/display/intel_dmc.h
index 67e03315ef99..435eab9b016b 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.h
+++ b/drivers/gpu/drm/i915/display/intel_dmc.h
@@ -25,7 +25,6 @@ enum {
struct intel_dmc {
struct work_struct work;
const char *fw_path;
- u32 required_version;
u32 max_fw_size; /* bytes */
u32 version;
struct dmc_fw_info {
--
2.39.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dmc: Make firmware loading backwards-compatible (rev4)
2022-12-30 18:24 [Intel-gfx] [PATCH v4 0/1] drm/i915/dmc: Make firmware loading backwards-compatible Gustavo Sousa
2022-12-30 18:24 ` [Intel-gfx] [PATCH v4 1/1] drm/i915/dmc: Do not require specific versions Gustavo Sousa
@ 2022-12-30 18:41 ` Patchwork
2022-12-30 18:41 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-12-30 18:41 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dmc: Make firmware loading backwards-compatible (rev4)
URL : https://patchwork.freedesktop.org/series/112116/
State : warning
== Summary ==
Error: dim checkpatch failed
deef1f7547b3 drm/i915/dmc: Do not require specific versions
-:16: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#16:
References: https://www.kernel.org/doc/html/v6.1/driver-api/firmware/firmware-usage-guidelines.html
total: 0 errors, 1 warnings, 0 checks, 132 lines checked
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dmc: Make firmware loading backwards-compatible (rev4)
2022-12-30 18:24 [Intel-gfx] [PATCH v4 0/1] drm/i915/dmc: Make firmware loading backwards-compatible Gustavo Sousa
2022-12-30 18:24 ` [Intel-gfx] [PATCH v4 1/1] drm/i915/dmc: Do not require specific versions Gustavo Sousa
2022-12-30 18:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dmc: Make firmware loading backwards-compatible (rev4) Patchwork
@ 2022-12-30 18:41 ` Patchwork
2022-12-30 18:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-12-30 21:03 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-12-30 18:41 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dmc: Make firmware loading backwards-compatible (rev4)
URL : https://patchwork.freedesktop.org/series/112116/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Make firmware loading backwards-compatible (rev4)
2022-12-30 18:24 [Intel-gfx] [PATCH v4 0/1] drm/i915/dmc: Make firmware loading backwards-compatible Gustavo Sousa
` (2 preceding siblings ...)
2022-12-30 18:41 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2022-12-30 18:56 ` Patchwork
2022-12-30 21:03 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-12-30 18:56 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4805 bytes --]
== Series Details ==
Series: drm/i915/dmc: Make firmware loading backwards-compatible (rev4)
URL : https://patchwork.freedesktop.org/series/112116/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12532 -> Patchwork_112116v4
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/index.html
Participating hosts (44 -> 43)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_112116v4 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-rte:
- bat-adlp-4: [PASS][1] -> [DMESG-WARN][2] ([i915#7077])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/bat-adlp-4/igt@i915_pm_rpm@basic-rte.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/bat-adlp-4/igt@i915_pm_rpm@basic-rte.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#111827])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@runner@aborted:
- bat-adlp-4: NOTRUN -> [FAIL][4] ([i915#4312])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/bat-adlp-4/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [FAIL][5] ([i915#7229]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][7] ([i915#4785]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
- fi-adl-ddr5: [DMESG-WARN][9] ([i915#5591]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/fi-adl-ddr5/igt@i915_selftest@live@hangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/fi-adl-ddr5/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- {bat-rpls-1}: [INCOMPLETE][11] ([i915#6257]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/bat-rpls-1/igt@i915_selftest@live@requests.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [DMESG-FAIL][13] ([i915#4983]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/bat-rpls-2/igt@i915_selftest@live@reset.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/bat-rpls-2/igt@i915_selftest@live@reset.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7336]: https://gitlab.freedesktop.org/drm/intel/issues/7336
Build changes
-------------
* Linux: CI_DRM_12532 -> Patchwork_112116v4
CI-20190529: 20190529
CI_DRM_12532: 91195847031b60062eb046b8bb0c9e64a2291e10 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7104: fe5def13049225967770eaaf19ec01ef80e2adc5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_112116v4: 91195847031b60062eb046b8bb0c9e64a2291e10 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
973c0ab43091 drm/i915/dmc: Do not require specific versions
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/index.html
[-- Attachment #2: Type: text/html, Size: 5265 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dmc: Make firmware loading backwards-compatible (rev4)
2022-12-30 18:24 [Intel-gfx] [PATCH v4 0/1] drm/i915/dmc: Make firmware loading backwards-compatible Gustavo Sousa
` (3 preceding siblings ...)
2022-12-30 18:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-12-30 21:03 ` Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-12-30 21:03 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 19213 bytes --]
== Series Details ==
Series: drm/i915/dmc: Make firmware loading backwards-compatible (rev4)
URL : https://patchwork.freedesktop.org/series/112116/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12532_full -> Patchwork_112116v4_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/index.html
Participating hosts (14 -> 10)
------------------------------
Missing (4): shard-rkl0 pig-kbl-iris pig-glk-j5005 pig-skl-6260u
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_112116v4_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}: [PASS][1] -> [FAIL][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-rkl-5/igt@drm_fdinfo@virtual-idle.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-rkl-4/igt@drm_fdinfo@virtual-idle.html
* igt@fbdev@read:
- {shard-tglu}: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-tglu-8/igt@fbdev@read.html
* igt@kms_cursor_crc@cursor-sliding-64x64:
- {shard-rkl}: [SKIP][4] ([i915#4098]) -> [SKIP][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-rkl-1/igt@kms_cursor_crc@cursor-sliding-64x64.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-rkl-5/igt@kms_cursor_crc@cursor-sliding-64x64.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-75:
- {shard-rkl}: [SKIP][6] ([i915#3555] / [i915#4098]) -> [SKIP][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-rkl-1/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-75.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-rkl-5/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-75.html
New tests
---------
New tests have been introduced between CI_DRM_12532_full and Patchwork_112116v4_full:
### New IGT tests (1) ###
* igt@gem_render_copy@yf-tiled-ccs-to-x-tiled@lmem0:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_112116v4_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_whisper@basic-queues-forked-all:
- shard-glk: [PASS][8] -> [DMESG-WARN][9] ([i915#118])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-glk8/igt@gem_exec_whisper@basic-queues-forked-all.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-glk3/igt@gem_exec_whisper@basic-queues-forked-all.html
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#79]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-glk1/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-glk9/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
#### Possible fixes ####
* igt@fbdev@unaligned-read:
- {shard-rkl}: [SKIP][12] ([i915#2582]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-rkl-3/igt@fbdev@unaligned-read.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-rkl-6/igt@fbdev@unaligned-read.html
* igt@gem_ctx_persistence@hang:
- {shard-rkl}: [SKIP][14] ([i915#6252]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-rkl-5/igt@gem_ctx_persistence@hang.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-rkl-4/igt@gem_ctx_persistence@hang.html
* igt@gem_eio@in-flight-suspend:
- {shard-rkl}: [FAIL][16] ([fdo#103375]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-rkl-4/igt@gem_eio@in-flight-suspend.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-rkl-1/igt@gem_eio@in-flight-suspend.html
* igt@gem_eio@unwedge-stress:
- {shard-dg1}: [FAIL][18] ([i915#5784]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-dg1-17/igt@gem_eio@unwedge-stress.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-dg1-18/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][20] ([i915#2842]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_reloc@basic-write-read-active:
- {shard-rkl}: [SKIP][22] ([i915#3281]) -> [PASS][23] +7 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-rkl-1/igt@gem_exec_reloc@basic-write-read-active.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-rkl-5/igt@gem_exec_reloc@basic-write-read-active.html
* igt@gen9_exec_parse@shadow-peek:
- {shard-rkl}: [SKIP][24] ([i915#2527]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-rkl-1/igt@gen9_exec_parse@shadow-peek.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-rkl-5/igt@gen9_exec_parse@shadow-peek.html
* igt@i915_pm_dc@dc6-dpms:
- {shard-tglu}: [FAIL][26] ([i915#3989] / [i915#454]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-tglu-7/igt@i915_pm_dc@dc6-dpms.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-tglu-4/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_dc@dc9-dpms:
- {shard-rkl}: [SKIP][28] ([i915#3361]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-rkl-5/igt@i915_pm_dc@dc9-dpms.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-rkl-1/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- {shard-dg1}: [SKIP][30] ([i915#1937]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-dg1-15/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-dg1-14/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-dg1}: [FAIL][32] ([i915#3591]) -> [PASS][33] +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-dg1-16/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@i915_pm_rpm@dpms-lpsp:
- {shard-rkl}: [SKIP][34] ([i915#1397]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-rkl-3/igt@i915_pm_rpm@dpms-lpsp.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-rkl-6/igt@i915_pm_rpm@dpms-lpsp.html
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-dg1}: [SKIP][36] ([i915#1397]) -> [PASS][37] +3 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-dg1-13/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-dg1-14/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-pwrite:
- {shard-rkl}: [SKIP][38] ([i915#1849] / [i915#4098]) -> [PASS][39] +5 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-rkl-3/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-pwrite.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-pwrite.html
* igt@kms_plane@pixel-format-source-clamping@pipe-b-planes:
- {shard-rkl}: [SKIP][40] ([i915#3558]) -> [PASS][41] +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-rkl-3/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-rkl-6/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
* igt@kms_rotation_crc@primary-rotation-90:
- {shard-rkl}: [SKIP][42] ([i915#1845] / [i915#4098]) -> [PASS][43] +8 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-rkl-3/igt@kms_rotation_crc@primary-rotation-90.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-rkl-6/igt@kms_rotation_crc@primary-rotation-90.html
* igt@perf_pmu@busy-double-start@vecs0:
- {shard-dg1}: [FAIL][44] -> [PASS][45] +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12532/shard-dg1-17/igt@perf_pmu@busy-double-start@vecs0.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/shard-dg1-13/igt@perf_pmu@busy-double-start@vecs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4778]: https://gitlab.freedesktop.org/drm/intel/issues/4778
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6914]: https://gitlab.freedesktop.org/drm/intel/issues/6914
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12532 -> Patchwork_112116v4
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12532: 91195847031b60062eb046b8bb0c9e64a2291e10 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7104: fe5def13049225967770eaaf19ec01ef80e2adc5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_112116v4: 91195847031b60062eb046b8bb0c9e64a2291e10 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112116v4/index.html
[-- Attachment #2: Type: text/html, Size: 13041 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v4 1/1] drm/i915/dmc: Do not require specific versions
2022-12-30 18:24 ` [Intel-gfx] [PATCH v4 1/1] drm/i915/dmc: Do not require specific versions Gustavo Sousa
@ 2023-01-03 16:34 ` Rodrigo Vivi
2023-01-03 16:57 ` Gustavo Sousa
0 siblings, 1 reply; 8+ messages in thread
From: Rodrigo Vivi @ 2023-01-03 16:34 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: Jani Nikula, intel-gfx, Lucas De Marchi
On Fri, Dec 30, 2022 at 03:24:22PM -0300, Gustavo Sousa wrote:
> Currently, i915 interacts with the Hardware and not with any DMC
> ABI/API, so the API is fixed within the platform, hence no need to get
> this so-tied version requirement.
>
> v2:
> - Use link to firmware guide from kernel documentation for
> "References:" instead of mailing list thread. (Rodrigo)
> - Provide a more elaborate justification in the commit message.
> (Rodrigo)
>
> References: https://www.kernel.org/doc/html/v6.1/driver-api/firmware/firmware-usage-guidelines.html
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
and I'm going to push this right now...
but btw for a next time:
there's no need for cover letter in single standalone patches ;)
Thanks for the patch,
Rodrigo.
> ---
> drivers/gpu/drm/i915/display/intel_dmc.c | 35 ------------------------
> drivers/gpu/drm/i915/display/intel_dmc.h | 1 -
> 2 files changed, 36 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
> index 905b5dcdca14..4124b3d37110 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> @@ -53,51 +53,40 @@
> #define DISPLAY_VER12_DMC_MAX_FW_SIZE ICL_DMC_MAX_FW_SIZE
>
> #define DG2_DMC_PATH DMC_PATH(dg2, 2, 08)
> -#define DG2_DMC_VERSION_REQUIRED DMC_VERSION(2, 8)
> MODULE_FIRMWARE(DG2_DMC_PATH);
>
> #define ADLP_DMC_PATH DMC_PATH(adlp, 2, 16)
> -#define ADLP_DMC_VERSION_REQUIRED DMC_VERSION(2, 16)
> MODULE_FIRMWARE(ADLP_DMC_PATH);
>
> #define ADLS_DMC_PATH DMC_PATH(adls, 2, 01)
> -#define ADLS_DMC_VERSION_REQUIRED DMC_VERSION(2, 1)
> MODULE_FIRMWARE(ADLS_DMC_PATH);
>
> #define DG1_DMC_PATH DMC_PATH(dg1, 2, 02)
> -#define DG1_DMC_VERSION_REQUIRED DMC_VERSION(2, 2)
> MODULE_FIRMWARE(DG1_DMC_PATH);
>
> #define RKL_DMC_PATH DMC_PATH(rkl, 2, 03)
> -#define RKL_DMC_VERSION_REQUIRED DMC_VERSION(2, 3)
> MODULE_FIRMWARE(RKL_DMC_PATH);
>
> #define TGL_DMC_PATH DMC_PATH(tgl, 2, 12)
> -#define TGL_DMC_VERSION_REQUIRED DMC_VERSION(2, 12)
> MODULE_FIRMWARE(TGL_DMC_PATH);
>
> #define ICL_DMC_PATH DMC_PATH(icl, 1, 09)
> -#define ICL_DMC_VERSION_REQUIRED DMC_VERSION(1, 9)
> #define ICL_DMC_MAX_FW_SIZE 0x6000
> MODULE_FIRMWARE(ICL_DMC_PATH);
>
> #define GLK_DMC_PATH DMC_PATH(glk, 1, 04)
> -#define GLK_DMC_VERSION_REQUIRED DMC_VERSION(1, 4)
> #define GLK_DMC_MAX_FW_SIZE 0x4000
> MODULE_FIRMWARE(GLK_DMC_PATH);
>
> #define KBL_DMC_PATH DMC_PATH(kbl, 1, 04)
> -#define KBL_DMC_VERSION_REQUIRED DMC_VERSION(1, 4)
> #define KBL_DMC_MAX_FW_SIZE BXT_DMC_MAX_FW_SIZE
> MODULE_FIRMWARE(KBL_DMC_PATH);
>
> #define SKL_DMC_PATH DMC_PATH(skl, 1, 27)
> -#define SKL_DMC_VERSION_REQUIRED DMC_VERSION(1, 27)
> #define SKL_DMC_MAX_FW_SIZE BXT_DMC_MAX_FW_SIZE
> MODULE_FIRMWARE(SKL_DMC_PATH);
>
> #define BXT_DMC_PATH DMC_PATH(bxt, 1, 07)
> -#define BXT_DMC_VERSION_REQUIRED DMC_VERSION(1, 7)
> #define BXT_DMC_MAX_FW_SIZE 0x3000
> MODULE_FIRMWARE(BXT_DMC_PATH);
>
> @@ -765,17 +754,6 @@ static u32 parse_dmc_fw_css(struct intel_dmc *dmc,
> return 0;
> }
>
> - if (dmc->required_version &&
> - css_header->version != dmc->required_version) {
> - drm_info(&i915->drm, "Refusing to load DMC firmware v%u.%u,"
> - " please use v%u.%u\n",
> - DMC_VERSION_MAJOR(css_header->version),
> - DMC_VERSION_MINOR(css_header->version),
> - DMC_VERSION_MAJOR(dmc->required_version),
> - DMC_VERSION_MINOR(dmc->required_version));
> - return 0;
> - }
> -
> dmc->version = css_header->version;
>
> return sizeof(struct intel_css_header);
> @@ -903,49 +881,38 @@ void intel_dmc_ucode_init(struct drm_i915_private *dev_priv)
>
> if (IS_DG2(dev_priv)) {
> dmc->fw_path = DG2_DMC_PATH;
> - dmc->required_version = DG2_DMC_VERSION_REQUIRED;
> dmc->max_fw_size = DISPLAY_VER13_DMC_MAX_FW_SIZE;
> } else if (IS_ALDERLAKE_P(dev_priv)) {
> dmc->fw_path = ADLP_DMC_PATH;
> - dmc->required_version = ADLP_DMC_VERSION_REQUIRED;
> dmc->max_fw_size = DISPLAY_VER13_DMC_MAX_FW_SIZE;
> } else if (IS_ALDERLAKE_S(dev_priv)) {
> dmc->fw_path = ADLS_DMC_PATH;
> - dmc->required_version = ADLS_DMC_VERSION_REQUIRED;
> dmc->max_fw_size = DISPLAY_VER12_DMC_MAX_FW_SIZE;
> } else if (IS_DG1(dev_priv)) {
> dmc->fw_path = DG1_DMC_PATH;
> - dmc->required_version = DG1_DMC_VERSION_REQUIRED;
> dmc->max_fw_size = DISPLAY_VER12_DMC_MAX_FW_SIZE;
> } else if (IS_ROCKETLAKE(dev_priv)) {
> dmc->fw_path = RKL_DMC_PATH;
> - dmc->required_version = RKL_DMC_VERSION_REQUIRED;
> dmc->max_fw_size = DISPLAY_VER12_DMC_MAX_FW_SIZE;
> } else if (IS_TIGERLAKE(dev_priv)) {
> dmc->fw_path = TGL_DMC_PATH;
> - dmc->required_version = TGL_DMC_VERSION_REQUIRED;
> dmc->max_fw_size = DISPLAY_VER12_DMC_MAX_FW_SIZE;
> } else if (DISPLAY_VER(dev_priv) == 11) {
> dmc->fw_path = ICL_DMC_PATH;
> - dmc->required_version = ICL_DMC_VERSION_REQUIRED;
> dmc->max_fw_size = ICL_DMC_MAX_FW_SIZE;
> } else if (IS_GEMINILAKE(dev_priv)) {
> dmc->fw_path = GLK_DMC_PATH;
> - dmc->required_version = GLK_DMC_VERSION_REQUIRED;
> dmc->max_fw_size = GLK_DMC_MAX_FW_SIZE;
> } else if (IS_KABYLAKE(dev_priv) ||
> IS_COFFEELAKE(dev_priv) ||
> IS_COMETLAKE(dev_priv)) {
> dmc->fw_path = KBL_DMC_PATH;
> - dmc->required_version = KBL_DMC_VERSION_REQUIRED;
> dmc->max_fw_size = KBL_DMC_MAX_FW_SIZE;
> } else if (IS_SKYLAKE(dev_priv)) {
> dmc->fw_path = SKL_DMC_PATH;
> - dmc->required_version = SKL_DMC_VERSION_REQUIRED;
> dmc->max_fw_size = SKL_DMC_MAX_FW_SIZE;
> } else if (IS_BROXTON(dev_priv)) {
> dmc->fw_path = BXT_DMC_PATH;
> - dmc->required_version = BXT_DMC_VERSION_REQUIRED;
> dmc->max_fw_size = BXT_DMC_MAX_FW_SIZE;
> }
>
> @@ -958,8 +925,6 @@ void intel_dmc_ucode_init(struct drm_i915_private *dev_priv)
> }
>
> dmc->fw_path = dev_priv->params.dmc_firmware_path;
> - /* Bypass version check for firmware override. */
> - dmc->required_version = 0;
> }
>
> if (!dmc->fw_path) {
> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.h b/drivers/gpu/drm/i915/display/intel_dmc.h
> index 67e03315ef99..435eab9b016b 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc.h
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.h
> @@ -25,7 +25,6 @@ enum {
> struct intel_dmc {
> struct work_struct work;
> const char *fw_path;
> - u32 required_version;
> u32 max_fw_size; /* bytes */
> u32 version;
> struct dmc_fw_info {
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v4 1/1] drm/i915/dmc: Do not require specific versions
2023-01-03 16:34 ` Rodrigo Vivi
@ 2023-01-03 16:57 ` Gustavo Sousa
0 siblings, 0 replies; 8+ messages in thread
From: Gustavo Sousa @ 2023-01-03 16:57 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: Jani Nikula, intel-gfx, Lucas De Marchi
On Tue, Jan 03, 2023 at 11:34:23AM -0500, Rodrigo Vivi wrote:
> On Fri, Dec 30, 2022 at 03:24:22PM -0300, Gustavo Sousa wrote:
> > Currently, i915 interacts with the Hardware and not with any DMC
> > ABI/API, so the API is fixed within the platform, hence no need to get
> > this so-tied version requirement.
> >
> > v2:
> > - Use link to firmware guide from kernel documentation for
> > "References:" instead of mailing list thread. (Rodrigo)
> > - Provide a more elaborate justification in the commit message.
> > (Rodrigo)
> >
> > References: https://www.kernel.org/doc/html/v6.1/driver-api/firmware/firmware-usage-guidelines.html
> > Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> and I'm going to push this right now...
Thanks for the review!
>
> but btw for a next time:
> there's no need for cover letter in single standalone patches ;)
Thanks. Yeah... I wanted to keep the history in patchwork and I assumed it does
some type of matching with the thread subject.
--
Gustavo Sousa
>
> Thanks for the patch,
> Rodrigo.
>
> > ---
> > drivers/gpu/drm/i915/display/intel_dmc.c | 35 ------------------------
> > drivers/gpu/drm/i915/display/intel_dmc.h | 1 -
> > 2 files changed, 36 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
> > index 905b5dcdca14..4124b3d37110 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> > @@ -53,51 +53,40 @@
> > #define DISPLAY_VER12_DMC_MAX_FW_SIZE ICL_DMC_MAX_FW_SIZE
> >
> > #define DG2_DMC_PATH DMC_PATH(dg2, 2, 08)
> > -#define DG2_DMC_VERSION_REQUIRED DMC_VERSION(2, 8)
> > MODULE_FIRMWARE(DG2_DMC_PATH);
> >
> > #define ADLP_DMC_PATH DMC_PATH(adlp, 2, 16)
> > -#define ADLP_DMC_VERSION_REQUIRED DMC_VERSION(2, 16)
> > MODULE_FIRMWARE(ADLP_DMC_PATH);
> >
> > #define ADLS_DMC_PATH DMC_PATH(adls, 2, 01)
> > -#define ADLS_DMC_VERSION_REQUIRED DMC_VERSION(2, 1)
> > MODULE_FIRMWARE(ADLS_DMC_PATH);
> >
> > #define DG1_DMC_PATH DMC_PATH(dg1, 2, 02)
> > -#define DG1_DMC_VERSION_REQUIRED DMC_VERSION(2, 2)
> > MODULE_FIRMWARE(DG1_DMC_PATH);
> >
> > #define RKL_DMC_PATH DMC_PATH(rkl, 2, 03)
> > -#define RKL_DMC_VERSION_REQUIRED DMC_VERSION(2, 3)
> > MODULE_FIRMWARE(RKL_DMC_PATH);
> >
> > #define TGL_DMC_PATH DMC_PATH(tgl, 2, 12)
> > -#define TGL_DMC_VERSION_REQUIRED DMC_VERSION(2, 12)
> > MODULE_FIRMWARE(TGL_DMC_PATH);
> >
> > #define ICL_DMC_PATH DMC_PATH(icl, 1, 09)
> > -#define ICL_DMC_VERSION_REQUIRED DMC_VERSION(1, 9)
> > #define ICL_DMC_MAX_FW_SIZE 0x6000
> > MODULE_FIRMWARE(ICL_DMC_PATH);
> >
> > #define GLK_DMC_PATH DMC_PATH(glk, 1, 04)
> > -#define GLK_DMC_VERSION_REQUIRED DMC_VERSION(1, 4)
> > #define GLK_DMC_MAX_FW_SIZE 0x4000
> > MODULE_FIRMWARE(GLK_DMC_PATH);
> >
> > #define KBL_DMC_PATH DMC_PATH(kbl, 1, 04)
> > -#define KBL_DMC_VERSION_REQUIRED DMC_VERSION(1, 4)
> > #define KBL_DMC_MAX_FW_SIZE BXT_DMC_MAX_FW_SIZE
> > MODULE_FIRMWARE(KBL_DMC_PATH);
> >
> > #define SKL_DMC_PATH DMC_PATH(skl, 1, 27)
> > -#define SKL_DMC_VERSION_REQUIRED DMC_VERSION(1, 27)
> > #define SKL_DMC_MAX_FW_SIZE BXT_DMC_MAX_FW_SIZE
> > MODULE_FIRMWARE(SKL_DMC_PATH);
> >
> > #define BXT_DMC_PATH DMC_PATH(bxt, 1, 07)
> > -#define BXT_DMC_VERSION_REQUIRED DMC_VERSION(1, 7)
> > #define BXT_DMC_MAX_FW_SIZE 0x3000
> > MODULE_FIRMWARE(BXT_DMC_PATH);
> >
> > @@ -765,17 +754,6 @@ static u32 parse_dmc_fw_css(struct intel_dmc *dmc,
> > return 0;
> > }
> >
> > - if (dmc->required_version &&
> > - css_header->version != dmc->required_version) {
> > - drm_info(&i915->drm, "Refusing to load DMC firmware v%u.%u,"
> > - " please use v%u.%u\n",
> > - DMC_VERSION_MAJOR(css_header->version),
> > - DMC_VERSION_MINOR(css_header->version),
> > - DMC_VERSION_MAJOR(dmc->required_version),
> > - DMC_VERSION_MINOR(dmc->required_version));
> > - return 0;
> > - }
> > -
> > dmc->version = css_header->version;
> >
> > return sizeof(struct intel_css_header);
> > @@ -903,49 +881,38 @@ void intel_dmc_ucode_init(struct drm_i915_private *dev_priv)
> >
> > if (IS_DG2(dev_priv)) {
> > dmc->fw_path = DG2_DMC_PATH;
> > - dmc->required_version = DG2_DMC_VERSION_REQUIRED;
> > dmc->max_fw_size = DISPLAY_VER13_DMC_MAX_FW_SIZE;
> > } else if (IS_ALDERLAKE_P(dev_priv)) {
> > dmc->fw_path = ADLP_DMC_PATH;
> > - dmc->required_version = ADLP_DMC_VERSION_REQUIRED;
> > dmc->max_fw_size = DISPLAY_VER13_DMC_MAX_FW_SIZE;
> > } else if (IS_ALDERLAKE_S(dev_priv)) {
> > dmc->fw_path = ADLS_DMC_PATH;
> > - dmc->required_version = ADLS_DMC_VERSION_REQUIRED;
> > dmc->max_fw_size = DISPLAY_VER12_DMC_MAX_FW_SIZE;
> > } else if (IS_DG1(dev_priv)) {
> > dmc->fw_path = DG1_DMC_PATH;
> > - dmc->required_version = DG1_DMC_VERSION_REQUIRED;
> > dmc->max_fw_size = DISPLAY_VER12_DMC_MAX_FW_SIZE;
> > } else if (IS_ROCKETLAKE(dev_priv)) {
> > dmc->fw_path = RKL_DMC_PATH;
> > - dmc->required_version = RKL_DMC_VERSION_REQUIRED;
> > dmc->max_fw_size = DISPLAY_VER12_DMC_MAX_FW_SIZE;
> > } else if (IS_TIGERLAKE(dev_priv)) {
> > dmc->fw_path = TGL_DMC_PATH;
> > - dmc->required_version = TGL_DMC_VERSION_REQUIRED;
> > dmc->max_fw_size = DISPLAY_VER12_DMC_MAX_FW_SIZE;
> > } else if (DISPLAY_VER(dev_priv) == 11) {
> > dmc->fw_path = ICL_DMC_PATH;
> > - dmc->required_version = ICL_DMC_VERSION_REQUIRED;
> > dmc->max_fw_size = ICL_DMC_MAX_FW_SIZE;
> > } else if (IS_GEMINILAKE(dev_priv)) {
> > dmc->fw_path = GLK_DMC_PATH;
> > - dmc->required_version = GLK_DMC_VERSION_REQUIRED;
> > dmc->max_fw_size = GLK_DMC_MAX_FW_SIZE;
> > } else if (IS_KABYLAKE(dev_priv) ||
> > IS_COFFEELAKE(dev_priv) ||
> > IS_COMETLAKE(dev_priv)) {
> > dmc->fw_path = KBL_DMC_PATH;
> > - dmc->required_version = KBL_DMC_VERSION_REQUIRED;
> > dmc->max_fw_size = KBL_DMC_MAX_FW_SIZE;
> > } else if (IS_SKYLAKE(dev_priv)) {
> > dmc->fw_path = SKL_DMC_PATH;
> > - dmc->required_version = SKL_DMC_VERSION_REQUIRED;
> > dmc->max_fw_size = SKL_DMC_MAX_FW_SIZE;
> > } else if (IS_BROXTON(dev_priv)) {
> > dmc->fw_path = BXT_DMC_PATH;
> > - dmc->required_version = BXT_DMC_VERSION_REQUIRED;
> > dmc->max_fw_size = BXT_DMC_MAX_FW_SIZE;
> > }
> >
> > @@ -958,8 +925,6 @@ void intel_dmc_ucode_init(struct drm_i915_private *dev_priv)
> > }
> >
> > dmc->fw_path = dev_priv->params.dmc_firmware_path;
> > - /* Bypass version check for firmware override. */
> > - dmc->required_version = 0;
> > }
> >
> > if (!dmc->fw_path) {
> > diff --git a/drivers/gpu/drm/i915/display/intel_dmc.h b/drivers/gpu/drm/i915/display/intel_dmc.h
> > index 67e03315ef99..435eab9b016b 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dmc.h
> > +++ b/drivers/gpu/drm/i915/display/intel_dmc.h
> > @@ -25,7 +25,6 @@ enum {
> > struct intel_dmc {
> > struct work_struct work;
> > const char *fw_path;
> > - u32 required_version;
> > u32 max_fw_size; /* bytes */
> > u32 version;
> > struct dmc_fw_info {
> > --
> > 2.39.0
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-01-03 16:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-30 18:24 [Intel-gfx] [PATCH v4 0/1] drm/i915/dmc: Make firmware loading backwards-compatible Gustavo Sousa
2022-12-30 18:24 ` [Intel-gfx] [PATCH v4 1/1] drm/i915/dmc: Do not require specific versions Gustavo Sousa
2023-01-03 16:34 ` Rodrigo Vivi
2023-01-03 16:57 ` Gustavo Sousa
2022-12-30 18:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dmc: Make firmware loading backwards-compatible (rev4) Patchwork
2022-12-30 18:41 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-12-30 18:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-12-30 21:03 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.