From: Mark Brown <broonie@kernel.org>
To: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-samsung-soc@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, rcsekar@samsung.com,
aswani.reddy@samsung.com, pankaj.dubey@samsung.com,
tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org,
alim.akhtar@samsung.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] ASoC: samsung: i2s: add support for FSD I2S
Date: Tue, 3 Jan 2023 18:09:22 +0000 [thread overview]
Message-ID: <Y7RvUlIuXQLUHEna@sirena.org.uk> (raw)
In-Reply-To: <20230103045613.100309-3-p.rajanbabu@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
On Tue, Jan 03, 2023 at 10:26:10AM +0530, Padmanabhan Rajanbabu wrote:
> +void fsd_i2s_fixup_early(struct snd_pcm_substream *substream,
> + struct snd_soc_dai *dai)
> +{
> + struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
> + struct i2s_dai *i2s = to_info(asoc_rtd_to_cpu(rtd, 0));
> + struct i2s_dai *other = get_other_dai(i2s);
> +
> + if (!is_opened(other)) {
> + i2s_set_sysclk(dai, SAMSUNG_I2S_CDCLK, 192, SND_SOC_CLOCK_OUT);
> + i2s_set_sysclk(dai, SAMSUNG_I2S_OPCLK, 0, MOD_OPCLK_PCLK);
> + }
> +}
This looks like we're just hard coding to 192kHz?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com>
Cc: lgirdwood@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, s.nawrocki@samsung.com,
perex@perex.cz, tiwai@suse.com, pankaj.dubey@samsung.com,
alim.akhtar@samsung.com, rcsekar@samsung.com,
aswani.reddy@samsung.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 2/5] ASoC: samsung: i2s: add support for FSD I2S
Date: Tue, 3 Jan 2023 18:09:22 +0000 [thread overview]
Message-ID: <Y7RvUlIuXQLUHEna@sirena.org.uk> (raw)
In-Reply-To: <20230103045613.100309-3-p.rajanbabu@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
On Tue, Jan 03, 2023 at 10:26:10AM +0530, Padmanabhan Rajanbabu wrote:
> +void fsd_i2s_fixup_early(struct snd_pcm_substream *substream,
> + struct snd_soc_dai *dai)
> +{
> + struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
> + struct i2s_dai *i2s = to_info(asoc_rtd_to_cpu(rtd, 0));
> + struct i2s_dai *other = get_other_dai(i2s);
> +
> + if (!is_opened(other)) {
> + i2s_set_sysclk(dai, SAMSUNG_I2S_CDCLK, 192, SND_SOC_CLOCK_OUT);
> + i2s_set_sysclk(dai, SAMSUNG_I2S_OPCLK, 0, MOD_OPCLK_PCLK);
> + }
> +}
This looks like we're just hard coding to 192kHz?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-01-03 18:10 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230103045646epcas5p2a9c43bc3bd187ca69653239a0de73152@epcas5p2.samsung.com>
2023-01-03 4:56 ` [PATCH v2 0/5] ASoC: samsung: fsd: audio support for FSD SoC Padmanabhan Rajanbabu
2023-01-03 4:56 ` Padmanabhan Rajanbabu
2023-01-03 4:56 ` [PATCH v2 1/5] ASoC: dt-bindings: Add FSD I2S controller bindings Padmanabhan Rajanbabu
2023-01-03 4:56 ` Padmanabhan Rajanbabu
2023-01-03 18:04 ` Mark Brown
2023-01-03 18:04 ` Mark Brown
2023-01-09 4:05 ` Padmanabhan Rajanbabu
2023-01-09 4:05 ` Padmanabhan Rajanbabu
2023-01-03 4:56 ` [PATCH v2 2/5] ASoC: samsung: i2s: add support for FSD I2S Padmanabhan Rajanbabu
2023-01-03 4:56 ` Padmanabhan Rajanbabu
2023-01-03 8:23 ` kernel test robot
2023-01-03 8:23 ` kernel test robot
2023-01-03 10:45 ` kernel test robot
2023-01-03 10:45 ` kernel test robot
2023-01-03 11:08 ` Krzysztof Kozlowski
2023-01-03 11:08 ` Krzysztof Kozlowski
2023-01-09 4:04 ` Padmanabhan Rajanbabu
2023-01-09 4:04 ` Padmanabhan Rajanbabu
2023-01-03 18:09 ` Mark Brown [this message]
2023-01-03 18:09 ` Mark Brown
2023-01-09 4:05 ` Padmanabhan Rajanbabu
2023-01-09 4:05 ` Padmanabhan Rajanbabu
2023-01-03 4:56 ` [PATCH v2 3/5] arm64: dts: fsd: Add I2S DAI node for Tesla FSD Padmanabhan Rajanbabu
2023-01-03 4:56 ` Padmanabhan Rajanbabu
2023-01-03 4:56 ` [PATCH v2 4/5] arm64: dts: fsd: Add codec " Padmanabhan Rajanbabu
2023-01-03 4:56 ` Padmanabhan Rajanbabu
2023-01-03 11:11 ` Krzysztof Kozlowski
2023-01-03 11:11 ` Krzysztof Kozlowski
2023-01-09 4:05 ` Padmanabhan Rajanbabu
2023-01-09 4:05 ` Padmanabhan Rajanbabu
2023-01-03 4:56 ` [PATCH v2 5/5] arm64: dts: fsd: Add sound card " Padmanabhan Rajanbabu
2023-01-03 4:56 ` Padmanabhan Rajanbabu
2023-01-03 11:13 ` Krzysztof Kozlowski
2023-01-03 11:13 ` Krzysztof Kozlowski
2023-01-09 4:05 ` Padmanabhan Rajanbabu
2023-01-09 4:05 ` Padmanabhan Rajanbabu
2023-01-09 8:28 ` Krzysztof Kozlowski
2023-01-09 8:28 ` Krzysztof Kozlowski
2023-01-13 12:14 ` Padmanabhan Rajanbabu
2023-01-13 12:14 ` Padmanabhan Rajanbabu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7RvUlIuXQLUHEna@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=aswani.reddy@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=p.rajanbabu@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.