From: Deepak R Varma <drv@mailo.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Saurabh Singh Sengar <ssengar@microsoft.com>,
Praveen Kumar <kumarpraveen@linux.microsoft.com>,
Deepak R Varma <drv@mailo.com>
Subject: Re: [PATCH v4 2/2] tty: serial: dz: convert atomic_* to refcount_* APIs for irq_guard
Date: Wed, 4 Jan 2023 14:30:44 +0530 [thread overview]
Message-ID: <Y7VAPI7Y5tfVUdvR@qemulion> (raw)
In-Reply-To: <Y7U4wiLM/z+H/rOc@kroah.com>
On Wed, Jan 04, 2023 at 09:28:50AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 03, 2023 at 03:39:17PM +0530, Deepak R Varma wrote:
> > On Tue, Jan 03, 2023 at 10:00:48AM +0100, Jiri Slaby wrote:
> > > On 26. 12. 22, 7:21, Deepak R Varma wrote:
> > > > + ret = request_irq(dport->port.irq, dz_interrupt, IRQF_SHARED, "dz", mux);
> > >
> > > How is this related to the above described change?
> >
> > No, it is not. My apologies. I must have joined the lines for improved readability
> > and forgot to revert. I will restore this in next revision based on the feedback
> > on the other patch of this series. OR I can include this change in the current
> > change log as a "while at it..." statement. Would you advise me?
>
> NEVER have a "while at it..." change as part of a commit unless it is
> relevant to the main change being made. You know better...
Sounds very good. Thank you for the advise. I will revert the change in the next
revision.
Thank you,
./drv
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2023-01-04 9:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-24 16:32 [PATCH v3 0/2] tty: serial: dz: convert atomic_* to refcount_* Deepak R Varma
2022-12-26 6:20 ` [PATCH v4 " Deepak R Varma
2022-12-24 16:33 ` [PATCH v3 1/2] tty: serial: dz: convert atomic_* to refcount_* APIs for map_guard Deepak R Varma
2022-12-26 6:21 ` [PATCH v4 " Deepak R Varma
2023-01-03 8:59 ` Jiri Slaby
2023-01-03 10:05 ` Deepak R Varma
2023-01-04 8:28 ` Greg Kroah-Hartman
2023-01-04 8:59 ` Deepak R Varma
2023-01-10 6:19 ` Deepak R Varma
2023-01-10 7:27 ` Reshetova, Elena
2023-01-10 7:47 ` Deepak R Varma
2023-01-10 7:57 ` Greg Kroah-Hartman
2022-12-24 16:34 ` [PATCH 2/2] tty: serial: dz: convert atomic_* to refcount_* APIs for irq_guard Deepak R Varma
2022-12-26 6:21 ` [PATCH v4 " Deepak R Varma
2023-01-03 9:00 ` Jiri Slaby
2023-01-03 10:09 ` Deepak R Varma
2023-01-04 8:28 ` Greg Kroah-Hartman
2023-01-04 9:00 ` Deepak R Varma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7VAPI7Y5tfVUdvR@qemulion \
--to=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kumarpraveen@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=ssengar@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.