All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Steen Hegelund <steen.hegelund@microchip.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	UNGLinuxDriver@microchip.com,
	Randy Dunlap <rdunlap@infradead.org>,
	Casper Andersson <casper.casan@gmail.com>,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Wan Jiabing <wanjiabing@vivo.com>,
	Nathan Huckleberry <nhuck@google.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Daniel Machon <daniel.machon@microchip.com>,
	Horatiu Vultur <horatiu.vultur@microchip.com>,
	Lars Povlsen <lars.povlsen@microchip.com>
Subject: Re: [PATCH net-next 2/8] net: microchip: sparx5: Reset VCAP counter for new rules
Date: Thu, 5 Jan 2023 13:58:20 +0300	[thread overview]
Message-ID: <Y7atTB9r07M+ZUC0@kadam> (raw)
In-Reply-To: <7fa8ea30beffcb9256422f7a474a8be7d5791f5a.camel@microchip.com>

[ Email re-arranged because I screwed up - dan]

On Thu, Jan 05, 2023 at 11:43:17AM +0100, Steen Hegelund wrote:

> This series was first sent to net, but the response was that I should go into
> net-next instead, so it is really a first version in net-next.
> 
> What was your question?  I was not able to find it...

Ugh...  Oauth2 code (mutt/msmtp) silently ate my email.  Sorry.

> > > @@ -1833,6 +1834,8 @@ int vcap_add_rule(struct vcap_rule *rule)
> > >       ret = vcap_write_rule(ri);
> > >       if (ret)
> > >               pr_err("%s:%d: rule write error: %d\n", __func__, __LINE__,
> > > ret);

There should be a "goto out;" after the pr_err().

> > > +     /* Set the counter to zero */
> > > +     ret = vcap_write_counter(ri, &ctr);
> > >  out:
> > >       mutex_unlock(&ri->admin->lock);
> > >       return ret;
> > 

regards,
dan carpenter


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Steen Hegelund <steen.hegelund@microchip.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	UNGLinuxDriver@microchip.com,
	Randy Dunlap <rdunlap@infradead.org>,
	Casper Andersson <casper.casan@gmail.com>,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Wan Jiabing <wanjiabing@vivo.com>,
	Nathan Huckleberry <nhuck@google.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Daniel Machon <daniel.machon@microchip.com>,
	Horatiu Vultur <horatiu.vultur@microchip.com>,
	Lars Povlsen <lars.povlsen@microchip.com>
Subject: Re: [PATCH net-next 2/8] net: microchip: sparx5: Reset VCAP counter for new rules
Date: Thu, 5 Jan 2023 13:58:20 +0300	[thread overview]
Message-ID: <Y7atTB9r07M+ZUC0@kadam> (raw)
In-Reply-To: <7fa8ea30beffcb9256422f7a474a8be7d5791f5a.camel@microchip.com>

[ Email re-arranged because I screwed up - dan]

On Thu, Jan 05, 2023 at 11:43:17AM +0100, Steen Hegelund wrote:

> This series was first sent to net, but the response was that I should go into
> net-next instead, so it is really a first version in net-next.
> 
> What was your question?  I was not able to find it...

Ugh...  Oauth2 code (mutt/msmtp) silently ate my email.  Sorry.

> > > @@ -1833,6 +1834,8 @@ int vcap_add_rule(struct vcap_rule *rule)
> > >       ret = vcap_write_rule(ri);
> > >       if (ret)
> > >               pr_err("%s:%d: rule write error: %d\n", __func__, __LINE__,
> > > ret);

There should be a "goto out;" after the pr_err().

> > > +     /* Set the counter to zero */
> > > +     ret = vcap_write_counter(ri, &ctr);
> > >  out:
> > >       mutex_unlock(&ri->admin->lock);
> > >       return ret;
> > 

regards,
dan carpenter


  reply	other threads:[~2023-01-05 20:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-05  8:13 [PATCH net-next 0/8] Add support for two classes of VCAP rules Steen Hegelund
2023-01-05  8:13 ` Steen Hegelund
2023-01-05  8:13 ` [PATCH net-next 1/8] net: microchip: vcap api: Erase VCAP cache before encoding rule Steen Hegelund
2023-01-05  8:13   ` Steen Hegelund
2023-01-05  8:13 ` [PATCH net-next 2/8] net: microchip: sparx5: Reset VCAP counter for new rules Steen Hegelund
2023-01-05  8:13   ` Steen Hegelund
2023-01-05  9:10   ` Dan Carpenter
2023-01-05  9:10     ` Dan Carpenter
2023-01-05 10:43     ` Steen Hegelund
2023-01-05 10:43       ` Steen Hegelund
2023-01-05 10:58       ` Dan Carpenter [this message]
2023-01-05 10:58         ` Dan Carpenter
2023-01-05 12:20         ` Steen Hegelund
2023-01-05 12:20           ` Steen Hegelund
2023-01-05  8:13 ` [PATCH net-next 3/8] net: microchip: vcap api: Always enable VCAP lookups Steen Hegelund
2023-01-05  8:13   ` Steen Hegelund
2023-01-05  8:13 ` [PATCH net-next 4/8] net: microchip: vcap api: Convert multi-word keys/actions when encoding Steen Hegelund
2023-01-05  8:13   ` Steen Hegelund
2023-01-05  8:13 ` [PATCH net-next 5/8] net: microchip: vcap api: Use src and dst chain id to chain VCAP lookups Steen Hegelund
2023-01-05  8:13   ` Steen Hegelund
2023-01-05  8:13 ` [PATCH net-next 6/8] net: microchip: vcap api: Check chains when adding a tc flower filter Steen Hegelund
2023-01-05  8:13   ` Steen Hegelund
2023-01-05  8:13 ` [PATCH net-next 7/8] net: microchip: vcap api: Add a storage state to a VCAP rule Steen Hegelund
2023-01-05  8:13   ` Steen Hegelund
2023-01-05  8:13 ` [PATCH net-next 8/8] net: microchip: vcap api: Enable/Disable rules via chains in VCAP HW Steen Hegelund
2023-01-05  8:13   ` Steen Hegelund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7atTB9r07M+ZUC0@kadam \
    --to=error27@gmail.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=casper.casan@gmail.com \
    --cc=daniel.machon@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=kuba@kernel.org \
    --cc=lars.povlsen@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nhuck@google.com \
    --cc=pabeni@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=steen.hegelund@microchip.com \
    --cc=wanjiabing@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.