From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] drm/drv: Make use of local variable driver in drm_dev_register()
Date: Thu, 5 Jan 2023 15:33:13 +0100 [thread overview]
Message-ID: <Y7bfqaLUaqXBsBmr@phenom.ffwll.local> (raw)
In-Reply-To: <769f62a9-da8a-188f-fd83-494ce0a7c566@suse.de>
On Tue, Dec 20, 2022 at 08:24:18AM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 19.12.22 um 19:31 schrieb Uwe Kleine-König:
> > There is a local variable that contains dev->driver. Make use of it
> > instead of "open coding" it.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Added to drm-misc-next. Thanks a lot.
Given that Uwe has a pile of drm commits all over, time for drm-misc
commit rights?
https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html#drm-misc
-Daniel
>
> Best regards
> Thomas
>
> > ---
> > drivers/gpu/drm/drm_drv.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> > index 203bf8d6c34c..3cc8e8111d16 100644
> > --- a/drivers/gpu/drm/drm_drv.c
> > +++ b/drivers/gpu/drm/drm_drv.c
> > @@ -889,8 +889,8 @@ int drm_dev_register(struct drm_device *dev, unsigned long flags)
> > dev->registered = true;
> > - if (dev->driver->load) {
> > - ret = dev->driver->load(dev, flags);
> > + if (driver->load) {
> > + ret = driver->load(dev, flags);
> > if (ret)
> > goto err_minors;
> > }
> >
> > base-commit: 678e5b2258e871b22fe8c26edac2723feb852a47
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Ivo Totev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2023-01-05 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 18:31 [PATCH] drm/drv: Make use of local variable driver in drm_dev_register() Uwe Kleine-König
2022-12-20 7:24 ` Thomas Zimmermann
2023-01-05 14:33 ` Daniel Vetter [this message]
2023-01-05 20:16 ` Uwe Kleine-König
2023-01-06 18:57 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7bfqaLUaqXBsBmr@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.