[PATCH] drm/drv: Make use of local variable driver in drm_dev_register()

[PATCH] drm/drv: Make use of local variable driver in drm_dev_register()

[Uwe Kleine-König]

There is a local variable that contains dev->driver. Make use of it
instead of "open coding" it.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/gpu/drm/drm_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index 203bf8d6c34c..3cc8e8111d16 100644
--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -889,8 +889,8 @@ int drm_dev_register(struct drm_device *dev, unsigned long flags)
 
 	dev->registered = true;
 
-	if (dev->driver->load) {
-		ret = dev->driver->load(dev, flags);
+	if (driver->load) {
+		ret = driver->load(dev, flags);
 		if (ret)
 			goto err_minors;
 	}

base-commit: 678e5b2258e871b22fe8c26edac2723feb852a47
-- 
2.38.1

Re: [PATCH] drm/drv: Make use of local variable driver in drm_dev_register()

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 1151 bytes --]

Hi

Am 19.12.22 um 19:31 schrieb Uwe Kleine-König:
> There is a local variable that contains dev->driver. Make use of it
> instead of "open coding" it.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Added to drm-misc-next. Thanks a lot.

Best regards
Thomas

> ---
>   drivers/gpu/drm/drm_drv.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> index 203bf8d6c34c..3cc8e8111d16 100644
> --- a/drivers/gpu/drm/drm_drv.c
> +++ b/drivers/gpu/drm/drm_drv.c
> @@ -889,8 +889,8 @@ int drm_dev_register(struct drm_device *dev, unsigned long flags)
>   
>   	dev->registered = true;
>   
> -	if (dev->driver->load) {
> -		ret = dev->driver->load(dev, flags);
> +	if (driver->load) {
> +		ret = driver->load(dev, flags);
>   		if (ret)
>   			goto err_minors;
>   	}
> 
> base-commit: 678e5b2258e871b22fe8c26edac2723feb852a47

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: [PATCH] drm/drv: Make use of local variable driver in drm_dev_register()

[Daniel Vetter]

On Tue, Dec 20, 2022 at 08:24:18AM +0100, Thomas Zimmermann wrote:
> Hi
> 
> Am 19.12.22 um 19:31 schrieb Uwe Kleine-König:
> > There is a local variable that contains dev->driver. Make use of it
> > instead of "open coding" it.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Added to drm-misc-next. Thanks a lot.

Given that Uwe has a pile of drm commits all over, time for drm-misc
commit rights?

https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html#drm-misc
-Daniel

> 
> Best regards
> Thomas
> 
> > ---
> >   drivers/gpu/drm/drm_drv.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> > index 203bf8d6c34c..3cc8e8111d16 100644
> > --- a/drivers/gpu/drm/drm_drv.c
> > +++ b/drivers/gpu/drm/drm_drv.c
> > @@ -889,8 +889,8 @@ int drm_dev_register(struct drm_device *dev, unsigned long flags)
> >   	dev->registered = true;
> > -	if (dev->driver->load) {
> > -		ret = dev->driver->load(dev, flags);
> > +	if (driver->load) {
> > +		ret = driver->load(dev, flags);
> >   		if (ret)
> >   			goto err_minors;
> >   	}
> > 
> > base-commit: 678e5b2258e871b22fe8c26edac2723feb852a47
> 
> -- 
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Ivo Totev




-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: [PATCH] drm/drv: Make use of local variable driver in drm_dev_register()

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]

Hello Daniel,

On Thu, Jan 05, 2023 at 03:33:13PM +0100, Daniel Vetter wrote:
> On Tue, Dec 20, 2022 at 08:24:18AM +0100, Thomas Zimmermann wrote:
> > Hi
> > 
> > Am 19.12.22 um 19:31 schrieb Uwe Kleine-König:
> > > There is a local variable that contains dev->driver. Make use of it
> > > instead of "open coding" it.
> > > 
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > 
> > Added to drm-misc-next. Thanks a lot.
> 
> Given that Uwe has a pile of drm commits all over, time for drm-misc
> commit rights?

I feel honored, but if you ask me, that's not necessary/sensible. At
least up to now my patches are more or less drive-by changes and letting
them go through someone else with commit access is fine for me. There is
no driver in the drm area I feel responsible for.

Or is this about reducing maintainer load on your end?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] drm/drv: Make use of local variable driver in drm_dev_register()

[Daniel Vetter]

On Thu, Jan 05, 2023 at 09:16:36PM +0100, Uwe Kleine-König wrote:
> Hello Daniel,
> 
> On Thu, Jan 05, 2023 at 03:33:13PM +0100, Daniel Vetter wrote:
> > On Tue, Dec 20, 2022 at 08:24:18AM +0100, Thomas Zimmermann wrote:
> > > Hi
> > > 
> > > Am 19.12.22 um 19:31 schrieb Uwe Kleine-König:
> > > > There is a local variable that contains dev->driver. Make use of it
> > > > instead of "open coding" it.
> > > > 
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > 
> > > Added to drm-misc-next. Thanks a lot.
> > 
> > Given that Uwe has a pile of drm commits all over, time for drm-misc
> > commit rights?
> 
> I feel honored, but if you ask me, that's not necessary/sensible. At
> least up to now my patches are more or less drive-by changes and letting
> them go through someone else with commit access is fine for me. There is
> no driver in the drm area I feel responsible for.
> 
> Or is this about reducing maintainer load on your end?

Yes :-)

Essentially it gives you the keys to drive your own patches, all you have
to do is find someone to review them for you (trading review works best).
And since all regulars have commit rights there's otherwise big confusion
whether patches should be pushed or not. Which means they routinely fall
through cracks and need extra attention from everyone involved.

Also note that commit rights does not mean you assume maintainer
responsibilities for anything (ofc your review is appreciated where you
can help out), that's still separate and tracked in MAINTAINERS as usual.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch