From: Jason Gunthorpe <jgg@nvidia.com>
To: Matthew Rosato <mjrosato@linux.ibm.com>
Cc: jjherne@linux.ibm.com, akrowiak@linux.ibm.com,
kvm@vger.kernel.org, hch@infradead.org,
linux-s390@vger.kernel.org, intel-gfx@lists.freedesktop.org,
cohuck@redhat.com, linux-kernel@vger.kernel.org,
pasic@linux.ibm.com, borntraeger@linux.ibm.com,
intel-gvt-dev@lists.freedesktop.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [Intel-gfx] [PATCH v3 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM
Date: Fri, 6 Jan 2023 10:29:55 -0400 [thread overview]
Message-ID: <Y7gwY1UJq3DNbjRu@nvidia.com> (raw)
In-Reply-To: <d0e55400-d749-23a2-c88f-a2272723bc65@linux.ibm.com>
On Thu, Jan 05, 2023 at 08:03:32PM -0500, Matthew Rosato wrote:
> On 1/5/23 7:32 PM, Jason Gunthorpe wrote:
> > On Thu, Jan 05, 2023 at 07:16:37PM -0500, Matthew Rosato wrote:
> >
> >> Yeah, this is also what I was thinking, replace the direct
> >> kvm_put_kvm calls with, say, schedule_delayed_work in each driver,
> >> where the delayed task just does the kvm_put_kvm (along with a brief
> >> comment explaining why we handle the put asynchronously).
> >
> > Don't put that in every driver, do something like mmput_async() where
> > the core code has all of this.
> >
>
> If the core vfio code were to add logic to invoke kvm_put_kvm and
> kvm_get_kvm, won't this introduce a vfio dependency on kvm? If I
> recall, we have the drivers handling the kvm reference today in
> order to avoid that..
Not in vfio, put it in kvm 'kvm_put_async()'
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Matthew Rosato <mjrosato@linux.ibm.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
cohuck@redhat.com, borntraeger@linux.ibm.com,
jjherne@linux.ibm.com, akrowiak@linux.ibm.com,
pasic@linux.ibm.com, zhenyuw@linux.intel.com,
zhi.a.wang@intel.com, hch@infradead.org,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Kevin Tian <kevin.tian@intel.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM
Date: Fri, 6 Jan 2023 10:29:55 -0400 [thread overview]
Message-ID: <Y7gwY1UJq3DNbjRu@nvidia.com> (raw)
In-Reply-To: <d0e55400-d749-23a2-c88f-a2272723bc65@linux.ibm.com>
On Thu, Jan 05, 2023 at 08:03:32PM -0500, Matthew Rosato wrote:
> On 1/5/23 7:32 PM, Jason Gunthorpe wrote:
> > On Thu, Jan 05, 2023 at 07:16:37PM -0500, Matthew Rosato wrote:
> >
> >> Yeah, this is also what I was thinking, replace the direct
> >> kvm_put_kvm calls with, say, schedule_delayed_work in each driver,
> >> where the delayed task just does the kvm_put_kvm (along with a brief
> >> comment explaining why we handle the put asynchronously).
> >
> > Don't put that in every driver, do something like mmput_async() where
> > the core code has all of this.
> >
>
> If the core vfio code were to add logic to invoke kvm_put_kvm and
> kvm_get_kvm, won't this introduce a vfio dependency on kvm? If I
> recall, we have the drivers handling the kvm reference today in
> order to avoid that..
Not in vfio, put it in kvm 'kvm_put_async()'
Jason
next prev parent reply other threads:[~2023-01-06 14:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 18:33 [PATCH v3 0/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM Matthew Rosato
2022-05-19 18:33 ` [PATCH v3 1/1] " Matthew Rosato
2022-05-20 5:33 ` [Intel-gfx] " Christoph Hellwig
2022-05-20 5:33 ` Christoph Hellwig
2022-05-20 13:36 ` [Intel-gfx] " Jason Gunthorpe
2022-05-20 13:36 ` Jason Gunthorpe
2022-05-20 13:56 ` Tony Krowiak
2022-05-20 14:09 ` Matthew Rosato
2022-05-20 20:59 ` Tony Krowiak
2022-05-23 16:41 ` [Intel-gfx] " Alex Williamson
2022-05-23 16:41 ` Alex Williamson
2022-05-24 11:39 ` [Intel-gfx] " Wang, Zhi A
2022-05-24 11:39 ` Wang, Zhi A
2023-01-05 22:09 ` [Intel-gfx] " Alex Williamson
2023-01-05 22:09 ` Alex Williamson
2023-01-05 23:34 ` [Intel-gfx] " Jason Gunthorpe
2023-01-05 23:34 ` Jason Gunthorpe
2023-01-06 0:16 ` [Intel-gfx] " Matthew Rosato
2023-01-06 0:16 ` Matthew Rosato
2023-01-06 0:32 ` [Intel-gfx] " Jason Gunthorpe
2023-01-06 0:32 ` Jason Gunthorpe
2023-01-06 1:03 ` [Intel-gfx] " Matthew Rosato
2023-01-06 1:03 ` Matthew Rosato
2023-01-06 14:29 ` Jason Gunthorpe [this message]
2023-01-06 14:29 ` Jason Gunthorpe
2022-05-24 16:07 ` [Intel-gfx] [PATCH v3 0/1] " Alex Williamson
2022-05-24 16:07 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7gwY1UJq3DNbjRu@nvidia.com \
--to=jgg@nvidia.com \
--cc=akrowiak@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.