From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "Raj, Ashok" <ashok.raj@intel.com>,
Thomas Gleixner <tglx@linutronix.de>, X86-kernel <x86@kernel.org>,
LKML Mailing List <linux-kernel@vger.kernel.org>,
"Hansen, Dave" <dave.hansen@intel.com>,
"Schofield, Alison" <alison.schofield@intel.com>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH v3 3/6] x86/microcode: Display revisions only when update is successful
Date: Fri, 6 Jan 2023 22:52:45 +0100 [thread overview]
Message-ID: <Y7iYLbEJSYnVn+dW@zn.tnic> (raw)
In-Reply-To: <SJ1PR11MB6083BD0E0191061B72A47982FCFB9@SJ1PR11MB6083.namprd11.prod.outlook.com>
On Fri, Jan 06, 2023 at 09:35:41PM +0000, Luck, Tony wrote:
> # dmesg | tail -1
> microcode revision: 0x40001a -> 0x4001a
>
> User doesn't notice that the version didn't change and thinks
> that all is well.
The version did change. One '0' less.
Users don't read even if you put in there:
"Corrected error, no action required."
User still complains about maybe her hardware going bad and "should I replace my
CPU" yadda yadda...
But whatever, since both of you think this is sooo important, then pls do this:
Success: "Reload completed, microcode revision: 0x%x -> 0x%x\n"
Failure: "Reload failed, current microcode revision: 0x%x\n"
Or something along those lines.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-01-06 21:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 18:02 [PATCH v3 0/6] Some fixes and cleanups for microcode Ashok Raj
2023-01-03 18:02 ` [PATCH v3 1/6] x86/microcode: Add a parameter to microcode_check() to store CPU capabilities Ashok Raj
2023-01-04 18:21 ` Borislav Petkov
2023-01-03 18:02 ` [PATCH v3 2/6] x86/microcode/core: Take a snapshot before and after applying microcode Ashok Raj
2023-01-03 18:46 ` Dave Hansen
2023-01-03 19:37 ` Ashok Raj
2023-01-04 18:56 ` Borislav Petkov
2023-01-06 20:41 ` Ashok Raj
2023-01-03 18:02 ` [PATCH v3 3/6] x86/microcode: Display revisions only when update is successful Ashok Raj
2023-01-04 19:00 ` Borislav Petkov
2023-01-06 19:42 ` Ashok Raj
2023-01-06 19:54 ` Borislav Petkov
2023-01-06 20:29 ` Ashok Raj
2023-01-06 20:45 ` Borislav Petkov
2023-01-06 21:20 ` Ashok Raj
2023-01-07 9:36 ` Ingo Molnar
2023-01-06 21:35 ` Luck, Tony
2023-01-06 21:52 ` Borislav Petkov [this message]
2023-01-03 18:02 ` [PATCH v3 4/6] x86/microcode/intel: Use a plain revision argument for print_ucode_rev() Ashok Raj
2023-01-03 18:02 ` [PATCH v3 5/6] x86/microcode/intel: Print old and new rev during early boot Ashok Raj
2023-01-03 18:02 ` [PATCH v3 6/6] x86/microcode/intel: Print when early microcode loading fails Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7iYLbEJSYnVn+dW@zn.tnic \
--to=bp@alien8.de \
--cc=alison.schofield@intel.com \
--cc=ashok.raj@intel.com \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.