From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Ashok Raj <ashok.raj@intel.com>,
Thomas Gleixner <tglx@linutronix.de>, X86-kernel <x86@kernel.org>,
LKML Mailing List <linux-kernel@vger.kernel.org>,
Dave Hansen <dave.hansen@intel.com>,
Tony Luck <tony.luck@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH v3 3/6] x86/microcode: Display revisions only when update is successful
Date: Sat, 7 Jan 2023 10:36:22 +0100 [thread overview]
Message-ID: <Y7k9DNz//vqBAvZK@gmail.com> (raw)
In-Reply-To: <Y7iIZHa0fuJkHHjz@zn.tnic>
* Borislav Petkov <bp@alien8.de> wrote:
> On Fri, Jan 06, 2023 at 12:29:00PM -0800, Ashok Raj wrote:
> > Yes, that makes sense, Do you think we can add a note that the loading
> > failed? since the old -> new, new is coming from new microcode rev.
>
> It has failed when
>
> old == new.
>
> I.e.,
>
> "microcode revision: 0x1a -> 0x1a"
>
> when the current revision on the CPU is 0x1a.
So wouldn't it make sense to also display the fact that the microcode
loading failed?
Seeing '0x1a -> 0x1a' one might naively assume from the wording alone that
it got "reloaded" or somehow reset, or that there's some sub-revision
update that isn't visible in the revision version - when in fact nothing
happened, right?
The kernel usually tries to tell users unambigiously when some requested
operation didn't succeed - not just hint at it somewhat
passive-aggressively.
Thanks,
Ingo
next prev parent reply other threads:[~2023-01-07 9:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 18:02 [PATCH v3 0/6] Some fixes and cleanups for microcode Ashok Raj
2023-01-03 18:02 ` [PATCH v3 1/6] x86/microcode: Add a parameter to microcode_check() to store CPU capabilities Ashok Raj
2023-01-04 18:21 ` Borislav Petkov
2023-01-03 18:02 ` [PATCH v3 2/6] x86/microcode/core: Take a snapshot before and after applying microcode Ashok Raj
2023-01-03 18:46 ` Dave Hansen
2023-01-03 19:37 ` Ashok Raj
2023-01-04 18:56 ` Borislav Petkov
2023-01-06 20:41 ` Ashok Raj
2023-01-03 18:02 ` [PATCH v3 3/6] x86/microcode: Display revisions only when update is successful Ashok Raj
2023-01-04 19:00 ` Borislav Petkov
2023-01-06 19:42 ` Ashok Raj
2023-01-06 19:54 ` Borislav Petkov
2023-01-06 20:29 ` Ashok Raj
2023-01-06 20:45 ` Borislav Petkov
2023-01-06 21:20 ` Ashok Raj
2023-01-07 9:36 ` Ingo Molnar [this message]
2023-01-06 21:35 ` Luck, Tony
2023-01-06 21:52 ` Borislav Petkov
2023-01-03 18:02 ` [PATCH v3 4/6] x86/microcode/intel: Use a plain revision argument for print_ucode_rev() Ashok Raj
2023-01-03 18:02 ` [PATCH v3 5/6] x86/microcode/intel: Print old and new rev during early boot Ashok Raj
2023-01-03 18:02 ` [PATCH v3 6/6] x86/microcode/intel: Print when early microcode loading fails Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7k9DNz//vqBAvZK@gmail.com \
--to=mingo@kernel.org \
--cc=alison.schofield@intel.com \
--cc=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.