Re: [PATCH v4 2/3] clk: imx: imx8mp: add shared clk gate for usb suspend clk

[Abel Vesa <abel.vesa@linaro.org>]

On 23-01-09 12:52:17, Abel Vesa wrote:
> On 22-10-27 10:39:16, Stephen Boyd wrote:
> > Quoting Jun Li (2022-10-19 02:26:00)
> > > Hi Stephen,
> > > 
> > > > -----Original Message-----
> > > > From: Jun Li <jun.li@nxp.com>
> > > > Sent: Friday, September 30, 2022 10:54 PM
> > > > To: sboyd@kernel.org; abelvesa@kernel.org
> > > > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> > > > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> > > > festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>;
> > > > mturquette@baylibre.com; l.stach@pengutronix.de; Peng Fan
> > > > <peng.fan@nxp.com>; alexander.stein@ew.tq-group.com;
> > > > gregkh@linuxfoundation.org; devicetree@vger.kernel.org;
> > > > linux-arm-kernel@lists.infradead.org; linux-clk@vger.kernel.org
> > > > Subject: [PATCH v4 2/3] clk: imx: imx8mp: add shared clk gate for usb suspend
> > > > clk
> > > > 
> > > > 32K usb suspend clock gate is shared with usb_root_clk, this shared clock
> > > > gate was initially defined only for usb suspend clock, usb suspend clk is
> > > > kept on while system is active or system sleep with usb wakeup enabled, so
> > > > usb root clock is fine with this situation; with the commit cf7f3f4fa9e5
> > > > ("clk: imx8mp: fix usb_root_clk parent"), this clock gate is changed to be
> > > > for usb root clock, but usb root clock will be off while usb is suspended,
> > > > so usb suspend clock will be gated too, this cause some usb functionalities
> > > > will not work, so define this clock to be a shared clock gate to conform
> > > > with the real HW status.
> > > > 
> > > > Fixes: 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver")
> > > > Cc: stable@vger.kernel.org # v5.19+
> > > > Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > Signed-off-by: Li Jun <jun.li@nxp.com>
> > > 
> > > Is this version okay for you? 
> > > 
> > 
> > I thought that Abel was going to pick these up.
> 
> Oh, sorry, I thought the fixes will be picked up by you.
> 
> I'll apply it to my tree then.

Ugrh, ignore this.

Already applied.

My inbox is messed up a bit right now.

Sorry about that.