From: Vinod Koul <vkoul@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
pierre-louis.bossart@linux.intel.com,
linux-kernel@vger.kernel.org, sanyog.r.kale@intel.com,
yung-chuan.liao@linux.intel.com
Subject: Re: [PATCH v2 0/3] soundwire: cadence: Fix oversized FIFO size define
Date: Mon, 9 Jan 2023 21:36:19 +0530 [thread overview]
Message-ID: <Y7w7ex/r1Z95gyt/@matsya> (raw)
In-Reply-To: <20221202161812.4186897-1-rf@opensource.cirrus.com>
On 02-12-22, 16:18, Richard Fitzgerald wrote:
> As determined by experimentation and asking a hardware person, the FIFO
> in the Cadence IP is actually only 8 entries long, not 32. This is fixed
> in patch #1.
>
> As a bonus, patches #2 and #3 fix two other things I noticed while
> debugging this.
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: pierre-louis.bossart@linux.intel.com,
yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH v2 0/3] soundwire: cadence: Fix oversized FIFO size define
Date: Mon, 9 Jan 2023 21:36:19 +0530 [thread overview]
Message-ID: <Y7w7ex/r1Z95gyt/@matsya> (raw)
In-Reply-To: <20221202161812.4186897-1-rf@opensource.cirrus.com>
On 02-12-22, 16:18, Richard Fitzgerald wrote:
> As determined by experimentation and asking a hardware person, the FIFO
> in the Cadence IP is actually only 8 entries long, not 32. This is fixed
> in patch #1.
>
> As a bonus, patches #2 and #3 fix two other things I noticed while
> debugging this.
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2023-01-09 16:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 16:18 [PATCH v2 0/3] soundwire: cadence: Fix oversized FIFO size define Richard Fitzgerald
2022-12-02 16:18 ` Richard Fitzgerald
2022-12-02 16:18 ` [PATCH v2 1/3] soundwire: cadence: Don't overflow the command FIFOs Richard Fitzgerald
2022-12-02 16:18 ` Richard Fitzgerald
2022-12-02 16:18 ` [PATCH v2 2/3] soundwire: cadence: Remove wasted space in response_buf Richard Fitzgerald
2022-12-02 16:18 ` Richard Fitzgerald
2022-12-02 16:18 ` [PATCH v2 3/3] soundwire: cadence: Drain the RX FIFO after an IO timeout Richard Fitzgerald
2022-12-02 16:18 ` Richard Fitzgerald
2022-12-02 17:10 ` [PATCH v2 0/3] soundwire: cadence: Fix oversized FIFO size define Pierre-Louis Bossart
2022-12-02 17:10 ` Pierre-Louis Bossart
2023-01-09 16:06 ` Vinod Koul [this message]
2023-01-09 16:06 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7w7ex/r1Z95gyt/@matsya \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rf@opensource.cirrus.com \
--cc=sanyog.r.kale@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.