* Re: [PATCHv2 00/12] iov_iter: replace import_single_range with ubuf
[not found] <20230105190741.2405013-1-kbusch@meta.com>
@ 2023-01-08 17:12 ` Christoph Hellwig
2023-01-09 9:31 ` David Howells
[not found] ` <20230105190741.2405013-3-kbusch@meta.com>
2023-01-09 3:51 ` [PATCHv2 00/12] iov_iter: replace import_single_range with ubuf Jens Axboe
2 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2023-01-08 17:12 UTC (permalink / raw)
To: Keith Busch
Cc: linux-kernel, Alexander Viro, Jens Axboe, linux-aio,
linux-fsdevel, hch, io-uring, Pavel Begunkov, Eric Dumazet,
Steven Rostedt, davem, Jakub Kicinski, Paolo Abeni, David Howells,
Jarkko Sakkinen, Paul Moore, keyrings, linux-security-module,
linux-trace-kernel, linux-block, netdev, Keith Busch
The entire series looks good to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2 02/12] io_uring: switch network send/recv to ITER_UBUF
[not found] ` <20230105190741.2405013-3-kbusch@meta.com>
@ 2023-01-09 3:49 ` Jens Axboe
0 siblings, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2023-01-09 3:49 UTC (permalink / raw)
To: Keith Busch, linux-kernel, Alexander Viro
Cc: linux-aio, linux-fsdevel, hch, io-uring, Pavel Begunkov,
Eric Dumazet, Steven Rostedt, davem, Jakub Kicinski, Paolo Abeni,
David Howells, Jarkko Sakkinen, Paul Moore, keyrings,
linux-security-module, linux-trace-kernel, linux-block, netdev,
Keith Busch
On 1/5/23 12:07 PM, Keith Busch wrote:
> From: Jens Axboe <axboe@kernel.dk>
>
> This is more efficient that iter_iov.
Looks like that s/that/than typo ended up in a few spots throughout
this series... Nothing major, but figured I'd bring it up.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2 00/12] iov_iter: replace import_single_range with ubuf
[not found] <20230105190741.2405013-1-kbusch@meta.com>
2023-01-08 17:12 ` [PATCHv2 00/12] iov_iter: replace import_single_range with ubuf Christoph Hellwig
[not found] ` <20230105190741.2405013-3-kbusch@meta.com>
@ 2023-01-09 3:51 ` Jens Axboe
2 siblings, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2023-01-09 3:51 UTC (permalink / raw)
To: Keith Busch, linux-kernel, Alexander Viro
Cc: linux-aio, linux-fsdevel, hch, io-uring, Pavel Begunkov,
Eric Dumazet, Steven Rostedt, davem, Jakub Kicinski, Paolo Abeni,
David Howells, Jarkko Sakkinen, Paul Moore, keyrings,
linux-security-module, linux-trace-kernel, linux-block, netdev,
Keith Busch
On 1/5/23 12:07 PM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> ITER_UBUF is a more efficient representation when using single vector
> buffers, providing small optimizations over ITER_IOVEC. This series
> introduces a helper to set these up, and replaces all applicable users
> of import_single_range with the new helper. And since there are no
> single range users left after this change, the helper is no longer
> needed.
>
> As noted in v1(*), there are some fundamental differences to how io_uring
> compares to read/write/readv/writev. There are only the two affected
> file_operations, and they already do not work with io_uring due to their
> diverging semantics for vectored vs non-vectored read/write. Therefore,
> this series having io_uring prefer ubuf iov_iter isn't introducing new
> breakage.
Pondering how to stage this, both for later upstream but also for
testing. Would probably make the best sense to stage 1-5 separately,
and then just punt the remaining ones to the appropriate subsystems.
And then 12/12 can go in when they have all been applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2 00/12] iov_iter: replace import_single_range with ubuf
2023-01-08 17:12 ` [PATCHv2 00/12] iov_iter: replace import_single_range with ubuf Christoph Hellwig
@ 2023-01-09 9:31 ` David Howells
2023-01-09 15:12 ` Keith Busch
0 siblings, 1 reply; 5+ messages in thread
From: David Howells @ 2023-01-09 9:31 UTC (permalink / raw)
To: Christoph Hellwig
Cc: dhowells, Keith Busch, linux-kernel, Alexander Viro, Jens Axboe,
linux-aio, linux-fsdevel, io-uring, Pavel Begunkov, Eric Dumazet,
Steven Rostedt, davem, Jakub Kicinski, Paolo Abeni,
Jarkko Sakkinen, Paul Moore, keyrings, linux-security-module,
linux-trace-kernel, linux-block, netdev, Keith Busch
lore.kernel.org doesn't seem to have the patches.
https://lore.kernel.org/lkml/20230105190741.2405013-1-kbusch@meta.com/
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2 00/12] iov_iter: replace import_single_range with ubuf
2023-01-09 9:31 ` David Howells
@ 2023-01-09 15:12 ` Keith Busch
0 siblings, 0 replies; 5+ messages in thread
From: Keith Busch @ 2023-01-09 15:12 UTC (permalink / raw)
To: David Howells
Cc: Christoph Hellwig, Keith Busch, linux-kernel, Alexander Viro,
Jens Axboe, linux-aio, linux-fsdevel, io-uring, Pavel Begunkov,
Eric Dumazet, Steven Rostedt, davem, Jakub Kicinski, Paolo Abeni,
Jarkko Sakkinen, Paul Moore, keyrings, linux-security-module,
linux-trace-kernel, linux-block, netdev
On Mon, Jan 09, 2023 at 09:31:08AM +0000, David Howells wrote:
> lore.kernel.org doesn't seem to have the patches.
>
> https://lore.kernel.org/lkml/20230105190741.2405013-1-kbusch@meta.com/
That's frustrating. Seems like an email setup problem on my end. I'll
split this series up and resend.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-09 15:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230105190741.2405013-1-kbusch@meta.com>
2023-01-08 17:12 ` [PATCHv2 00/12] iov_iter: replace import_single_range with ubuf Christoph Hellwig
2023-01-09 9:31 ` David Howells
2023-01-09 15:12 ` Keith Busch
[not found] ` <20230105190741.2405013-3-kbusch@meta.com>
2023-01-09 3:49 ` [PATCHv2 02/12] io_uring: switch network send/recv to ITER_UBUF Jens Axboe
2023-01-09 3:51 ` [PATCHv2 00/12] iov_iter: replace import_single_range with ubuf Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.