All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] firmware: arm_scmi: Clean up a return statement
Date: Tue, 24 Jan 2023 09:20:23 +0000	[thread overview]
Message-ID: <Y8+i14h0bfo3aOeb@e120937-lin> (raw)
In-Reply-To: <Y86im5M49p3ePGxj@kili>

On Mon, Jan 23, 2023 at 06:07:07PM +0300, Dan Carpenter wrote:
> The comments say "enabled" where "disabled" is intended.  Also it's
> cleaner to return zero explicitly instead of ret.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
>  drivers/firmware/arm_scmi/driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index d21c7eafd641..703f16ef3953 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -2739,8 +2739,8 @@ static int scmi_probe(struct platform_device *pdev)
>  				if (ret)
>  					goto clear_dev_req_notifier;
>  
> -				/* Bail out anyway when coex enabled */
> -				return ret;
> +				/* Bail out anyway when coex disabled. */
> +				return 0;
>  			}
>  
>  			/* Coex enabled, carry on in any case. */
> -- 

Indeed.

Thanks,
Cristian

WARNING: multiple messages have this Message-ID (diff)
From: Cristian Marussi <cristian.marussi@arm.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] firmware: arm_scmi: Clean up a return statement
Date: Tue, 24 Jan 2023 09:20:23 +0000	[thread overview]
Message-ID: <Y8+i14h0bfo3aOeb@e120937-lin> (raw)
In-Reply-To: <Y86im5M49p3ePGxj@kili>

On Mon, Jan 23, 2023 at 06:07:07PM +0300, Dan Carpenter wrote:
> The comments say "enabled" where "disabled" is intended.  Also it's
> cleaner to return zero explicitly instead of ret.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
>  drivers/firmware/arm_scmi/driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index d21c7eafd641..703f16ef3953 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -2739,8 +2739,8 @@ static int scmi_probe(struct platform_device *pdev)
>  				if (ret)
>  					goto clear_dev_req_notifier;
>  
> -				/* Bail out anyway when coex enabled */
> -				return ret;
> +				/* Bail out anyway when coex disabled. */
> +				return 0;
>  			}
>  
>  			/* Coex enabled, carry on in any case. */
> -- 

Indeed.

Thanks,
Cristian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-01-24  9:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23 15:07 [PATCH] firmware: arm_scmi: Clean up a return statement Dan Carpenter
2023-01-23 15:07 ` Dan Carpenter
2023-01-24  9:20 ` Cristian Marussi [this message]
2023-01-24  9:20   ` Cristian Marussi
2023-03-09 14:10 ` Sudeep Holla
2023-03-09 14:10   ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8+i14h0bfo3aOeb@e120937-lin \
    --to=cristian.marussi@arm.com \
    --cc=error27@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.