From: Wolfram Sang <wsa@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Peter Rosin <peda@axentia.se>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 3/3] i2c: gpio: support write-only sda/scl w/o pull-up
Date: Mon, 23 Jan 2023 23:21:40 +0100 [thread overview]
Message-ID: <Y88IdIeNKa6UiCFc@shikoro> (raw)
In-Reply-To: <7eea145d-d5a7-052c-e458-18f3b842c2ec@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]
On Wed, Jan 18, 2023 at 10:55:12PM +0100, Heiner Kallweit wrote:
> There are slave devices that understand I2C but have read-only SDA and
> SCL. Examples are FD650 7-segment LED controller and its derivatives.
> Typical board designs don't even have a pull-up for both pins.
> Handle the new attributes for write-only SDA and missing pull-up on
> SDA/SCL.
>
> For either pin the open-drain and has-no-pullup properties are
> mutually-exclusive, what is documented in the DT property documentation.
> We don't add an extra warning here because the open-drain properties
> are marked deprecated anyway.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied to for-next, thanks!
> + pdata->sda_is_output_only =
> + of_property_read_bool(np, "i2c-gpio,sda-output-only");
> + pdata->sda_has_no_pullup =
> + of_property_read_bool(np, "i2c-gpio,sda-has-no-pullup");
> + pdata->scl_has_no_pullup =
> + of_property_read_bool(np, "i2c-gpio,scl-has-no-pullup");
I converted these to device_property_read_bool() because of 7b6e9dc7e42d
("i2c: gpio: Add support on ACPI-based system") which is in my for-next.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-01-23 22:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 21:49 [PATCH v5 0/3] i2c: gpio: support write-only sda Heiner Kallweit
2023-01-18 21:51 ` [PATCH v5 1/3] dt-bindings: i2c-gpio: Add properties for dealing with write-only SDA/SCL w/o pullup Heiner Kallweit
2023-01-23 21:08 ` Rob Herring
2023-01-23 22:20 ` Wolfram Sang
2023-01-18 21:54 ` [PATCH v5 2/3] i2c: algo: bit: allow getsda to be NULL Heiner Kallweit
2023-01-23 22:20 ` Wolfram Sang
2023-01-18 21:55 ` [PATCH v5 3/3] i2c: gpio: support write-only sda/scl w/o pull-up Heiner Kallweit
2023-01-23 22:21 ` Wolfram Sang [this message]
2023-01-20 10:27 ` [PATCH v5 0/3] i2c: gpio: support write-only sda Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y88IdIeNKa6UiCFc@shikoro \
--to=wsa@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.